Uh oh!
There was an error while loading. Please reload this page.
Add Content-Length header for empty bytestream - #866
Conversation
Also, fixed related tests
1af18f9 to
2f146a3CompareContent-Length header for empty bytestreamlovelydinosaur
commented
Mar 30, 2020
I think we need to be more careful with this. Eg. we shouldn't be sending I note the RFC text wrt "A user agent SHOULD send a Content-Length in a request message when no Transfer-Encoding is sent and the request method defines a meaning for an enclosed payload body." although even in that case I'd like us to start by validating what the equivelent behaviour in urllib3/requests would be there. |
lovelydinosaur
commented
Mar 30, 2020
I'd suggest we might want to start off with a PR reverting this change, since it improves the RFC behaviour in one case, but regresses it in another "A user agent SHOULD NOT send a Content-Length header field when the request message does not contain a payload body and the method semantics do not anticipate such a body." We can then take a second look at this. |
| def test_no_content(): | ||
| request = httpx.Request("GET", "http://example.org") | ||
| assert "Content-Length" not in request.headers | ||
| assert request.headers["Content-Length"] == "0" |
There was a problem hiding this comment.
We shouldn't send Content-Length with GET/HEAD requests
References:
- Add
Content-Lengthheader for empty bytestream #866 (comment) - https://tools.ietf.org/html/rfc7230#section-3.3.2 "A user agent SHOULD NOT ..."
requestsimplementation for non-stream requests https://github.com/psf/requests/blob/fd13816d015c4c90ee65297fa996caea6a094ed1/requests/models.py#L522-L533requestsimplementation for stream requests https://github.com/psf/requests/blob/fd13816d015c4c90ee65297fa996caea6a094ed1/requests/models.py#L476-L479
This reverts commit 939f3ce.
Bumps [trio-typing](https://github.com/python-trio/trio-typing) from 0.9.0 to 0.10.0. - [Commits](python-trio/trio-typing@v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: trio-typing dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com>
Reference: #861 (comment)