#650 Add Type-Check to test

tests/test_api.py

@@ -1,24 +1,27 @@
+import typing
+
 import pytest
+from uvicorn.main import Server
 
 import httpx
 
 
-def test_get(server):
+def test_get(server: Server) -> None:
  response = httpx.get(server.url)
  assert response.status_code == 200
  assert response.reason_phrase == "OK"
  assert response.text == "Hello, world!"
  assert response.http_version == "HTTP/1.1"
 
 
-def test_post(server):
+def test_post(server: Server) -> None:
  response = httpx.post(server.url, data=b"Hello, world!")
  assert response.status_code == 200
  assert response.reason_phrase == "OK"
 
 
-def test_post_byte_iterator(server):
- def data():
+def test_post_byte_iterator(server: Server) -> None:
+ def data() -> typing.Generator[bytes, None, None]:
  yield b"Hello"
  yield b", "
  yield b"world!"
@@ -28,37 +31,37 @@ def data():
  assert response.reason_phrase == "OK"
 
 
-def test_options(server):
+def test_options(server: Server) -> None:
  response = httpx.options(server.url)
  assert response.status_code == 200
  assert response.reason_phrase == "OK"
 
 
-def test_head(server):
+def test_head(server: Server) -> None:
  response = httpx.head(server.url)
  assert response.status_code == 200
  assert response.reason_phrase == "OK"
 
 
-def test_put(server):
+def test_put(server: Server) -> None:
  response = httpx.put(server.url, data=b"Hello, world!")
  assert response.status_code == 200
  assert response.reason_phrase == "OK"
 
 
-def test_patch(server):
+def test_patch(server: Server) -> None:
  response = httpx.patch(server.url, data=b"Hello, world!")
  assert response.status_code == 200
  assert response.reason_phrase == "OK"
 
 
-def test_delete(server):
+def test_delete(server: Server) -> None:
  response = httpx.delete(server.url)
  assert response.status_code == 200
  assert response.reason_phrase == "OK"
 
 
-def test_stream(server):
+def test_stream(server: Server) -> None:
  with httpx.stream("GET", server.url) as response:
  response.read()
 
@@ -69,6 +72,6 @@ def test_stream(server):
 
 
 @pytest.mark.asyncio
-async def test_get_invalid_url(server):
+async def test_get_invalid_url(server: Server) -> None:
  with pytest.raises(httpx.InvalidURL):
- await httpx.get("invalid://example.org")
+ await httpx.get("invalid://example.org") # type:ignore

tests/test_asgi.py

@@ -1,9 +1,11 @@
+from typing import Callable, Dict
+
 import pytest
 
 import httpx
 
 
-async def hello_world(scope, receive, send):
+async def hello_world(scope: Dict, receive: Callable, send: Callable) -> None:
  status = 200
  output = b"Hello, World!"
  headers = [(b"content-type", "text/plain"), (b"content-length", str(len(output)))]
@@ -12,7 +14,7 @@ async def hello_world(scope, receive, send):
  await send({"type": "http.response.body", "body": output})
 
 
-async def echo_body(scope, receive, send):
+async def echo_body(scope: Dict, receive: Callable, send: Callable) -> None:
  status = 200
  headers = [(b"content-type", "text/plain")]
 
@@ -25,11 +27,13 @@ async def echo_body(scope, receive, send):
  await send({"type": "http.response.body", "body": body, "more_body": more_body})
 
 
-async def raise_exc(scope, receive, send):
+async def raise_exc(scope: Dict, receive: Callable, send: Callable) -> None:
  raise ValueError()
 
 
-async def raise_exc_after_response(scope, receive, send):
+async def raise_exc_after_response(
+ scope: Dict, receive: Callable, send: Callable
+) -> None:
  status = 200
  output = b"Hello, World!"
  headers = [(b"content-type", "text/plain"), (b"content-length", str(len(output)))]
@@ -40,30 +44,30 @@ async def raise_exc_after_response(scope, receive, send):
 
 
 @pytest.mark.asyncio
-async def test_asgi():
+async def test_asgi() -> None:
  client = httpx.AsyncClient(app=hello_world)
  response = await client.get("http://www.example.org/")
  assert response.status_code == 200
  assert response.text == "Hello, World!"
 
 
 @pytest.mark.asyncio
-async def test_asgi_upload():
+async def test_asgi_upload() -> None:
  client = httpx.AsyncClient(app=echo_body)
  response = await client.post("http://www.example.org/", data=b"example")
  assert response.status_code == 200
  assert response.text == "example"
 
 
 @pytest.mark.asyncio
-async def test_asgi_exc():
+async def test_asgi_exc() -> None:
  client = httpx.AsyncClient(app=raise_exc)
  with pytest.raises(ValueError):
  await client.get("http://www.example.org/")
 
 
 @pytest.mark.asyncio
-async def test_asgi_exc_after_response():
+async def test_asgi_exc_after_response() -> None:
  client = httpx.AsyncClient(app=raise_exc_after_response)
  with pytest.raises(ValueError):
  await client.get("http://www.example.org/")