Uh oh!
There was an error while loading. Please reload this page.
[Superseded] Move type definitions to a dedicated module - #881
Closed
florimondmanca wants to merge 5 commits into
Closed
[Superseded] Move type definitions to a dedicated module#881florimondmanca wants to merge 5 commits into
florimondmanca wants to merge 5 commits into
Conversation
Merged
Comment on lines
+284
to
+285
| for name, filevalue in files.items(): | ||
| yield self.FileField(name=name, value=filevalue) |
ContributorAuthor
There was a problem hiding this comment.
Different variable name to value is required of mypy would complain that the value in data doesn't have the same type as the value in files (but ideally we don't want to just use Any here).
florimondmancaforce-pushed
the
types-module
branch
from
March 29, 2020 15:01
6c2bd25 to
7fdef17Compareflorimondmanca
commented
Mar 29, 2020
ContributorAuthor
Realizing that this might become largely reduced in scope once #804 is in, so let's wait… |
florimondmanca
commented
Apr 10, 2020
ContributorAuthor
Closed in favor of #902 |
Kludex referenced
this pull request
in pydantic/httpx2
May 11, 2026
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.1.9 to 0.2.1. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@v0.1.9...v0.2.1) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/encode/httpx/issues/789#issuecomment-578143085
Also improves/fixes the typing information in the multipart stream implementation, as some of it was actually wrong.