Uh oh!
There was an error while loading. Please reload this page.
Rename pool limit options - #968
Merged
Merged
Conversation
lovelydinosaur
commented
May 21, 2020
ContributorAuthor
The URLLib3 changes here will become redundant after #966, but I'm going to ignore that here to keep this PR tightly scoped. |
yeraydiazdiaz
left a comment
Contributor
There was a problem hiding this comment.
Nice, we'll need to change the docs as well. 👍
Uh oh!
There was an error while loading. Please reload this page.
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Superb 🎉
Looks like we need to address the new Optional[int] from HTTPCore.
Uh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
May 21, 2020
ContributorAuthor
Merged #967 into this as we're dependant on it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #948