Skip to content

Tighten up types in multipart upload implementation - #975

Merged
florimondmanca merged 2 commits into
masterfrom
multipart-types
May 21, 2020
Merged

Tighten up types in multipart upload implementation#975
florimondmanca merged 2 commits into
masterfrom
multipart-types

Conversation

@florimondmanca

Copy link
Copy Markdown
Contributor

Refs #974

Use our type aliases for request files to more tightly type-check the MultipartStream implementation.

Helps catching any type-related issues such as the one resolved by #974.

@florimondmancaflorimondmanca added the refactor Issues and PRs related to code refactoring label May 21, 2020

@lovelydinosaurlovelydinosaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey doke.

@florimondmanca
florimondmanca merged commit 9f58afd into masterMay 21, 2020
@florimondmanca
florimondmanca deleted the multipart-types branch May 21, 2020 15:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactorIssues and PRs related to code refactoring

Development

Successfully merging this pull request may close these issues.

2 participants

@florimondmanca@lovelydinosaur