Skip to content

Fix ARM trailing data directive size - #383

Open
floze-the-genius wants to merge 4 commits into
encounter:mainfrom
floze-the-genius:fix/issue-382-arm-data-directive
Open

Fix ARM trailing data directive size#383
floze-the-genius wants to merge 4 commits into
encounter:mainfrom
floze-the-genius:fix/issue-382-arm-data-directive

Conversation

@floze-the-genius

Copy link
Copy Markdown

Summary

Testing

  • cargo test

Closes#382

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d69d306dfb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadobjdiff-core/src/arch/arm.rs Outdated
@floze-the-genius
floze-the-geniusforce-pushed the fix/issue-382-arm-data-directive branch from d69d306 to 8027551CompareJuly 19, 2026 19:17
@floze-the-genius
floze-the-geniusforce-pushed the fix/issue-382-arm-data-directive branch from 8027551 to e2b98ebCompareJuly 20, 2026 13:23

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:e2b98eb517

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadobjdiff-core/src/arch/arm.rs Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:2c6124bd9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadobjdiff-core/src/arch/arm.rs Outdated
@floze-the-genius

Copy link
Copy Markdown
Author

@LagoLunatic Thanks for supplying the corrected object fixture on #382. The three edge cases raised during automated review are now covered and all threads are resolved: 4n+2 padding, overlapping relocations in the final word, and data mappings starting at 2 mod 4. Current head 64cf492 is mergeable; 19 checks pass (4 release-only jobs are skipped). Could you review whether the ARM size-inference behavior now matches the intended mapping-symbol semantics? I’m happy to rebase onto current main if you prefer that before review.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ARM/Thumb: Final data directive size is incorrect

1 participant

@floze-the-genius