COFF: Fix symbols being incorrectly sorted within section groups - #395
Open
LagoLunatic wants to merge 1 commit into
Open
COFF: Fix symbols being incorrectly sorted within section groups#395LagoLunatic wants to merge 1 commit into
LagoLunatic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objdiff sorts all symbols when reading the object (#316), but this currently only sorts them within their own section. COFF has groups of sections like
rdataand multiplerdata$rs. This PR fixes the sorting so the symbols are sorted relative to other sections within the same group first. This fixes two bugs: