Skip to content

COFF: Fix symbols being incorrectly sorted within section groups - #395

Open
LagoLunatic wants to merge 1 commit into
encounter:mainfrom
LagoLunatic:order-coff-groups
Open

COFF: Fix symbols being incorrectly sorted within section groups#395
LagoLunatic wants to merge 1 commit into
encounter:mainfrom
LagoLunatic:order-coff-groups

Conversation

@LagoLunatic

Copy link
Copy Markdown
Collaborator

objdiff sorts all symbols when reading the object (#316), but this currently only sorts them within their own section. COFF has groups of sections like rdata and multiple rdata$rs. This PR fixes the sorting so the symbols are sorted relative to other sections within the same group first. This fixes two bugs:

  • The combine sections feature would change the order of symbols when enabled (fixesSection merging seems to alter section order #392)
  • The order diffing feature incorrectly marks some symbols in grouped sections as being in the wrong order, even when they're in the right order and sections are unmerged
image

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Section merging seems to alter section order

1 participant

@LagoLunatic