Skip to content
This repository was archived by the owner on Aug 9, 2026. It is now read-only.

feat(email): remove circle around signer-verified checkmark - #173

Merged
rubenhensen merged 3 commits into
mainfrom
email-remove-checkmark-circle
Jun 4, 2026
Merged

feat(email): remove circle around signer-verified checkmark#173
rubenhensen merged 3 commits into
mainfrom
email-remove-checkmark-circle

Conversation

@rubenhensen

@rubenhensenrubenhensen commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Drop the bordered circle wrapping the inline checkmark above the signer-verified email in the HTML email template; the checkmark image now renders on its own.
  • Refresh the CHECK_PNG doc comment so it no longer references the removed circle.

Test plan

  • Send a test email and confirm the checkmark renders without the surrounding circle across major mail clients.

@rubenhensen
feat(email): replace unicode checkmark with inline PNG image
560ea8f
The signer-verified circle previously rendered a unicode `✓`
glyph which is styled inconsistently across mail clients. Embed a
PNG of the PostGuard checkmark via `cid:pg-check` to match the
shape used in the download page UI.
@rubenhensen
feat(email): remove circle around signer-verified checkmark
d296260
@dobby-coder

dobby-coderBot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Dobby has received the request! Routing to the right specialist now...

@rubenhensen
Merge remote-tracking branch 'origin/main' into email-remove-checkmar…
b1768a4
…k-circle
# Conflicts:
#	src/email.rs
#	templates/email/email.html
dobby-coder[bot]
dobby-coderBot approved these changes Jun 4, 2026
View reviewed changes

@dobby-coderdobby-coderBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Cosmetic email-template change; tests pass. Minor: build_body doc at src/email.rs:209 still names only cid:pg-logo though the function now also attaches cid:pg-check. PR description only covers the second commit — the cumulative diff against main also adds CHECK_PNG, templates/email/check.png, and the unicode→inline-PNG swap, so reviewers reading the description alone will miss those.

Rule compliance

No issues found.

Comment threadtemplates/email/email.html
<span style="display:inline-block;width:32px;height:32px;line-height:32px;border-radius:50%;border:2px solid #5F7381;text-align:center;box-sizing:border-box;">
<img src="cid:pg-check" alt="" width="16" height="13" style="display:inline-block;vertical-align:middle;" />
</span>
<img src="cid:pg-check" alt="" width="16" height="13" style="display:inline-block;vertical-align:middle;" />

@dobby-coderdobby-coderBotJun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Code review] alt="" treats the checkmark as decorative; consider alt="Verified" (or similar) so screen readers convey the signer-verified semantic that the styled circle previously implied.

@rubenhensen
rubenhensen merged commit edd5257 into mainJun 4, 2026
6 checks passed
@rubenhensen
rubenhensen deleted the email-remove-checkmark-circle branch June 4, 2026 13:45
@github-actionsgithub-actionsBot mentioned this pull request Jun 4, 2026
Closed
@dobby-coderdobby-coderBot mentioned this pull request Jun 6, 2026
Merged
2 tasks
@github-actionsgithub-actionsBot mentioned this pull request Aug 7, 2026
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@dobby-coderdobby-coder[bot]dobby-coder[bot] approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rubenhensen