Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 9, 2026. It is now read-only.
chore: remove unused qrcode, strum and strum_macros deps - #195
Merged
Conversation
These three dependencies were declared in Cargo.toml but never used anywhere in the crate. Removing them prunes qrcode's image subtree (image, moxcms, pxfm, byteorder-lite) and strum's heck from Cargo.lock. Closes#191 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ContributorAuthor
There was a problem hiding this comment.
VERDICT: approve
Rules Dobby 2 sign-off — clean.
Removes qrcode, strum, strum_macros from Cargo.toml and prunes them plus their orphaned transitives (image, moxcms, pxfm, byteorder-lite, heck) from Cargo.lock. Only Cargo.toml/Cargo.lock change; no source touched.
Verified against the applicable rules for this Rust backend diff:
- conventional-commit-pr-titles —
pr-title.ymlpresent;chore:title is valid. - check-dep-is-used-before-bumping — no
qrcode/strumreferences insrc/orbuild.rs; removal is the endorsed action. - pr-close-issue-keywords — body has
Closes #191(own line). - rust-run-cargo-fmt-before-push — fmt + clippy + 151 tests all green.
- Reviewer already assigned (@rubenhensen).
No blocking issues and no nits. Flipping out of draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes three dependencies declared in
Cargo.tomlbut never referenced anywhere in the crate:qrcode,strum, andstrum_macros. Rebuilding pruned them and their orphaned transitives (image,moxcms,pxfm,byteorder-lite,heck) fromCargo.lock.Quality gate passes locally:
cargo fmt --all -- --check,cargo clippy --all-targets -- -D warnings,cargo test --all-targets(151 passed).Closes#191