Test logging interface - #4

Merged
enigbe merged 12 commits into
mainfrom
2025-02-test-logging-interface
Mar 17, 2025
Merged

Test logging interface#4
enigbe merged 12 commits into
mainfrom
2025-02-test-logging-interface

Conversation

@enigbe

@enigbeenigbe commented Feb 10, 2025•
edited
Loading

Copy link
Copy Markdown
Owner

What this PR does:

This is another follow-up PR to lightningdevkit#407 where we test the log facade and custom logging interfaces.

It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.

@enigbe
enigbeforce-pushed the 2025-02-test-logging-interface branch 2 times, most recently from da2edcc to d85c5c5CompareFebruary 10, 2025 14:27
@enigbe
enigbeforce-pushed the 2025-02-test-logging-interface branch 3 times, most recently from 30bee82 to 4e59771CompareFebruary 23, 2025 22:51
tnull added 11 commits March 3, 2025 15:32
@tnull
Pinidna_adapterto fix MSRV CI (lightningdevkit#480)
e9c435a
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`,
which requires a rust version of 1.81, conflicting with our MSRV.
Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
@tnull
Prefactor: Rename fields for clarity
f40a007
Previously, we named internal fields/APIs `lspsX_service` as us being
the client was implied. Since we're about to also add service-side
functionalities, such naming would start to get confusing. We hence
rename them to follow a `lspsX_client` scheme, and will add the
service-side APIs using the `service` terminology.
@tnull
Refactor derive_xprv to make it reusable
5680fcd
.. and while we're at it we move the VSS child key indexes to constants.
@tnull
Prefix the lightning-liqudity config types with Ldk for clarity
1357121
.. we might eventually want to drop them anyways, but for now we rename
them to make them easily discernable from their counterparts in
`builder.rs`.
@tnull
Move LSPSXClientConfig to liquidity
82f28a7
.. for consistency, as we're about to add `LSPS2ServiceConfig` there,
too.
@tnull
Allow configuring LSPS2 service via builders
3e0f6ee
We add the capability to configure LSPS2 service mode in `Builder` and
`LiquiditySourceBuilder`.
@tnull
Add LDK event handling
76a4206
.. and forward it to our `LiquditySource`.
@tnull
Move PaymentForwarded event emission down
ec1cff5
.. to align with other event handling variants: First log, then act,
then emit event if everything went okay.
@tnull
Add LSPS2ServiceEvent handling
f78f086
.. so far we just silently fail if something goes wrong, eventually
we'll need to implement retrying channel opens to honor buy requests
that didn't succeed on the first attempt.
@tnull
Add LSPS2 client<>service integration test
1091952
@tnull
Merge pull requestlightningdevkit#420from tnull/2024-12-add-lsps2-s…
edb0560
…ervice-support
Add bLIP-52 / LSPS2 service-side support
@enigbe
enigbeforce-pushed the 2025-02-test-logging-interface branch from 4e59771 to 7e27939CompareMarch 4, 2025 12:06
@enigbe
test: introduce TestConfig and improve logging tests
56d5dc9
General improvements:
- Add TestConfig wrapper around Config to allow per-test
log field overrides while preserving the general test setup.
- Test facade logger.
- Add logging module and validate log entries.
- Improve UniFFI logging adding UniFFI flag for relevant
log objects.
- Remove facade level, because the concrete `Log` impl
controls max log level.
@enigbe
enigbeforce-pushed the 2025-02-test-logging-interface branch from 7e27939 to 56d5dc9CompareMarch 10, 2025 16:01
@enigbe
enigbe merged commit 22cb1df into mainMar 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enigbe@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Test logging interface - #4
Merged
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Mar 17, 2025
Merged
Test logging interface#4
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Conversation
@enigbe
@enigbeenigbe
commented
Feb 10, 2025•

edited

Loading

Copy link


Copy Markdown

Owner
What this PR does:
This is another follow-up PR to lightningdevkit#407 where we test the log facade and custom logging interfaces.
It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
2 times, most recently
from
da2edcc to
d85c5c5CompareFebruary 10, 2025 14:27
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
3 times, most recently
from
30bee82 to
4e59771CompareFebruary 23, 2025 22:51
tnull
added 11 commits
March 3, 2025 15:32
@tnull
Pinidna_adapterto fix MSRV CI (lightningdevkit#480)
e9c435a
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`,
which requires a rust version of 1.81, conflicting with our MSRV.
Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
@tnull
Prefactor: Rename fields for clarity
f40a007
Previously, we named internal fields/APIs `lspsX_service` as us being
the client was implied. Since we're about to also add service-side
functionalities, such naming would start to get confusing. We hence
rename them to follow a `lspsX_client` scheme, and will add the
service-side APIs using the `service` terminology.
@tnull
Refactor derive_xprv to make it reusable
5680fcd
.. and while we're at it we move the VSS child key indexes to constants.
@tnull
Prefix the lightning-liqudity config types with Ldk for clarity
1357121
.. we might eventually want to drop them anyways, but for now we rename
them to make them easily discernable from their counterparts in
`builder.rs`.
@tnull
Move LSPSXClientConfig to liquidity
82f28a7
.. for consistency, as we're about to add `LSPS2ServiceConfig` there,
too.
@tnull
Allow configuring LSPS2 service via builders
3e0f6ee
We add the capability to configure LSPS2 service mode in `Builder` and
`LiquiditySourceBuilder`.
@tnull
Add LDK event handling
76a4206
.. and forward it to our `LiquditySource`.
@tnull
Move PaymentForwarded event emission down
ec1cff5
.. to align with other event handling variants: First log, then act,
then emit event if everything went okay.
@tnull
Add LSPS2ServiceEvent handling
f78f086
.. so far we just silently fail if something goes wrong, eventually
we'll need to implement retrying channel opens to honor buy requests
that didn't succeed on the first attempt.
@tnull
Add LSPS2 client<>service integration test
1091952
@tnull
Merge pull requestlightningdevkit#420from tnull/2024-12-add-lsps2-s…
edb0560
…ervice-support
Add bLIP-52 / LSPS2 service-side support
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
4e59771 to
7e27939CompareMarch 4, 2025 12:06
@enigbe
test: introduce TestConfig and improve logging tests
56d5dc9
General improvements:
- Add TestConfig wrapper around Config to allow per-test
log field overrides while preserving the general test setup.
- Test facade logger.
- Add logging module and validate log entries.
- Improve UniFFI logging adding UniFFI flag for relevant
log objects.
- Remove facade level, because the concrete `Log` impl
controls max log level.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
7e27939 to
56d5dc9CompareMarch 10, 2025 16:01
@enigbe
enigbe
merged commit 22cb1df
into
mainMar 17, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@enigbe@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Test logging interface - #4
Merged
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Mar 17, 2025
Merged
Test logging interface#4
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Conversation
@enigbe
@enigbeenigbe
commented
Feb 10, 2025•

edited

Loading

Copy link


Copy Markdown

Owner
What this PR does:
This is another follow-up PR to lightningdevkit#407 where we test the log facade and custom logging interfaces.
It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
2 times, most recently
from
da2edcc to
d85c5c5CompareFebruary 10, 2025 14:27
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
3 times, most recently
from
30bee82 to
4e59771CompareFebruary 23, 2025 22:51
tnull
added 11 commits
March 3, 2025 15:32
@tnull
Pinidna_adapterto fix MSRV CI (lightningdevkit#480)
e9c435a
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`,
which requires a rust version of 1.81, conflicting with our MSRV.
Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
@tnull
Prefactor: Rename fields for clarity
f40a007
Previously, we named internal fields/APIs `lspsX_service` as us being
the client was implied. Since we're about to also add service-side
functionalities, such naming would start to get confusing. We hence
rename them to follow a `lspsX_client` scheme, and will add the
service-side APIs using the `service` terminology.
@tnull
Refactor derive_xprv to make it reusable
5680fcd
.. and while we're at it we move the VSS child key indexes to constants.
@tnull
Prefix the lightning-liqudity config types with Ldk for clarity
1357121
.. we might eventually want to drop them anyways, but for now we rename
them to make them easily discernable from their counterparts in
`builder.rs`.
@tnull
Move LSPSXClientConfig to liquidity
82f28a7
.. for consistency, as we're about to add `LSPS2ServiceConfig` there,
too.
@tnull
Allow configuring LSPS2 service via builders
3e0f6ee
We add the capability to configure LSPS2 service mode in `Builder` and
`LiquiditySourceBuilder`.
@tnull
Add LDK event handling
76a4206
.. and forward it to our `LiquditySource`.
@tnull
Move PaymentForwarded event emission down
ec1cff5
.. to align with other event handling variants: First log, then act,
then emit event if everything went okay.
@tnull
Add LSPS2ServiceEvent handling
f78f086
.. so far we just silently fail if something goes wrong, eventually
we'll need to implement retrying channel opens to honor buy requests
that didn't succeed on the first attempt.
@tnull
Add LSPS2 client<>service integration test
1091952
@tnull
Merge pull requestlightningdevkit#420from tnull/2024-12-add-lsps2-s…
edb0560
…ervice-support
Add bLIP-52 / LSPS2 service-side support
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
4e59771 to
7e27939CompareMarch 4, 2025 12:06
@enigbe
test: introduce TestConfig and improve logging tests
56d5dc9
General improvements:
- Add TestConfig wrapper around Config to allow per-test
log field overrides while preserving the general test setup.
- Test facade logger.
- Add logging module and validate log entries.
- Improve UniFFI logging adding UniFFI flag for relevant
log objects.
- Remove facade level, because the concrete `Log` impl
controls max log level.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
7e27939 to
56d5dc9CompareMarch 10, 2025 16:01
@enigbe
enigbe
merged commit 22cb1df
into
mainMar 17, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@enigbe@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Test logging interface - #4
Merged
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Mar 17, 2025
Merged
Test logging interface#4
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Conversation
@enigbe
@enigbeenigbe
commented
Feb 10, 2025•

edited

Loading

Copy link


Copy Markdown

Owner
What this PR does:
This is another follow-up PR to lightningdevkit#407 where we test the log facade and custom logging interfaces.
It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
2 times, most recently
from
da2edcc to
d85c5c5CompareFebruary 10, 2025 14:27
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
3 times, most recently
from
30bee82 to
4e59771CompareFebruary 23, 2025 22:51
tnull
added 11 commits
March 3, 2025 15:32
@tnull
Pinidna_adapterto fix MSRV CI (lightningdevkit#480)
e9c435a
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`,
which requires a rust version of 1.81, conflicting with our MSRV.
Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
@tnull
Prefactor: Rename fields for clarity
f40a007
Previously, we named internal fields/APIs `lspsX_service` as us being
the client was implied. Since we're about to also add service-side
functionalities, such naming would start to get confusing. We hence
rename them to follow a `lspsX_client` scheme, and will add the
service-side APIs using the `service` terminology.
@tnull
Refactor derive_xprv to make it reusable
5680fcd
.. and while we're at it we move the VSS child key indexes to constants.
@tnull
Prefix the lightning-liqudity config types with Ldk for clarity
1357121
.. we might eventually want to drop them anyways, but for now we rename
them to make them easily discernable from their counterparts in
`builder.rs`.
@tnull
Move LSPSXClientConfig to liquidity
82f28a7
.. for consistency, as we're about to add `LSPS2ServiceConfig` there,
too.
@tnull
Allow configuring LSPS2 service via builders
3e0f6ee
We add the capability to configure LSPS2 service mode in `Builder` and
`LiquiditySourceBuilder`.
@tnull
Add LDK event handling
76a4206
.. and forward it to our `LiquditySource`.
@tnull
Move PaymentForwarded event emission down
ec1cff5
.. to align with other event handling variants: First log, then act,
then emit event if everything went okay.
@tnull
Add LSPS2ServiceEvent handling
f78f086
.. so far we just silently fail if something goes wrong, eventually
we'll need to implement retrying channel opens to honor buy requests
that didn't succeed on the first attempt.
@tnull
Add LSPS2 client<>service integration test
1091952
@tnull
Merge pull requestlightningdevkit#420from tnull/2024-12-add-lsps2-s…
edb0560
…ervice-support
Add bLIP-52 / LSPS2 service-side support
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
4e59771 to
7e27939CompareMarch 4, 2025 12:06
@enigbe
test: introduce TestConfig and improve logging tests
56d5dc9
General improvements:
- Add TestConfig wrapper around Config to allow per-test
log field overrides while preserving the general test setup.
- Test facade logger.
- Add logging module and validate log entries.
- Improve UniFFI logging adding UniFFI flag for relevant
log objects.
- Remove facade level, because the concrete `Log` impl
controls max log level.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
7e27939 to
56d5dc9CompareMarch 10, 2025 16:01
@enigbe
enigbe
merged commit 22cb1df
into
mainMar 17, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@enigbe@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Test logging interface - #4
Merged
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Mar 17, 2025
Merged
Test logging interface#4
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Conversation
@enigbe
@enigbeenigbe
commented
Feb 10, 2025•

edited

Loading

Copy link


Copy Markdown

Owner
What this PR does:
This is another follow-up PR to lightningdevkit#407 where we test the log facade and custom logging interfaces.
It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
2 times, most recently
from
da2edcc to
d85c5c5CompareFebruary 10, 2025 14:27
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
3 times, most recently
from
30bee82 to
4e59771CompareFebruary 23, 2025 22:51
tnull
added 11 commits
March 3, 2025 15:32
@tnull
Pinidna_adapterto fix MSRV CI (lightningdevkit#480)
e9c435a
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`,
which requires a rust version of 1.81, conflicting with our MSRV.
Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
@tnull
Prefactor: Rename fields for clarity
f40a007
Previously, we named internal fields/APIs `lspsX_service` as us being
the client was implied. Since we're about to also add service-side
functionalities, such naming would start to get confusing. We hence
rename them to follow a `lspsX_client` scheme, and will add the
service-side APIs using the `service` terminology.
@tnull
Refactor derive_xprv to make it reusable
5680fcd
.. and while we're at it we move the VSS child key indexes to constants.
@tnull
Prefix the lightning-liqudity config types with Ldk for clarity
1357121
.. we might eventually want to drop them anyways, but for now we rename
them to make them easily discernable from their counterparts in
`builder.rs`.
@tnull
Move LSPSXClientConfig to liquidity
82f28a7
.. for consistency, as we're about to add `LSPS2ServiceConfig` there,
too.
@tnull
Allow configuring LSPS2 service via builders
3e0f6ee
We add the capability to configure LSPS2 service mode in `Builder` and
`LiquiditySourceBuilder`.
@tnull
Add LDK event handling
76a4206
.. and forward it to our `LiquditySource`.
@tnull
Move PaymentForwarded event emission down
ec1cff5
.. to align with other event handling variants: First log, then act,
then emit event if everything went okay.
@tnull
Add LSPS2ServiceEvent handling
f78f086
.. so far we just silently fail if something goes wrong, eventually
we'll need to implement retrying channel opens to honor buy requests
that didn't succeed on the first attempt.
@tnull
Add LSPS2 client<>service integration test
1091952
@tnull
Merge pull requestlightningdevkit#420from tnull/2024-12-add-lsps2-s…
edb0560
…ervice-support
Add bLIP-52 / LSPS2 service-side support
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
4e59771 to
7e27939CompareMarch 4, 2025 12:06
@enigbe
test: introduce TestConfig and improve logging tests
56d5dc9
General improvements:
- Add TestConfig wrapper around Config to allow per-test
log field overrides while preserving the general test setup.
- Test facade logger.
- Add logging module and validate log entries.
- Improve UniFFI logging adding UniFFI flag for relevant
log objects.
- Remove facade level, because the concrete `Log` impl
controls max log level.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
7e27939 to
56d5dc9CompareMarch 10, 2025 16:01
@enigbe
enigbe
merged commit 22cb1df
into
mainMar 17, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@enigbe@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Test logging interface - #4
Merged
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Mar 17, 2025
Merged
Test logging interface#4
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Conversation
@enigbe
@enigbeenigbe
commented
Feb 10, 2025•

edited

Loading

Copy link


Copy Markdown

Owner
What this PR does:
This is another follow-up PR to lightningdevkit#407 where we test the log facade and custom logging interfaces.
It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
2 times, most recently
from
da2edcc to
d85c5c5CompareFebruary 10, 2025 14:27
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
3 times, most recently
from
30bee82 to
4e59771CompareFebruary 23, 2025 22:51
tnull
added 11 commits
March 3, 2025 15:32
@tnull
Pinidna_adapterto fix MSRV CI (lightningdevkit#480)
e9c435a
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`,
which requires a rust version of 1.81, conflicting with our MSRV.
Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
@tnull
Prefactor: Rename fields for clarity
f40a007
Previously, we named internal fields/APIs `lspsX_service` as us being
the client was implied. Since we're about to also add service-side
functionalities, such naming would start to get confusing. We hence
rename them to follow a `lspsX_client` scheme, and will add the
service-side APIs using the `service` terminology.
@tnull
Refactor derive_xprv to make it reusable
5680fcd
.. and while we're at it we move the VSS child key indexes to constants.
@tnull
Prefix the lightning-liqudity config types with Ldk for clarity
1357121
.. we might eventually want to drop them anyways, but for now we rename
them to make them easily discernable from their counterparts in
`builder.rs`.
@tnull
Move LSPSXClientConfig to liquidity
82f28a7
.. for consistency, as we're about to add `LSPS2ServiceConfig` there,
too.
@tnull
Allow configuring LSPS2 service via builders
3e0f6ee
We add the capability to configure LSPS2 service mode in `Builder` and
`LiquiditySourceBuilder`.
@tnull
Add LDK event handling
76a4206
.. and forward it to our `LiquditySource`.
@tnull
Move PaymentForwarded event emission down
ec1cff5
.. to align with other event handling variants: First log, then act,
then emit event if everything went okay.
@tnull
Add LSPS2ServiceEvent handling
f78f086
.. so far we just silently fail if something goes wrong, eventually
we'll need to implement retrying channel opens to honor buy requests
that didn't succeed on the first attempt.
@tnull
Add LSPS2 client<>service integration test
1091952
@tnull
Merge pull requestlightningdevkit#420from tnull/2024-12-add-lsps2-s…
edb0560
…ervice-support
Add bLIP-52 / LSPS2 service-side support
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
4e59771 to
7e27939CompareMarch 4, 2025 12:06
@enigbe
test: introduce TestConfig and improve logging tests
56d5dc9
General improvements:
- Add TestConfig wrapper around Config to allow per-test
log field overrides while preserving the general test setup.
- Test facade logger.
- Add logging module and validate log entries.
- Improve UniFFI logging adding UniFFI flag for relevant
log objects.
- Remove facade level, because the concrete `Log` impl
controls max log level.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
7e27939 to
56d5dc9CompareMarch 10, 2025 16:01
@enigbe
enigbe
merged commit 22cb1df
into
mainMar 17, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@enigbe@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Test logging interface - #4
Merged
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Mar 17, 2025
Merged
Test logging interface#4
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Conversation
@enigbe
@enigbeenigbe
commented
Feb 10, 2025•

edited

Loading

Copy link


Copy Markdown

Owner
What this PR does:
This is another follow-up PR to lightningdevkit#407 where we test the log facade and custom logging interfaces.
It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
2 times, most recently
from
da2edcc to
d85c5c5CompareFebruary 10, 2025 14:27
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
3 times, most recently
from
30bee82 to
4e59771CompareFebruary 23, 2025 22:51
tnull
added 11 commits
March 3, 2025 15:32
@tnull
Pinidna_adapterto fix MSRV CI (lightningdevkit#480)
e9c435a
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`,
which requires a rust version of 1.81, conflicting with our MSRV.
Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
@tnull
Prefactor: Rename fields for clarity
f40a007
Previously, we named internal fields/APIs `lspsX_service` as us being
the client was implied. Since we're about to also add service-side
functionalities, such naming would start to get confusing. We hence
rename them to follow a `lspsX_client` scheme, and will add the
service-side APIs using the `service` terminology.
@tnull
Refactor derive_xprv to make it reusable
5680fcd
.. and while we're at it we move the VSS child key indexes to constants.
@tnull
Prefix the lightning-liqudity config types with Ldk for clarity
1357121
.. we might eventually want to drop them anyways, but for now we rename
them to make them easily discernable from their counterparts in
`builder.rs`.
@tnull
Move LSPSXClientConfig to liquidity
82f28a7
.. for consistency, as we're about to add `LSPS2ServiceConfig` there,
too.
@tnull
Allow configuring LSPS2 service via builders
3e0f6ee
We add the capability to configure LSPS2 service mode in `Builder` and
`LiquiditySourceBuilder`.
@tnull
Add LDK event handling
76a4206
.. and forward it to our `LiquditySource`.
@tnull
Move PaymentForwarded event emission down
ec1cff5
.. to align with other event handling variants: First log, then act,
then emit event if everything went okay.
@tnull
Add LSPS2ServiceEvent handling
f78f086
.. so far we just silently fail if something goes wrong, eventually
we'll need to implement retrying channel opens to honor buy requests
that didn't succeed on the first attempt.
@tnull
Add LSPS2 client<>service integration test
1091952
@tnull
Merge pull requestlightningdevkit#420from tnull/2024-12-add-lsps2-s…
edb0560
…ervice-support
Add bLIP-52 / LSPS2 service-side support
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
4e59771 to
7e27939CompareMarch 4, 2025 12:06
@enigbe
test: introduce TestConfig and improve logging tests
56d5dc9
General improvements:
- Add TestConfig wrapper around Config to allow per-test
log field overrides while preserving the general test setup.
- Test facade logger.
- Add logging module and validate log entries.
- Improve UniFFI logging adding UniFFI flag for relevant
log objects.
- Remove facade level, because the concrete `Log` impl
controls max log level.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
7e27939 to
56d5dc9CompareMarch 10, 2025 16:01
@enigbe
enigbe
merged commit 22cb1df
into
mainMar 17, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@enigbe@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Test logging interface - #4
Merged
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Mar 17, 2025
Merged
Test logging interface#4
enigbe merged 12 commits into
mainfrom 
2025-02-test-logging-interface
Conversation
@enigbe
@enigbeenigbe
commented
Feb 10, 2025•

edited

Loading

Copy link


Copy Markdown

Owner
What this PR does:
This is another follow-up PR to lightningdevkit#407 where we test the log facade and custom logging interfaces.
It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
2 times, most recently
from
da2edcc to
d85c5c5CompareFebruary 10, 2025 14:27
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
3 times, most recently
from
30bee82 to
4e59771CompareFebruary 23, 2025 22:51
tnull
added 11 commits
March 3, 2025 15:32
@tnull
Pinidna_adapterto fix MSRV CI (lightningdevkit#480)
e9c435a
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`,
which requires a rust version of 1.81, conflicting with our MSRV.
Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
@tnull
Prefactor: Rename fields for clarity
f40a007
Previously, we named internal fields/APIs `lspsX_service` as us being
the client was implied. Since we're about to also add service-side
functionalities, such naming would start to get confusing. We hence
rename them to follow a `lspsX_client` scheme, and will add the
service-side APIs using the `service` terminology.
@tnull
Refactor derive_xprv to make it reusable
5680fcd
.. and while we're at it we move the VSS child key indexes to constants.
@tnull
Prefix the lightning-liqudity config types with Ldk for clarity
1357121
.. we might eventually want to drop them anyways, but for now we rename
them to make them easily discernable from their counterparts in
`builder.rs`.
@tnull
Move LSPSXClientConfig to liquidity
82f28a7
.. for consistency, as we're about to add `LSPS2ServiceConfig` there,
too.
@tnull
Allow configuring LSPS2 service via builders
3e0f6ee
We add the capability to configure LSPS2 service mode in `Builder` and
`LiquiditySourceBuilder`.
@tnull
Add LDK event handling
76a4206
.. and forward it to our `LiquditySource`.
@tnull
Move PaymentForwarded event emission down
ec1cff5
.. to align with other event handling variants: First log, then act,
then emit event if everything went okay.
@tnull
Add LSPS2ServiceEvent handling
f78f086
.. so far we just silently fail if something goes wrong, eventually
we'll need to implement retrying channel opens to honor buy requests
that didn't succeed on the first attempt.
@tnull
Add LSPS2 client<>service integration test
1091952
@tnull
Merge pull requestlightningdevkit#420from tnull/2024-12-add-lsps2-s…
edb0560
…ervice-support
Add bLIP-52 / LSPS2 service-side support
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
4e59771 to
7e27939CompareMarch 4, 2025 12:06
@enigbe
test: introduce TestConfig and improve logging tests
56d5dc9
General improvements:
- Add TestConfig wrapper around Config to allow per-test
log field overrides while preserving the general test setup.
- Test facade logger.
- Add logging module and validate log entries.
- Improve UniFFI logging adding UniFFI flag for relevant
log objects.
- Remove facade level, because the concrete `Log` impl
controls max log level.
@enigbe
enigbeforce-pushed
the
2025-02-test-logging-interface
branch
from
7e27939 to
56d5dc9CompareMarch 10, 2025 16:01
@enigbe
enigbe
merged commit 22cb1df
into
mainMar 17, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@enigbe@tnull