Skip to content

Check for empty localarrays when Distributions are made - #447

Open
cowlicks wants to merge 2 commits into
enthought:masterfrom
cowlicks:check-for-empty-localarrays
Open

Check for empty localarrays when Distributions are made#447
cowlicks wants to merge 2 commits into
enthought:masterfrom
cowlicks:check-for-empty-localarrays

Conversation

@cowlicks

Copy link
Copy Markdown
Contributor

This adds checks to all the Distribution creation paths to make sure that no empty localarrays are created. This should fail several tests until PR #444 is merged. This closes issue #445.

This also adds a Distribution.localsizes instance method, which returns the sizes of the localarrays.

@cowlicks

Copy link
Copy Markdown
ContributorAuthor

Note that this has to duplicate the check for empty localarrays three times. Two for each Distribution classmethod, and one for Distribution's __init__. It would be nice if the Distribution classmethods were refactored to call Distribution's __init__ so we could avoid this duplication.

@kwmsmithkwmsmith added this to the 0.4 milestone Jun 19, 2014
@kwmsmith

Copy link
Copy Markdown
Contributor

@cowlicks please rebase against master.

@cowlicks

Copy link
Copy Markdown
ContributorAuthor

It looks like we have some conflicting implementations here. This PR checks that we don't create any empty LocalArrays, but it looks like that is intended behavior in some of the slicing PR's. See this

@kwmsmithkwmsmith modified the milestones: 0.5, 0.4Jul 7, 2014
@bgrantbgrant modified the milestones: 0.5, 0.6Aug 12, 2014
@bgrantbgrant modified the milestones: 0.7, 0.6Oct 16, 2015
@bgrant

Copy link
Copy Markdown
Contributor

Postponing to 0.7.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cowlicks@kwmsmith@bgrant