') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Attempt at a clearer example of data channels by corranwebster · Pull Request #785 · enthought/pyface · GitHub
Skip to content

Attempt at a clearer example of data channels - #785

Draft
corranwebster wants to merge 1 commit into
mainfrom
enh/data-view-clearer-channel-example
Draft

Attempt at a clearer example of data channels#785
corranwebster wants to merge 1 commit into
mainfrom
enh/data-view-clearer-channel-example

Conversation

@corranwebster

@corranwebstercorranwebster commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

This bundles country info into an object that contains name and flag information with a custom value type that handles it.

Hopefully this example makes clearer the idea that an item in a model may be more complex than just a scalar value and may have multiple linked data channels.

This is a draft, because it may make sense to bundle this example in with the EnumType PR in some way.

corranwebster
corranwebster commented Oct 23, 2020
View reviewed changes
Comment threadexamples/data_view/row_table_example.py
city = Str()

country = Str()
country = Instance(Country, allow_none=True)

@corranwebstercorranwebsterOct 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
country=Instance(Country, allow_none=True)
country=Instance(Country, allow_none=False)

D'oh!

@codecov-io

codecov-io commented Oct 23, 2020

Copy link
Copy Markdown

Codecov Report

Merging #785 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #785 +/- ##
==========================================
+ Coverage 40.81% 40.88% +0.07% 
==========================================
Files 508 508 Lines 27832 27832 Branches 4217 4217 ==========================================
+ Hits 11359 11379 +20 + Misses 15992 15979 -13 + Partials 481 474 -7
Impacted FilesCoverage Δ
pyface/ui/wx/data_view/data_view_model.py56.14% <0.00%> (-1.76%)⬇️
pyface/ui/qt4/console/console_widget.py29.28% <0.00%> (+0.20%)⬆️
pyface/ui/qt4/code_editor/code_widget.py44.39% <0.00%> (+0.84%)⬆️
pyface/wx/python_stc.py10.36% <0.00%> (+1.21%)⬆️
pyface/ui/wx/window.py77.10% <0.00%> (+2.40%)⬆️
pyface/ui/qt4/util/gui_test_assistant.py80.53% <0.00%> (+2.65%)⬆️
pyface/ui/wx/data_view/data_view_widget.py77.52% <0.00%> (+5.61%)⬆️
pyface/__init__.py88.88% <0.00%> (+7.40%)⬆️
pyface/i_file_dialog.py84.61% <0.00%> (+7.69%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5565f...115e589. Read the comment docs.

@codecov-commenter

codecov-commenter commented Apr 7, 2026•
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.88%. Comparing base (0d5565f) to head (115e589).
⚠️ Report is 253 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## main #785 +/- ##
==========================================
+ Coverage 40.81% 40.88% +0.07% 
==========================================
Files 508 508 Lines 27832 27832 Branches 4217 4217 ==========================================
+ Hits 11359 11379 +20 + Misses 15992 15979 -13 + Partials 481 474 -7

see 9 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5565f...115e589. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corranwebster@codecov-io@codecov-commenter