Fix issue #342 by itziakos · Pull Request #343 · enthought/traits

itziakos · 2017-01-13T09:07:36Z

This PR renames the trait attribute of _TraitsChangeCollector to fix#342. There is no change at the constructor signature but I add a deprecation warning that prompts users to stop using trait

mdickinson · 2017-01-26T09:24:57Z

Given that this is a private class, it's tempting not to bother with the DeprecationWarning.

OTOH, apparently this class is directly imported in traits_enaml and pyface. :-(

mdickinson · 2017-01-26T09:33:56Z

We should probably make this class public at some point.

LGTM. I'm not a big fan of the name monitor_traits. What do you think of using trait_name instead?

mdickinson · 2017-01-26T09:48:53Z

Another possibility, which I think I prefer to this one: don't deprecate use of the trait keyword at all. Rename the trait trait to _trait, and do the same dance in __init__ as before to accept trait as a keyword and assign the corresponding object to the _trait trait. This lets us use the existing more natural signature when creating a _TraitsChangeCollector object, and avoids the need to update other packages that are importing this object.

The downside is that now if you want to dig the trait out of the collector, you need to access it through _trait. But that doesn't seem like something that would be needed to me.

corranwebster · 2017-04-07T10:56:19Z

 import unittest2 as unittest
 else:
- import unittest
+ import unittest # noqa


Since we're messing with this anyway, can we drop the unittest2 import as 2.6 is no longer supported.

corranwebster · 2017-04-07T11:01:00Z


+ def __init__(self, **traits):
+ value = traits.pop('trait', None)
+ if value is not None:


I think if 'trait' in traits: is better here with a traits['monitor_trait'] = traits.pop('trait') below.
Less confusing if initialized with trait=None (which will slip through undetected as an error).

corranwebster · 2017-04-07T11:03:07Z

I agree about the name monitor_trait. I think trait_name is preferable to the option of using _trait.

stefanoborini · 2017-05-26T12:07:29Z

@corranwebster can this be merged?

corranwebster

LGTM

mdickinson

LGTM2

itziakos · 2017-01-13T09:07:36Z

This PR renames the trait attribute of _TraitsChangeCollector to fix#342. There is no change at the constructor signature but I add a deprecation warning that prompts users to stop using trait

mdickinson · 2017-01-26T09:24:57Z

Given that this is a private class, it's tempting not to bother with the DeprecationWarning.

OTOH, apparently this class is directly imported in traits_enaml and pyface. :-(

mdickinson · 2017-01-26T09:33:56Z

We should probably make this class public at some point.

LGTM. I'm not a big fan of the name monitor_traits. What do you think of using trait_name instead?

mdickinson · 2017-01-26T09:48:53Z

Another possibility, which I think I prefer to this one: don't deprecate use of the trait keyword at all. Rename the trait trait to _trait, and do the same dance in __init__ as before to accept trait as a keyword and assign the corresponding object to the _trait trait. This lets us use the existing more natural signature when creating a _TraitsChangeCollector object, and avoids the need to update other packages that are importing this object.

The downside is that now if you want to dig the trait out of the collector, you need to access it through _trait. But that doesn't seem like something that would be needed to me.

corranwebster · 2017-04-07T10:56:19Z

 import unittest2 as unittest
 else:
- import unittest
+ import unittest # noqa


Since we're messing with this anyway, can we drop the unittest2 import as 2.6 is no longer supported.

corranwebster · 2017-04-07T11:01:00Z


+ def __init__(self, **traits):
+ value = traits.pop('trait', None)
+ if value is not None:


I think if 'trait' in traits: is better here with a traits['monitor_trait'] = traits.pop('trait') below.
Less confusing if initialized with trait=None (which will slip through undetected as an error).

corranwebster · 2017-04-07T11:03:07Z

I agree about the name monitor_trait. I think trait_name is preferable to the option of using _trait.

stefanoborini · 2017-05-26T12:07:29Z

@corranwebster can this be merged?

corranwebster

LGTM

mdickinson

LGTM2

itziakos · 2017-01-13T09:07:36Z

This PR renames the trait attribute of _TraitsChangeCollector to fix#342. There is no change at the constructor signature but I add a deprecation warning that prompts users to stop using trait

mdickinson · 2017-01-26T09:24:57Z

Given that this is a private class, it's tempting not to bother with the DeprecationWarning.

OTOH, apparently this class is directly imported in traits_enaml and pyface. :-(

mdickinson · 2017-01-26T09:33:56Z

We should probably make this class public at some point.

LGTM. I'm not a big fan of the name monitor_traits. What do you think of using trait_name instead?

mdickinson · 2017-01-26T09:48:53Z

Another possibility, which I think I prefer to this one: don't deprecate use of the trait keyword at all. Rename the trait trait to _trait, and do the same dance in __init__ as before to accept trait as a keyword and assign the corresponding object to the _trait trait. This lets us use the existing more natural signature when creating a _TraitsChangeCollector object, and avoids the need to update other packages that are importing this object.

The downside is that now if you want to dig the trait out of the collector, you need to access it through _trait. But that doesn't seem like something that would be needed to me.

corranwebster · 2017-04-07T10:56:19Z

 import unittest2 as unittest
 else:
- import unittest
+ import unittest # noqa


Since we're messing with this anyway, can we drop the unittest2 import as 2.6 is no longer supported.

corranwebster · 2017-04-07T11:01:00Z


+ def __init__(self, **traits):
+ value = traits.pop('trait', None)
+ if value is not None:


I think if 'trait' in traits: is better here with a traits['monitor_trait'] = traits.pop('trait') below.
Less confusing if initialized with trait=None (which will slip through undetected as an error).

corranwebster · 2017-04-07T11:03:07Z

I agree about the name monitor_trait. I think trait_name is preferable to the option of using _trait.

stefanoborini · 2017-05-26T12:07:29Z

@corranwebster can this be merged?

corranwebster

LGTM

mdickinson

LGTM2

itziakos · 2017-01-13T09:07:36Z

This PR renames the trait attribute of _TraitsChangeCollector to fix#342. There is no change at the constructor signature but I add a deprecation warning that prompts users to stop using trait

mdickinson · 2017-01-26T09:24:57Z

Given that this is a private class, it's tempting not to bother with the DeprecationWarning.

OTOH, apparently this class is directly imported in traits_enaml and pyface. :-(

mdickinson · 2017-01-26T09:33:56Z

We should probably make this class public at some point.

LGTM. I'm not a big fan of the name monitor_traits. What do you think of using trait_name instead?

mdickinson · 2017-01-26T09:48:53Z

Another possibility, which I think I prefer to this one: don't deprecate use of the trait keyword at all. Rename the trait trait to _trait, and do the same dance in __init__ as before to accept trait as a keyword and assign the corresponding object to the _trait trait. This lets us use the existing more natural signature when creating a _TraitsChangeCollector object, and avoids the need to update other packages that are importing this object.

The downside is that now if you want to dig the trait out of the collector, you need to access it through _trait. But that doesn't seem like something that would be needed to me.

corranwebster · 2017-04-07T10:56:19Z

 import unittest2 as unittest
 else:
- import unittest
+ import unittest # noqa


Since we're messing with this anyway, can we drop the unittest2 import as 2.6 is no longer supported.

corranwebster · 2017-04-07T11:01:00Z


+ def __init__(self, **traits):
+ value = traits.pop('trait', None)
+ if value is not None:


I think if 'trait' in traits: is better here with a traits['monitor_trait'] = traits.pop('trait') below.
Less confusing if initialized with trait=None (which will slip through undetected as an error).

corranwebster · 2017-04-07T11:03:07Z

I agree about the name monitor_trait. I think trait_name is preferable to the option of using _trait.

stefanoborini · 2017-05-26T12:07:29Z

@corranwebster can this be merged?

corranwebster

LGTM

mdickinson

LGTM2

itziakos · 2017-01-13T09:07:36Z

This PR renames the trait attribute of _TraitsChangeCollector to fix#342. There is no change at the constructor signature but I add a deprecation warning that prompts users to stop using trait

mdickinson · 2017-01-26T09:24:57Z

Given that this is a private class, it's tempting not to bother with the DeprecationWarning.

OTOH, apparently this class is directly imported in traits_enaml and pyface. :-(

mdickinson · 2017-01-26T09:33:56Z

We should probably make this class public at some point.

LGTM. I'm not a big fan of the name monitor_traits. What do you think of using trait_name instead?

mdickinson · 2017-01-26T09:48:53Z

Another possibility, which I think I prefer to this one: don't deprecate use of the trait keyword at all. Rename the trait trait to _trait, and do the same dance in __init__ as before to accept trait as a keyword and assign the corresponding object to the _trait trait. This lets us use the existing more natural signature when creating a _TraitsChangeCollector object, and avoids the need to update other packages that are importing this object.

The downside is that now if you want to dig the trait out of the collector, you need to access it through _trait. But that doesn't seem like something that would be needed to me.

corranwebster · 2017-04-07T10:56:19Z

 import unittest2 as unittest
 else:
- import unittest
+ import unittest # noqa


Since we're messing with this anyway, can we drop the unittest2 import as 2.6 is no longer supported.

corranwebster · 2017-04-07T11:01:00Z


+ def __init__(self, **traits):
+ value = traits.pop('trait', None)
+ if value is not None:


I think if 'trait' in traits: is better here with a traits['monitor_trait'] = traits.pop('trait') below.
Less confusing if initialized with trait=None (which will slip through undetected as an error).

corranwebster · 2017-04-07T11:03:07Z

I agree about the name monitor_trait. I think trait_name is preferable to the option of using _trait.

stefanoborini · 2017-05-26T12:07:29Z

@corranwebster can this be merged?

corranwebster

LGTM

mdickinson

LGTM2

itziakos · 2017-01-13T09:07:36Z

This PR renames the trait attribute of _TraitsChangeCollector to fix#342. There is no change at the constructor signature but I add a deprecation warning that prompts users to stop using trait

mdickinson · 2017-01-26T09:24:57Z

Given that this is a private class, it's tempting not to bother with the DeprecationWarning.

OTOH, apparently this class is directly imported in traits_enaml and pyface. :-(

mdickinson · 2017-01-26T09:33:56Z

We should probably make this class public at some point.

LGTM. I'm not a big fan of the name monitor_traits. What do you think of using trait_name instead?

mdickinson · 2017-01-26T09:48:53Z

Another possibility, which I think I prefer to this one: don't deprecate use of the trait keyword at all. Rename the trait trait to _trait, and do the same dance in __init__ as before to accept trait as a keyword and assign the corresponding object to the _trait trait. This lets us use the existing more natural signature when creating a _TraitsChangeCollector object, and avoids the need to update other packages that are importing this object.

The downside is that now if you want to dig the trait out of the collector, you need to access it through _trait. But that doesn't seem like something that would be needed to me.

corranwebster · 2017-04-07T10:56:19Z

 import unittest2 as unittest
 else:
- import unittest
+ import unittest # noqa


Since we're messing with this anyway, can we drop the unittest2 import as 2.6 is no longer supported.

corranwebster · 2017-04-07T11:01:00Z


+ def __init__(self, **traits):
+ value = traits.pop('trait', None)
+ if value is not None:


I think if 'trait' in traits: is better here with a traits['monitor_trait'] = traits.pop('trait') below.
Less confusing if initialized with trait=None (which will slip through undetected as an error).

corranwebster · 2017-04-07T11:03:07Z

I agree about the name monitor_trait. I think trait_name is preferable to the option of using _trait.

stefanoborini · 2017-05-26T12:07:29Z

@corranwebster can this be merged?

corranwebster

LGTM

mdickinson

LGTM2

itziakos · 2017-01-13T09:07:36Z

This PR renames the trait attribute of _TraitsChangeCollector to fix#342. There is no change at the constructor signature but I add a deprecation warning that prompts users to stop using trait

mdickinson · 2017-01-26T09:24:57Z

Given that this is a private class, it's tempting not to bother with the DeprecationWarning.

OTOH, apparently this class is directly imported in traits_enaml and pyface. :-(

mdickinson · 2017-01-26T09:33:56Z

We should probably make this class public at some point.

LGTM. I'm not a big fan of the name monitor_traits. What do you think of using trait_name instead?

mdickinson · 2017-01-26T09:48:53Z

Another possibility, which I think I prefer to this one: don't deprecate use of the trait keyword at all. Rename the trait trait to _trait, and do the same dance in __init__ as before to accept trait as a keyword and assign the corresponding object to the _trait trait. This lets us use the existing more natural signature when creating a _TraitsChangeCollector object, and avoids the need to update other packages that are importing this object.

The downside is that now if you want to dig the trait out of the collector, you need to access it through _trait. But that doesn't seem like something that would be needed to me.

corranwebster · 2017-04-07T10:56:19Z

 import unittest2 as unittest
 else:
- import unittest
+ import unittest # noqa


Since we're messing with this anyway, can we drop the unittest2 import as 2.6 is no longer supported.

corranwebster · 2017-04-07T11:01:00Z


+ def __init__(self, **traits):
+ value = traits.pop('trait', None)
+ if value is not None:


I think if 'trait' in traits: is better here with a traits['monitor_trait'] = traits.pop('trait') below.
Less confusing if initialized with trait=None (which will slip through undetected as an error).

corranwebster · 2017-04-07T11:03:07Z

I agree about the name monitor_trait. I think trait_name is preferable to the option of using _trait.

stefanoborini · 2017-05-26T12:07:29Z

@corranwebster can this be merged?

corranwebster

LGTM

mdickinson

LGTM2

itziakos · 2017-01-13T09:07:36Z

This PR renames the trait attribute of _TraitsChangeCollector to fix#342. There is no change at the constructor signature but I add a deprecation warning that prompts users to stop using trait

mdickinson · 2017-01-26T09:24:57Z

Given that this is a private class, it's tempting not to bother with the DeprecationWarning.

OTOH, apparently this class is directly imported in traits_enaml and pyface. :-(

mdickinson · 2017-01-26T09:33:56Z

We should probably make this class public at some point.

LGTM. I'm not a big fan of the name monitor_traits. What do you think of using trait_name instead?

mdickinson · 2017-01-26T09:48:53Z

Another possibility, which I think I prefer to this one: don't deprecate use of the trait keyword at all. Rename the trait trait to _trait, and do the same dance in __init__ as before to accept trait as a keyword and assign the corresponding object to the _trait trait. This lets us use the existing more natural signature when creating a _TraitsChangeCollector object, and avoids the need to update other packages that are importing this object.

The downside is that now if you want to dig the trait out of the collector, you need to access it through _trait. But that doesn't seem like something that would be needed to me.

corranwebster · 2017-04-07T10:56:19Z

 import unittest2 as unittest
 else:
- import unittest
+ import unittest # noqa


Since we're messing with this anyway, can we drop the unittest2 import as 2.6 is no longer supported.

corranwebster · 2017-04-07T11:01:00Z


+ def __init__(self, **traits):
+ value = traits.pop('trait', None)
+ if value is not None:


I think if 'trait' in traits: is better here with a traits['monitor_trait'] = traits.pop('trait') below.
Less confusing if initialized with trait=None (which will slip through undetected as an error).

corranwebster · 2017-04-07T11:03:07Z

I agree about the name monitor_trait. I think trait_name is preferable to the option of using _trait.

stefanoborini · 2017-05-26T12:07:29Z

@corranwebster can this be merged?

corranwebster

LGTM

mdickinson

LGTM2

itziakosand others added 4 commits January 13, 2017 09:01

rename trait -> monitor_traits
083e33a

use the right trait name
fd99d77

fix sysntax error
b407c44

Merge remote-tracking branch 'origin/master' into fix-issue-342
6746299

itziakos requested review from corranwebster and mdickinson January 25, 2017 17:10

corranwebster reviewed Apr 7, 2017
View reviewed changes

itziakos added 4 commits August 14, 2017 22:05

remove unittest2 check
c0771e4

Update unittest_tools.py
b1ab06d

add missing import back
35fa89b

rename monitor_traits -> trait_name
c29abc4

itziakos requested a review from corranwebster February 26, 2018 14:04

corranwebster approved these changes Jul 13, 2018
View reviewed changes

mdickinson merged commit 8ed38b4 into masterJul 13, 2018

mdickinson deleted the fix-issue-342 branch July 13, 2018 10:54

mdickinson reviewed Jul 13, 2018
View reviewed changes

jvkersch mentioned this pull request Nov 11, 2019
MAINT: Update deprecated attribute name. enthought/pyface#457
Merged

itziakosand others added 4 commits January 13, 2017 09:01

rename trait -> monitor_traits
083e33a

use the right trait name
fd99d77

fix sysntax error
b407c44

Merge remote-tracking branch 'origin/master' into fix-issue-342
6746299

itziakos requested review from corranwebster and mdickinson January 25, 2017 17:10

corranwebster reviewed Apr 7, 2017
View reviewed changes

itziakos added 4 commits August 14, 2017 22:05

remove unittest2 check
c0771e4

Update unittest_tools.py
b1ab06d

add missing import back
35fa89b

rename monitor_traits -> trait_name
c29abc4

itziakos requested a review from corranwebster February 26, 2018 14:04

corranwebster approved these changes Jul 13, 2018
View reviewed changes

mdickinson merged commit 8ed38b4 into masterJul 13, 2018

mdickinson deleted the fix-issue-342 branch July 13, 2018 10:54

mdickinson reviewed Jul 13, 2018
View reviewed changes

jvkersch mentioned this pull request Nov 11, 2019
MAINT: Update deprecated attribute name. enthought/pyface#457
Merged

itziakosand others added 4 commits January 13, 2017 09:01

rename trait -> monitor_traits
083e33a

use the right trait name
fd99d77

fix sysntax error
b407c44

Merge remote-tracking branch 'origin/master' into fix-issue-342
6746299

itziakos requested review from corranwebster and mdickinson January 25, 2017 17:10

corranwebster reviewed Apr 7, 2017
View reviewed changes

itziakos added 4 commits August 14, 2017 22:05

remove unittest2 check
c0771e4

Update unittest_tools.py
b1ab06d

add missing import back
35fa89b

rename monitor_traits -> trait_name
c29abc4

itziakos requested a review from corranwebster February 26, 2018 14:04

corranwebster approved these changes Jul 13, 2018
View reviewed changes

mdickinson merged commit 8ed38b4 into masterJul 13, 2018

mdickinson deleted the fix-issue-342 branch July 13, 2018 10:54

mdickinson reviewed Jul 13, 2018
View reviewed changes

jvkersch mentioned this pull request Nov 11, 2019
MAINT: Update deprecated attribute name. enthought/pyface#457
Merged

itziakosand others added 4 commits January 13, 2017 09:01

rename trait -> monitor_traits
083e33a

use the right trait name
fd99d77

fix sysntax error
b407c44

Merge remote-tracking branch 'origin/master' into fix-issue-342
6746299

itziakos requested review from corranwebster and mdickinson January 25, 2017 17:10

corranwebster reviewed Apr 7, 2017
View reviewed changes

itziakos added 4 commits August 14, 2017 22:05

remove unittest2 check
c0771e4

Update unittest_tools.py
b1ab06d

add missing import back
35fa89b

rename monitor_traits -> trait_name
c29abc4

itziakos requested a review from corranwebster February 26, 2018 14:04

corranwebster approved these changes Jul 13, 2018
View reviewed changes

mdickinson merged commit 8ed38b4 into masterJul 13, 2018

mdickinson deleted the fix-issue-342 branch July 13, 2018 10:54

mdickinson reviewed Jul 13, 2018
View reviewed changes

jvkersch mentioned this pull request Nov 11, 2019
MAINT: Update deprecated attribute name. enthought/pyface#457
Merged

itziakosand others added 4 commits January 13, 2017 09:01

rename trait -> monitor_traits
083e33a

use the right trait name
fd99d77

fix sysntax error
b407c44

Merge remote-tracking branch 'origin/master' into fix-issue-342
6746299

itziakos requested review from corranwebster and mdickinson January 25, 2017 17:10

corranwebster reviewed Apr 7, 2017
View reviewed changes

itziakos added 4 commits August 14, 2017 22:05

remove unittest2 check
c0771e4

Update unittest_tools.py
b1ab06d

add missing import back
35fa89b

rename monitor_traits -> trait_name
c29abc4

itziakos requested a review from corranwebster February 26, 2018 14:04

corranwebster approved these changes Jul 13, 2018
View reviewed changes

mdickinson merged commit 8ed38b4 into masterJul 13, 2018

mdickinson deleted the fix-issue-342 branch July 13, 2018 10:54

mdickinson reviewed Jul 13, 2018
View reviewed changes

jvkersch mentioned this pull request Nov 11, 2019
MAINT: Update deprecated attribute name. enthought/pyface#457
Merged

itziakosand others added 4 commits January 13, 2017 09:01

rename trait -> monitor_traits
083e33a

use the right trait name
fd99d77

fix sysntax error
b407c44

Merge remote-tracking branch 'origin/master' into fix-issue-342
6746299

itziakos requested review from corranwebster and mdickinson January 25, 2017 17:10

corranwebster reviewed Apr 7, 2017
View reviewed changes

itziakos added 4 commits August 14, 2017 22:05

remove unittest2 check
c0771e4

Update unittest_tools.py
b1ab06d

add missing import back
35fa89b

rename monitor_traits -> trait_name
c29abc4

itziakos requested a review from corranwebster February 26, 2018 14:04

corranwebster approved these changes Jul 13, 2018
View reviewed changes

mdickinson merged commit 8ed38b4 into masterJul 13, 2018

mdickinson deleted the fix-issue-342 branch July 13, 2018 10:54

mdickinson reviewed Jul 13, 2018
View reviewed changes

jvkersch mentioned this pull request Nov 11, 2019
MAINT: Update deprecated attribute name. enthought/pyface#457
Merged

itziakosand others added 4 commits January 13, 2017 09:01

rename trait -> monitor_traits
083e33a

use the right trait name
fd99d77

fix sysntax error
b407c44

Merge remote-tracking branch 'origin/master' into fix-issue-342
6746299

itziakos requested review from corranwebster and mdickinson January 25, 2017 17:10

corranwebster reviewed Apr 7, 2017
View reviewed changes

itziakos added 4 commits August 14, 2017 22:05

remove unittest2 check
c0771e4

Update unittest_tools.py
b1ab06d

add missing import back
35fa89b

rename monitor_traits -> trait_name
c29abc4

itziakos requested a review from corranwebster February 26, 2018 14:04

corranwebster approved these changes Jul 13, 2018
View reviewed changes

mdickinson merged commit 8ed38b4 into masterJul 13, 2018

mdickinson deleted the fix-issue-342 branch July 13, 2018 10:54

mdickinson reviewed Jul 13, 2018
View reviewed changes

jvkersch mentioned this pull request Nov 11, 2019
MAINT: Update deprecated attribute name. enthought/pyface#457
Merged

itziakosand others added 4 commits January 13, 2017 09:01

rename trait -> monitor_traits
083e33a

use the right trait name
fd99d77

fix sysntax error
b407c44

Merge remote-tracking branch 'origin/master' into fix-issue-342
6746299

itziakos requested review from corranwebster and mdickinson January 25, 2017 17:10

corranwebster reviewed Apr 7, 2017
View reviewed changes

itziakos added 4 commits August 14, 2017 22:05

remove unittest2 check
c0771e4

Update unittest_tools.py
b1ab06d

add missing import back
35fa89b

rename monitor_traits -> trait_name
c29abc4

itziakos requested a review from corranwebster February 26, 2018 14:04

corranwebster approved these changes Jul 13, 2018
View reviewed changes

mdickinson merged commit 8ed38b4 into masterJul 13, 2018

mdickinson deleted the fix-issue-342 branch July 13, 2018 10:54

mdickinson reviewed Jul 13, 2018
View reviewed changes

jvkersch mentioned this pull request Nov 11, 2019
MAINT: Update deprecated attribute name. enthought/pyface#457
Merged

Uh oh!

Conversation

itziakos commented Jan 13, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdickinson commented Jan 26, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdickinson commented Jan 26, 2017

Uh oh!

mdickinson commented Jan 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

corranwebster commented Apr 7, 2017

Uh oh!

stefanoborini commented May 26, 2017

Uh oh!

corranwebster left a comment

Choose a reason for hiding this comment

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

itziakos commented Jan 13, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdickinson commented Jan 26, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdickinson commented Jan 26, 2017

Uh oh!

mdickinson commented Jan 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

corranwebster commented Apr 7, 2017

Uh oh!

stefanoborini commented May 26, 2017

Uh oh!

corranwebster left a comment

Choose a reason for hiding this comment

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

itziakos commented Jan 13, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

itziakos commented Jan 13, 2017•
edited
Loading

mdickinson commented Jan 26, 2017•
edited
Loading

itziakos commented Jan 13, 2017•
edited
Loading

mdickinson commented Jan 26, 2017•
edited
Loading

itziakos commented Jan 13, 2017•
edited
Loading

mdickinson commented Jan 26, 2017•
edited
Loading

itziakos commented Jan 13, 2017•
edited
Loading

mdickinson commented Jan 26, 2017•
edited
Loading