Skip to content

Make automatic variable imports in EquationWriter optional. - #101

Open
schymans wants to merge 5 commits into
environmentalscience:masterfrom
schymans:eqwriter
Open

Make automatic variable imports in EquationWriter optional.#101
schymans wants to merge 5 commits into
environmentalscience:masterfrom
schymans:eqwriter

Conversation

@schymans

@schymansschymans commented Jun 18, 2021

Copy link
Copy Markdown
Collaborator

This enables deactivating automatic inclusion of variable imports by EquationWriter. The default is still to include all variables, but it can be deactivated by passing autovars=0 to EquationWriter.eq and EquationWriter.neweq.

Closes#100.

@schymans
schymans requested a review from jirikuncarJune 18, 2021 10:18
Comment threadessm/_generator.py Outdated
jirikuncar
jirikuncar previously approved these changes Jul 6, 2021
@schymans

schymans commented Jul 7, 2021

Copy link
Copy Markdown
CollaboratorAuthor

For some reason, sphinx fails in the travis-ci:

Exception occurred:
File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/nbsphinx.py", line 1813, in apply
env.get_domain('math').data['has_equations'][env.docname] = True
KeyError: 'has_equations'
The full traceback has been saved in /tmp/sphinx-err-vakrs_zm.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
The command "python setup.py build_sphinx" exited with 1.

This does not happen locally for me. Any idea what might be wrong?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EquationWriter includes imports of variables, but this can lead to error

2 participants

@schymans@jirikuncar