Skip to content

cache: unsubscribe removed resources on reconnects - #320

Open
sschepens wants to merge 1 commit into
envoyproxy:mainfrom
sschepens:fix-pending-resource-removal
Open

cache: unsubscribe removed resources on reconnects#320
sschepens wants to merge 1 commit into
envoyproxy:mainfrom
sschepens:fix-pending-resource-removal

Conversation

@sschepens

Copy link
Copy Markdown
Contributor

When reconnections occur, envoy sends a new request subscribing to all the resources it currently had.
If a resource has just been removed, we fail to notify Envoy the the resource has been removed.

This happens because on the very first stream request, we dont have any trackedResources, we should instead also check pendingResources.

Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
@sschepens
sschepensforce-pushed the fix-pending-resource-removal branch from a8b3df6 to 154e449CompareJanuary 24, 2024 15:10
@codecov-commenter

codecov-commenter commented Jan 24, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.24%. Comparing base (4577722) to head (154e449).
⚠️ Report is 94 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #320 +/- ##
============================================
+ Coverage 86.16% 86.24% +0.08% - Complexity 361 363 +2 
============================================
Files 42 42 Lines 1178 1178 Branches 97 97 ============================================
+ Hits 1015 1016 +1 + Misses 116 115 -1 
Partials 47 47 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sschepenssschepens changed the title fix: Ensure we unsubscribe removed resources on reconnectscache: Ensure we unsubscribe removed resources on reconnectsJan 24, 2024
@sschepenssschepens changed the title cache: Ensure we unsubscribe removed resources on reconnectscache: ensure we unsubscribe removed resources on reconnectsJan 24, 2024
@sschepenssschepens changed the title cache: ensure we unsubscribe removed resources on reconnectscache: unsubscribe removed resources on reconnectsJan 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sschepens@codecov-commenter