Skip to content

1.38 fixed - #504

Draft
ovadiagal wants to merge 1 commit into
envoyproxy:mainfrom
ovadiagal:go/version-1.38-fixed
Draft

1.38 fixed#504
ovadiagal wants to merge 1 commit into
envoyproxy:mainfrom
ovadiagal:go/version-1.38-fixed

Conversation

@ovadiagal

@ovadiagalovadiagal commented May 4, 2026

Copy link
Copy Markdown
Contributor

Fix publishing for Envoy version 1.38.0

Comment threadtools/update-sha.sh
Comment on lines 27 to 30

CURL_OUTPUT=$(curl -s "https://raw.githubusercontent.com/envoyproxy/envoy/$ENVOY_VERSION/api/bazel/repository_locations.bzl")
LOCATIONS=$(curl -s "https://raw.githubusercontent.com/envoyproxy/envoy/$ENVOY_VERSION/api/bazel/repository_locations.bzl")
DEPS_YAML=$(curl -s "https://raw.githubusercontent.com/envoyproxy/envoy/$ENVOY_VERSION/api/bazel/deps.yaml")

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of envoyproxy/envoy#43048, dependency metadata (release_date, project_name, etc.) was moved out of repository_locations.bzl into a separate deps.yaml file. Versions and SHAs remain in repository_locations.bzl.

Comment threadtools/update-sha.sh
Comment on lines 16 to +17
local DEPENDENCY=$2
echo "$CONTENT" | grep "$DEPENDENCY" -A 11 | grep -m 1 "release_date =" | awk '{ print $3 }' | tr -d '"' | tr -d ","
echo "$CONTENT" | grep "$DEPENDENCY" -A 5 | grep -m 1 "release_date:" | awk '{ print $2 }' | tr -d '"'

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted to account for the new format of deps.yaml

@AntonKanug

Copy link
Copy Markdown
Contributor

@ovadiagal did you get a chance to test this

Govadia/my publishing
Signed-off-by: Gal Ovadia <ggalovadia@gmail.com>
@ovadiagal
ovadiagalforce-pushed the go/version-1.38-fixed branch from 5fc3432 to 340f137CompareJune 1, 2026 16:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ovadiagal@AntonKanug