Skip to content

fix: windows build - #24

Merged
jerzyjamroz merged 3 commits into
epics-modules:masterfrom
jerzyjamroz:appveyor
Sep 1, 2025
Merged

fix: windows build#24
jerzyjamroz merged 3 commits into
epics-modules:masterfrom
jerzyjamroz:appveyor

Conversation

@jerzyjamroz

@jerzyjamrozjerzyjamroz commented Aug 27, 2025

Copy link
Copy Markdown
Contributor
  • add windows-x64-mingw cross-compilation
  • add windows build
  • remove '.appveyor.yml'

@jerzyjamrozjerzyjamroz self-assigned this Aug 27, 2025
@jerzyjamrozjerzyjamroz mentioned this pull request Aug 27, 2025
@jerzyjamrozjerzyjamroz linked an issue Aug 28, 2025 that may be closed by this pull request

@anjohnsonanjohnson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHA does have Windows runners that you could test on too (see the epics-base job configuration for how), and they don't fail randomly in the same way that Appveyor jobs do. I'm not saying you need to add them though, I don't know if devLib2 is used on Windows at all, I didn't write this code.

The cross-build addition is probably a good thing to do, if only to prove that some Linux-specific code isn't hiding inside.

@mdavidsaver

Copy link
Copy Markdown
Collaborator

I don't know if devLib2 is used on Windows at all

It was at some point. At PSI as I recall. Which is why Dirk did #11. The matching Windows kernel driver source was (I think) never published, and would in any even need to be signed by M$ to use.

@dirk-zimoch Do you know if there is still any use of devlib2 on Windows at PSI?

@jerzyjamroz

jerzyjamroz commented Aug 29, 2025

Copy link
Copy Markdown
ContributorAuthor

@mdavidsaver , it works fine for windows-latest. If all ok, I will merge it next week.

@jerzyjamroz
jerzyjamroz merged commit a92ee42 into epics-modules:masterSep 1, 2025
32 of 34 checks passed
@jerzyjamroz
jerzyjamroz deleted the appveyor branch September 1, 2025 07:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.ci needs update

3 participants

@jerzyjamroz@mdavidsaver@anjohnson