Minor updates - #38
Merged
Merged
Conversation
…ources and just getting all resources that had a coverage from the world.
…if the global is None.
stickler-ci
reviewed
Apr 12, 2018
|
|
||
| providers = {name: driver.DriverManager('quest.services', name, invoke_on_load=True, invoke_kwds={'name': name}).driver for name in web_services} | ||
| if update_cache or the_providers is None: | ||
| providers = {name: driver.DriverManager('quest.services', name, invoke_on_load=True, invoke_kwds={'name': name}).driver for name in web_services} |
There was a problem hiding this comment.
E501 line too long (153 > 120 characters)
| if len(settings.get('USER_SERVICES', [])) > 0: | ||
| for uri in settings.get('USER_SERVICES', []): | ||
| try: | ||
| drv = driver.DriverManager('quest.services', 'user', invoke_on_load=True, invoke_kwds={'uri': uri}).driver |
There was a problem hiding this comment.
E501 line too long (126 > 120 characters)
sdc50
approved these changes
Apr 16, 2018
sdc50
pushed a commit
that referenced
this pull request
Apr 18, 2018
* I got the basic authentication piece setup for the nasa provider. * Made a small fix to the authentication fix. This provider is working again. * Nasa provider syntax fix. * Minor updates (#38) * Added the cuahsi coverage fix. The change was not getting all the resources and just getting all resources that had a coverage from the world. * Made kwargs the standard over using options, params, and kwargs. * Updated the load_providers to only update if update-cache is True or if the global is None. * I got the basic authentication piece setup for the nasa provider. * Made a small fix to the authentication fix. This provider is working again. * Nasa provider syntax fix. * I never added the uncommented the nasa download options to the tests in data.py. This fixes the tests.
sdc50
pushed a commit
that referenced
this pull request
Apr 27, 2018
* Dataset display name fix (More readable). * Added the noaa_ncep plugin and updated the conda environment file. * NCEP test and setup.cfg were updated. * Removing the placeholder for the girder site. * Updated the docs and the python 2 environment file for ncep and terrapin. * Minor updates (#38) * Added the cuahsi coverage fix. The change was not getting all the resources and just getting all resources that had a coverage from the world. * Made kwargs the standard over using options, params, and kwargs. * Updated the load_providers to only update if update-cache is True or if the global is None. * Dataset display name fix (More readable). * Added the noaa_ncep plugin and updated the conda environment file. * NCEP test and setup.cfg were updated. * Removing the placeholder for the girder site. * Updated the docs and the python 2 environment file for ncep and terrapin. * The setup.cfg never got updated or added to this commit. This fixes the tests. * Addeed another service from ncep, and added the sorted call to the lists. * Fixed the test and added the sorted functions into this plugin. * Nasa Provider Plugin (#40) * I got the basic authentication piece setup for the nasa provider. * Made a small fix to the authentication fix. This provider is working again. * Nasa provider syntax fix. * Minor updates (#38) * Added the cuahsi coverage fix. The change was not getting all the resources and just getting all resources that had a coverage from the world. * Made kwargs the standard over using options, params, and kwargs. * Updated the load_providers to only update if update-cache is True or if the global is None. * I got the basic authentication piece setup for the nasa provider. * Made a small fix to the authentication fix. This provider is working again. * Nasa provider syntax fix. * I never added the uncommented the nasa download options to the tests in data.py. This fixes the tests. * Dataset display name fix (More readable). * Added the noaa_ncep plugin and updated the conda environment file. * NCEP test and setup.cfg were updated. * Removing the placeholder for the girder site. * Updated the docs and the python 2 environment file for ncep and terrapin. * Dataset display name fix (More readable). * Removing the placeholder for the girder site. * The setup.cfg never got updated or added to this commit. This fixes the tests. * Addeed another service from ncep, and added the sorted call to the lists. * Fixed the test and added the sorted functions into this plugin. * Fixed the test for ncep provider. * Fixed the test for ncep provider part 2. * Updated the authentication to work with QuestWeb, and added a method for getting the status of a providers authentication. (#41) * Dataset display name fix (More readable). * Added the noaa_ncep plugin and updated the conda environment file. * NCEP test and setup.cfg were updated. * Removing the placeholder for the girder site. * Updated the docs and the python 2 environment file for ncep and terrapin. * Dataset display name fix (More readable). * Removing the placeholder for the girder site. * The setup.cfg never got updated or added to this commit. This fixes the tests. * Addeed another service from ncep, and added the sorted call to the lists. * Fixed the test and added the sorted functions into this plugin. * Dataset display name fix (More readable). * Removing the placeholder for the girder site. * Removing the placeholder for the girder site. * Fixed the test for ncep provider. * Fixed the test for ncep provider part 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three minor updates to Quest in this pull request and they are as follows:
Created a standard that the service, provider, publishers will all use kwargs, rather than options, params, and kwargs. This will be helpful for future documentation.
I updated the HydroShare provider plugin ( geo service base ) so that it was not pulling all resources down from HydroShare. Now we do a search for any resources that are in a particular bbox, rather than grab all the resources from HS and parse through them all looking for ones that have a coverage.
Lastly, I updated how load_providers() works. I didn't like that every time you made a load_providers() call that it keep instantiating all plugins and wasting time. So made a caching system with a global variable and only updated the providers when one is added or deleted.