build(sdk): move to imogen-sdk v0.4.0 (#9) - #13
Merged
Conversation
v0.4.0 lets a pairing claim name the RFC 8707 resource its token is for. This client never calls pair(), so the Rust signature change does not reach it and the move is the pointer plus the crate version Cargo.lock records. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#9
Summary
imogen-sdksubmodule fromv0.3.0tov0.4.0, which lets a pairing claim name the RFC 8707resourceits token is for.Cargo.lockmoves with it: the SDK crate version is what the lockfile records, and CI runs--locked.About the issue
The issue body describes the v0.3.0 change (
begin_authorizationgaining a fourth argument). That landed already, in #11 / v0.2.1 —src/auth.rs:142has passedNonesince then. What is left, and what this PR does, is the pointer move to v0.4.0.v0.4.0's own signature change is to
OAuthClient::pair(), which gained a requiredresourceargument. This client has no pairing flow —pairdoes not appear anywhere insrc/— so nothing here needed changing. The bind-or-not decision the issue raises for the browser flow is untouched: this client stays unbound (None), and a token it mints is still accepted at every surface.Test plan
cargo test --locked— 103 passedcargo fmt --checkcargo clippy --all-targets --locked -- -D warningscargo build --release --locked🤖 Generated with Claude Code