Release v0.2.0 with nested reference traversal - #2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9e846a74f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (member is IEnumerable enumerable && ShouldVisitEnumerable(enumerable)) | ||
| { | ||
| VisitEnumerable(enumerable, cursor); | ||
| return; |
There was a problem hiding this comment.
When an ISyncList, ISyncBag, ISyncDictionary, or ISyncArray implementation also implements IEnumerable, this return prevents TryVisitKnownCollections from reading Elements, Values, BoxedEntries, or GetElement. This silently misses references when the generic enumerable view omits or wraps nested members—for example, a dictionary enumerating key/value pairs whose values are collection members rather than direct ISyncRef instances—whereas the previous implementation still ran the specialized traversal after generic enumeration.
Useful? React with 👍 / 👎.
Publishes the maintained local fixes for resolving reference spaces by variable name and traversing nested sync lists and dictionaries, updates the current Resonite and .NET 10 CI path, and documents the expanded scope. Local format and Release build pass with all 9 tests, and the old Slot.Children ABI reference is absent.