Skip to content

attempt to fix cors issues on UI - #83

Open
naps62 wants to merge 4 commits into
mainfrom
cors
Open

attempt to fix cors issues on UI#83
naps62 wants to merge 4 commits into
mainfrom
cors

Conversation

@naps62

Copy link
Copy Markdown
Member

@ZePedroResende while the UI is working, there are some CORS errors in the inspector

I believe this is the fix

CopilotAI review requested due to automatic review settings February 3, 2026 15:45
@naps62naps62 added the bug Something isn't working label Feb 3, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix CORS issues in the UI by expanding the CORSPlug configuration in the Phoenix endpoint. The changes add credentials support, cache control via max_age, and an extensive list of allowed headers to the existing wildcard origin configuration.

Changes:

  • Enhanced CORSPlug configuration with credentials support, max-age caching, and explicit header allowlist

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadserver/lib/ethui_web/endpoint.ex
Comment threadserver/lib/ethui_web/endpoint.ex Outdated
@vercel

vercelBot commented Feb 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
stacksReadyReadyPreview, CommentFeb 4, 2026 11:48am

Request Review

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@naps62@ZePedroResende