Banned IP entry into an error log

[RobertFojtikAEN]

Is there any issue to write banned IP entry to an error log ?

Something like that:

if ((((static_cast<webserver*>(cls))->default_policy == http_utils::ACCEPT) &&
 ((static_cast<webserver*>(cls))->bans.count(ip_representation(addr))) &&
 (!(static_cast<webserver*>(cls))->allowances.count(ip_representation(addr)))) ||
 (((static_cast<webserver*>(cls))->default_policy == http_utils::REJECT) &&
 ((!(static_cast<webserver*>(cls))->allowances.count(ip_representation(addr))) ||
 ((static_cast<webserver*>(cls))->bans.count(ip_representation(addr)))))) {
 
 //log banned IP
 std::string msg = "IP '" + httpserver::http::get_ip_str(addr) + "' rejected\n";
 webserver* dws = static_cast<webserver*>(cls);
 dws->log_error(msg);

 return MHD_NO;
}

[etr]

Resolved in libhttpserver 2.0.0. The new lifecycle-hook system lets you observe connection accept/deny decisions and log denied IPs without patching the library. There's a ready-made example at examples/denied_ip_log.cpp, and the hooks are documented in the README's Lifecycle Hooks section.

Closing as resolved by 2.0.0.