Uh oh!
There was an error while loading. Please reload this page.
chore(deps): bump ava to 8.0.1 and oxlint to 1.79.0 in bashkit-js - #2339
Merged
Conversation
ava 8 drops the object form of the `extensions` config and requires Node 22.20+. Convert `extensions` to the array form and gate the two ava-hosted CI steps to Node 22+. Node 20 stays in the JS matrix: the package still declares `engines: node >= 18`, and the runtime-compat tests plus the examples continue to exercise the shipped binding there. Only the dev-time test runner moves forward. Supersedes the grouped Dependabot PR, which could not apply the breaking-change fixups on its own.
ava 8 loads every test file through import(). The random-fs fixture directory has its own package.json without "type": "module", so the spec resolved as CommonJS and ava's ESM-only worker failed to initialise. Rename it to .spec.mts, which is ESM regardless of the nearest package.json, and leave the napi-generated CommonJS index.js alone — the spec already reaches it through createRequire. Track the new extension in the ava config and the type-check include.
Deploying with |
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs | bashkit | c6db339 | Commit Preview URL Branch Preview URL | Aug 22 2026, 12:43 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Takes the grouped
js-npmDependabot update (ava6.4.1 → 8.0.1,oxlint1.78.0 → 1.79.0) and adds the fixups the bot could not make on its own.ava.extensionsmoves from the object form to the array form — ava 8 removed the object form.pnpm test,pnpm run test:interop) now run on Node 22+ only. ava 8 requires Node 22.20+.interop.spec.mtsso it loads as ESM.No runtime or published-package change:
avaandoxlintare both devDependencies.Why
Dependabot opened #2322 for this group, but the
avabump is a breaking major and the PR fails CI as-is:Two further breakages surface only after that one is fixed:
node 20matrix job cannot run it at all.import().test-fixtures/random-fs/has its ownpackage.jsonwith no"type": "module", sointerop.spec.tsresolved as CommonJS and ava's now ESM-only worker failed to initialise:Renaming to
.mtsmakes the file ESM regardless of the nearestpackage.json, and leaves the napi-generated CommonJSindex.jsalone — the spec already reaches it throughcreateRequire.Node 20 stays in the JS matrix. The package still declares
engines: node >= 18, and node 20 continues to run the runtime-compat tests and all six examples, which exercise the shipped binding. Only the dev-time test runner moves forward.Before / After
Before (Dependabot #2322, node 20/22/24/latest all red):
After, on Node 22.22.2:
pnpm install --frozen-lockfileapplies thesupertap@3.0.1patch unchanged — ava 8 still resolves that exact version.Risk
tsconfig.check.jsonnow globstest-fixtures/**/*.spec.mts; verified withtsc --listFilesthat the renamed spec is still type-checked.Checklist
Closes#2322.
Generated by Claude Code