Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Nov 14, 2023. It is now read-only.
Clean up repo - #5
Merged
Merged
Conversation
Deleted user (ghost)
approved these changes
Oct 19, 2023
Deleted user (ghost)
commented
Oct 19, 2023
If we are going to maintain our own fork of this might be worth removing all the deprecated code also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo is a mess
How
Run cargo fmt, upgrade the rust edition and run clippy
Also remove FFI and lua support from the repo since there's an open issue about these being vulnerable in the repo we forked this from.