Skip to content

fix: respect LOG_URLS=false to disable request URL logging - #134

Merged
mms-gianni merged 3 commits into
everywall:release/v0.0.24from
aayushprsingh:fix/log-urls-env
May 9, 2026
Merged

mms-gianni merged 3 commits into
everywall:release/v0.0.24from
aayushprsingh:fix/log-urls-env

Conversation

@aayushprsingh

Copy link
Copy Markdown

Summary

Fixes LOG_URLS=false not disabling request URL logging.

Problem: The logging middleware in cmd/main.go only checked NOLOGS=true to suppress logs. Setting LOG_URLS=false (as the user in #78 attempted) was completely ignored — all request paths (GET /https://...) were still logged.

Root cause: The middleware condition in cmd/main.go was:

if os.Getenv("NOLOGS") != "true" {

This meant only NOLOGS=true could disable logging. LOG_URLS was only checked later in handlers/proxy.go for verbose modified-URL logging.

Fix: Added && os.Getenv("LOG_URLS") != "false" to the condition:

if os.Getenv("NOLOGS") != "true" && os.Getenv("LOG_URLS") != "false" {

Behaviour:

LOG_URLS NOLOGS Result
unset not "true" URLs logged (backward compatible default)
true not "true" URLs logged + verbose modified-URL logs
false * No URL logging

Fixes #78

dependabot Bot and others added 3 commits April 24, 2026 22:16
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 6.
- [Release notes](https://github.com/docker/metadata-action/releases)
- [Commits](docker/metadata-action@v4...v6)

---
updated-dependencies:
- dependency-name: docker/metadata-action
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…ions/dot-github/workflows/docker/metadata-action-6

Bump docker/metadata-action from 4 to 6 in /.github/workflows
When LOG_URLS=false is set, request URL paths (e.g. GET /https://...)
are no longer logged. Previously only NOLOGS=true was checked,
making LOG_URLS ineffective for suppressing request logs.

Fixes everywall#78

@mms-gianni mms-gianni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

THX

@mms-gianni mms-gianni added this to the v0.0.24 milestone May 9, 2026
@aayushprsingh
aayushprsingh requested a review from mms-gianni May 9, 2026 17:06
@aayushprsingh

aayushprsingh commented May 9, 2026

Copy link
Copy Markdown
Author

@everywall this PR is approved and ready to merge, mind merging it?

@mms-gianni
mms-gianni changed the base branch from main to release/v0.0.24 May 9, 2026 22:24
@mms-gianni
mms-gianni merged commit 5359dc8 into everywall:release/v0.0.24 May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ENV "LOG_URLS" has stopped working

2 participants