fix: respect LOG_URLS=false to disable request URL logging - #134
Merged
mms-gianni merged 3 commits intoMay 9, 2026
Merged
Conversation
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 6. - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@v4...v6) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ions/dot-github/workflows/docker/metadata-action-6 Bump docker/metadata-action from 4 to 6 in /.github/workflows
When LOG_URLS=false is set, request URL paths (e.g. GET /https://...) are no longer logged. Previously only NOLOGS=true was checked, making LOG_URLS ineffective for suppressing request logs. Fixes everywall#78
Author
|
@everywall this PR is approved and ready to merge, mind merging it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
LOG_URLS=falsenot disabling request URL logging.Problem: The logging middleware in
cmd/main.goonly checkedNOLOGS=trueto suppress logs. SettingLOG_URLS=false(as the user in #78 attempted) was completely ignored — all request paths (GET /https://...) were still logged.Root cause: The middleware condition in
cmd/main.gowas:This meant only
NOLOGS=truecould disable logging.LOG_URLSwas only checked later inhandlers/proxy.gofor verbose modified-URL logging.Fix: Added
&& os.Getenv("LOG_URLS") != "false"to the condition:Behaviour:
LOG_URLSNOLOGStruefalseFixes #78