Fixed TreeNode and tests - #41

Merged
thosil merged 72 commits into
masterfrom
bugfix/fix_tests_and_treenode_to_json
Sep 11, 2020
Merged

Fixed TreeNode and tests#41
thosil merged 72 commits into
masterfrom
bugfix/fix_tests_and_treenode_to_json

Conversation

@thosil

@thosilthosil commented Sep 10, 2020

Copy link
Copy Markdown

  • TreeNode.js:
    fix toJSON() when there are no children

  • Ember.test.js:
    fix tests, cleaned up imports

Gilles Dufourand others added 30 commits December 9, 2019 11:41
Gilles Dufour
Added supported for Function on server side. Fixed invokationresult d…
9f8e9c8
…ecoding
Gilles Dufour
new documentation
ed2ff32
Gilles Dufour
new documentation
2638055
Gilles Dufour
Added all matrixConnect and Disconnect functions. Fixed all tests. Mo…
46297db
…dified the Doc.
@dufourgilles
Add description to label when converting json to tree
3b08081
@dufourgilles
Adding validation of connection request on server
dfbd5d1
@dufourgilles
fix contributors
22fa47c
@dufourgilles
fix contributors
5a830de
Gilles Dufour
Fixing getDirectory when root has more than 1 elements
876ed09
@dufourgilles
Added support for subscribe and unsubscribe of streams
42d351c
@dufourgilles
fixing matrix absolute connect
58bc2d8
@dufourgilles
Better error when doing getNodeByPath
fd31d8d
@dufourgilles
handle connection for 1-to-1 matrix
8859478
@dufourgilles
add maximumTotalConnects
4df675c
@dufourgilles
fix 1 to N matrix connect
2011b64
@dufourgilles
Fix 1toN. Disconnect old source and connect to new one
6d03d10
@dufourgilles
Server should emit disconnect when connecting target with new source
0283ce3
@dufourgilles
Update doc
a402f26
@dufourgilles
Do a disconnect if attempting to connect same src and target
b46b917
@dufourgilles
fix disconnect
61d9e01
@dufourgilles
handle connect with empty sources
c712676
@dufourgilles
added lock/unlock of connection
84d325c
@dufourgilles
added lock/unlock of connection
b00b1b3
@dufourgilles
Fix disconnect for 1toN
8b2109f
@dufourgilles
Fix function result missing
734c0ea
@dufourgilles
Added -1 for defaultSources to disable disconnect
341e887
@dufourgilles
fix disconnect when mismatch client server
b11242e
@dufourgilles
Fix bug in command handling
3fdf5fe
@dufourgilles
fix continuation message
9efb3e3
@dufourgilles
Ignore empty request on server
60eab03
dufourgillesand others added 22 commits January 20, 2020 12:04
@dufourgilles
v2.4.2
662bf20
@dufourgilles
use latest asn1 lib
aac8f99
@dufourgilles
Fixed some client missing promise return. Add server preMatrixConnect…
8145c3b
… to provide above app a way to decide if connection allowed or not
@dufourgilles
Fix matrix handling on server side
e68ecaa
@dufourgilles
Fixed tests. Changed server listen function to return promise
ec83eb6
@dufourgilles
Added example for setValue
5b1377d
@dufourgilles
Fix duplicate dataIn
767779f
@dufourgilles
Fix FunctionContent result encoding
a339f14
@dufourgilles
fix expand and function content encoding/decoding
ed89db5
olzzonolzzon
feat: hack setValue to immediately resolve - added setValueWithHacksa…
3b382b7
…w() function from NRKNO fork
olzzonolzzon
feat: setValueNoAck - rename of function and cleanup
82618c3
olzzonolzzon
fix: promise didn´t resolve
9110000
doc: Added comments to explain reason for hack
@dufourgilles
Fix client parameter subscribe
fe9153e
@olzzon
Merge pull request#1from olzzon/feat/timeout-hack
a8c5495
Feat/timeout hack
@olzzon
Merge pull request#2from dufourgilles/master
6bdcf11
Fix client parameter subscribe
@dufourgilles
Add support for streamDescriptor parsing from json
48037ab
@dufourgilles
Merge pull request#11from olzzon/feat/timeout-hack
d09cee7
Feat/timeout hack - setValueNoAck()
@olzzon
Merge pull request#3from dufourgilles/master
26670d0
Update from main repo
@dufourgilles
Fixed tests
f4624ae
olzzonolzzon
feat: export BER in index.js for manual ASN.1 encoding
0891219
@dufourgilles
Merge pull request#15from olzzon/feat/export-ber
91cedbe
Export BER module for manual encoding
Thomas Silvestre
Fixed TreeNode and tests
3248a95
TreeNode.js:
fix toJSON() when there are no children
Ember.test.js:
fix tests, cleaned up imports
cbialobos
cbialobos approved these changes Sep 10, 2020
View reviewed changes

@cbialoboscbialobos left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ncolboc
ncolboc reviewed Sep 10, 2020
View reviewed changes
Comment threadEmberLib/TreeNode.js Outdated
return {
elements: elements.map(e => e.toJSON())
};
return elements ? {elements: elements.map(e => e.toJSON())}: {elements: []};

@ncolbocncolbocSep 10, 2020•
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {elements: elements ? elements.map(e => e.toJSON()) : []}

ncolboc
ncolboc approved these changes Sep 10, 2020
View reviewed changes

@ncolbocncolboc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste une petite remarque, rien de grave j'approuve

@thosil
thosil merged commit b759b69 into masterSep 11, 2020
@thosil
thosil deleted the bugfix/fix_tests_and_treenode_to_json branch November 2, 2020 08:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbialoboscbialoboscbialobos approved these changes
+1 more reviewer
@ncolbocncolbocncolboc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thosil@ncolboc@cbialobos@dufourgilles@olzzon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fixed TreeNode and tests - #41
Merged
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Sep 11, 2020
Merged
Fixed TreeNode and tests#41
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Conversation
@thosil
@thosilthosil
commented
Sep 10, 2020

Copy link


Copy Markdown

  • TreeNode.js:
    
fix toJSON() when there are no children
  • Ember.test.js:
    
fix tests, cleaned up imports
Gilles Dufourand others
added 30 commits
December 9, 2019 11:41
Gilles Dufour
Added supported for Function on server side. Fixed invokationresult d…
9f8e9c8
…ecoding
Gilles Dufour
new documentation
ed2ff32
Gilles Dufour
new documentation
2638055
Gilles Dufour
Added all matrixConnect and Disconnect functions. Fixed all tests. Mo…
46297db
…dified the Doc.
@dufourgilles
Add description to label when converting json to tree
3b08081
@dufourgilles
Adding validation of connection request on server
dfbd5d1
@dufourgilles
fix contributors
22fa47c
@dufourgilles
fix contributors
5a830de
Gilles Dufour
Fixing getDirectory when root has more than 1 elements
876ed09
@dufourgilles
Added support for subscribe and unsubscribe of streams
42d351c
@dufourgilles
fixing matrix absolute connect
58bc2d8
@dufourgilles
Better error when doing getNodeByPath
fd31d8d
@dufourgilles
handle connection for 1-to-1 matrix
8859478
@dufourgilles
add maximumTotalConnects
4df675c
@dufourgilles
fix 1 to N matrix connect
2011b64
@dufourgilles
Fix 1toN. Disconnect old source and connect to new one
6d03d10
@dufourgilles
Server should emit disconnect when connecting target with new source
0283ce3
@dufourgilles
Update doc
a402f26
@dufourgilles
Do a disconnect if attempting to connect same src and target
b46b917
@dufourgilles
fix disconnect
61d9e01
@dufourgilles
handle connect with empty sources
c712676
@dufourgilles
added lock/unlock of connection
84d325c
@dufourgilles
added lock/unlock of connection
b00b1b3
@dufourgilles
Fix disconnect for 1toN
8b2109f
@dufourgilles
Fix function result missing
734c0ea
@dufourgilles
Added -1 for defaultSources to disable disconnect
341e887
@dufourgilles
fix disconnect when mismatch client server
b11242e
@dufourgilles
Fix bug in command handling
3fdf5fe
@dufourgilles
fix continuation message
9efb3e3
@dufourgilles
Ignore empty request on server
60eab03
dufourgillesand others
added 22 commits
January 20, 2020 12:04
@dufourgilles
v2.4.2
662bf20
@dufourgilles
use latest asn1 lib
aac8f99
@dufourgilles
Fixed some client missing promise return. Add server preMatrixConnect…
8145c3b
… to provide above app a way to decide if connection allowed or not
@dufourgilles
Fix matrix handling on server side
e68ecaa
@dufourgilles
Fixed tests. Changed server listen function to return promise
ec83eb6
@dufourgilles
Added example for setValue
5b1377d
@dufourgilles
Fix duplicate dataIn
767779f
@dufourgilles
Fix FunctionContent result encoding
a339f14
@dufourgilles
fix expand and function content encoding/decoding
ed89db5
olzzonolzzon
feat: hack setValue to immediately resolve - added setValueWithHacksa…
3b382b7
…w() function from NRKNO fork
olzzonolzzon
feat: setValueNoAck - rename of function and cleanup
82618c3
olzzonolzzon
fix: promise didn´t resolve
9110000
doc: Added comments to explain reason for hack
@dufourgilles
Fix client parameter subscribe
fe9153e
@olzzon
Merge pull request#1from olzzon/feat/timeout-hack
a8c5495
Feat/timeout hack
@olzzon
Merge pull request#2from dufourgilles/master
6bdcf11
Fix client parameter subscribe
@dufourgilles
Add support for streamDescriptor parsing from json
48037ab
@dufourgilles
Merge pull request#11from olzzon/feat/timeout-hack
d09cee7
Feat/timeout hack - setValueNoAck()
@olzzon
Merge pull request#3from dufourgilles/master
26670d0
Update from main repo
@dufourgilles
Fixed tests
f4624ae
olzzonolzzon
feat: export BER in index.js for manual ASN.1 encoding
0891219
@dufourgilles
Merge pull request#15from olzzon/feat/export-ber
91cedbe
Export BER module for manual encoding
Thomas Silvestre
Fixed TreeNode and tests
3248a95
TreeNode.js:
fix toJSON() when there are no children
Ember.test.js:
fix tests, cleaned up imports
cbialobos
cbialobos
approved these changes
Sep 10, 2020
View reviewed changes
@cbialoboscbialobos
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ncolboc
ncolboc
reviewed
Sep 10, 2020
View reviewed changes
Comment threadEmberLib/TreeNode.js
Outdated

 return {
 elements: elements.map(e => e.toJSON())
 };
 return elements ? {elements: elements.map(e => e.toJSON())}: {elements: []};
@ncolbocncolbocSep 10, 2020•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {elements: elements ? elements.map(e => e.toJSON()) : []}
ncolboc
ncolboc
approved these changes
Sep 10, 2020
View reviewed changes
@ncolbocncolboc
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste une petite remarque, rien de grave j'approuve
@thosil
thosil
merged commit b759b69
into
masterSep 11, 2020
@thosil
thosil
deleted the

bugfix/fix_tests_and_treenode_to_json

branch
November 2, 2020 08:01
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cbialoboscbialoboscbialobos approved these changes

+1 more reviewer

@ncolbocncolbocncolboc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@thosil@ncolboc@cbialobos@dufourgilles@olzzon

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fixed TreeNode and tests - #41
Merged
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Sep 11, 2020
Merged
Fixed TreeNode and tests#41
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Conversation
@thosil
@thosilthosil
commented
Sep 10, 2020

Copy link


Copy Markdown

  • TreeNode.js:
    
fix toJSON() when there are no children
  • Ember.test.js:
    
fix tests, cleaned up imports
Gilles Dufourand others
added 30 commits
December 9, 2019 11:41
Gilles Dufour
Added supported for Function on server side. Fixed invokationresult d…
9f8e9c8
…ecoding
Gilles Dufour
new documentation
ed2ff32
Gilles Dufour
new documentation
2638055
Gilles Dufour
Added all matrixConnect and Disconnect functions. Fixed all tests. Mo…
46297db
…dified the Doc.
@dufourgilles
Add description to label when converting json to tree
3b08081
@dufourgilles
Adding validation of connection request on server
dfbd5d1
@dufourgilles
fix contributors
22fa47c
@dufourgilles
fix contributors
5a830de
Gilles Dufour
Fixing getDirectory when root has more than 1 elements
876ed09
@dufourgilles
Added support for subscribe and unsubscribe of streams
42d351c
@dufourgilles
fixing matrix absolute connect
58bc2d8
@dufourgilles
Better error when doing getNodeByPath
fd31d8d
@dufourgilles
handle connection for 1-to-1 matrix
8859478
@dufourgilles
add maximumTotalConnects
4df675c
@dufourgilles
fix 1 to N matrix connect
2011b64
@dufourgilles
Fix 1toN. Disconnect old source and connect to new one
6d03d10
@dufourgilles
Server should emit disconnect when connecting target with new source
0283ce3
@dufourgilles
Update doc
a402f26
@dufourgilles
Do a disconnect if attempting to connect same src and target
b46b917
@dufourgilles
fix disconnect
61d9e01
@dufourgilles
handle connect with empty sources
c712676
@dufourgilles
added lock/unlock of connection
84d325c
@dufourgilles
added lock/unlock of connection
b00b1b3
@dufourgilles
Fix disconnect for 1toN
8b2109f
@dufourgilles
Fix function result missing
734c0ea
@dufourgilles
Added -1 for defaultSources to disable disconnect
341e887
@dufourgilles
fix disconnect when mismatch client server
b11242e
@dufourgilles
Fix bug in command handling
3fdf5fe
@dufourgilles
fix continuation message
9efb3e3
@dufourgilles
Ignore empty request on server
60eab03
dufourgillesand others
added 22 commits
January 20, 2020 12:04
@dufourgilles
v2.4.2
662bf20
@dufourgilles
use latest asn1 lib
aac8f99
@dufourgilles
Fixed some client missing promise return. Add server preMatrixConnect…
8145c3b
… to provide above app a way to decide if connection allowed or not
@dufourgilles
Fix matrix handling on server side
e68ecaa
@dufourgilles
Fixed tests. Changed server listen function to return promise
ec83eb6
@dufourgilles
Added example for setValue
5b1377d
@dufourgilles
Fix duplicate dataIn
767779f
@dufourgilles
Fix FunctionContent result encoding
a339f14
@dufourgilles
fix expand and function content encoding/decoding
ed89db5
olzzonolzzon
feat: hack setValue to immediately resolve - added setValueWithHacksa…
3b382b7
…w() function from NRKNO fork
olzzonolzzon
feat: setValueNoAck - rename of function and cleanup
82618c3
olzzonolzzon
fix: promise didn´t resolve
9110000
doc: Added comments to explain reason for hack
@dufourgilles
Fix client parameter subscribe
fe9153e
@olzzon
Merge pull request#1from olzzon/feat/timeout-hack
a8c5495
Feat/timeout hack
@olzzon
Merge pull request#2from dufourgilles/master
6bdcf11
Fix client parameter subscribe
@dufourgilles
Add support for streamDescriptor parsing from json
48037ab
@dufourgilles
Merge pull request#11from olzzon/feat/timeout-hack
d09cee7
Feat/timeout hack - setValueNoAck()
@olzzon
Merge pull request#3from dufourgilles/master
26670d0
Update from main repo
@dufourgilles
Fixed tests
f4624ae
olzzonolzzon
feat: export BER in index.js for manual ASN.1 encoding
0891219
@dufourgilles
Merge pull request#15from olzzon/feat/export-ber
91cedbe
Export BER module for manual encoding
Thomas Silvestre
Fixed TreeNode and tests
3248a95
TreeNode.js:
fix toJSON() when there are no children
Ember.test.js:
fix tests, cleaned up imports
cbialobos
cbialobos
approved these changes
Sep 10, 2020
View reviewed changes
@cbialoboscbialobos
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ncolboc
ncolboc
reviewed
Sep 10, 2020
View reviewed changes
Comment threadEmberLib/TreeNode.js
Outdated

 return {
 elements: elements.map(e => e.toJSON())
 };
 return elements ? {elements: elements.map(e => e.toJSON())}: {elements: []};
@ncolbocncolbocSep 10, 2020•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {elements: elements ? elements.map(e => e.toJSON()) : []}
ncolboc
ncolboc
approved these changes
Sep 10, 2020
View reviewed changes
@ncolbocncolboc
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste une petite remarque, rien de grave j'approuve
@thosil
thosil
merged commit b759b69
into
masterSep 11, 2020
@thosil
thosil
deleted the

bugfix/fix_tests_and_treenode_to_json

branch
November 2, 2020 08:01
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cbialoboscbialoboscbialobos approved these changes

+1 more reviewer

@ncolbocncolbocncolboc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@thosil@ncolboc@cbialobos@dufourgilles@olzzon

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fixed TreeNode and tests - #41
Merged
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Sep 11, 2020
Merged
Fixed TreeNode and tests#41
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Conversation
@thosil
@thosilthosil
commented
Sep 10, 2020

Copy link


Copy Markdown

  • TreeNode.js:
    
fix toJSON() when there are no children
  • Ember.test.js:
    
fix tests, cleaned up imports
Gilles Dufourand others
added 30 commits
December 9, 2019 11:41
Gilles Dufour
Added supported for Function on server side. Fixed invokationresult d…
9f8e9c8
…ecoding
Gilles Dufour
new documentation
ed2ff32
Gilles Dufour
new documentation
2638055
Gilles Dufour
Added all matrixConnect and Disconnect functions. Fixed all tests. Mo…
46297db
…dified the Doc.
@dufourgilles
Add description to label when converting json to tree
3b08081
@dufourgilles
Adding validation of connection request on server
dfbd5d1
@dufourgilles
fix contributors
22fa47c
@dufourgilles
fix contributors
5a830de
Gilles Dufour
Fixing getDirectory when root has more than 1 elements
876ed09
@dufourgilles
Added support for subscribe and unsubscribe of streams
42d351c
@dufourgilles
fixing matrix absolute connect
58bc2d8
@dufourgilles
Better error when doing getNodeByPath
fd31d8d
@dufourgilles
handle connection for 1-to-1 matrix
8859478
@dufourgilles
add maximumTotalConnects
4df675c
@dufourgilles
fix 1 to N matrix connect
2011b64
@dufourgilles
Fix 1toN. Disconnect old source and connect to new one
6d03d10
@dufourgilles
Server should emit disconnect when connecting target with new source
0283ce3
@dufourgilles
Update doc
a402f26
@dufourgilles
Do a disconnect if attempting to connect same src and target
b46b917
@dufourgilles
fix disconnect
61d9e01
@dufourgilles
handle connect with empty sources
c712676
@dufourgilles
added lock/unlock of connection
84d325c
@dufourgilles
added lock/unlock of connection
b00b1b3
@dufourgilles
Fix disconnect for 1toN
8b2109f
@dufourgilles
Fix function result missing
734c0ea
@dufourgilles
Added -1 for defaultSources to disable disconnect
341e887
@dufourgilles
fix disconnect when mismatch client server
b11242e
@dufourgilles
Fix bug in command handling
3fdf5fe
@dufourgilles
fix continuation message
9efb3e3
@dufourgilles
Ignore empty request on server
60eab03
dufourgillesand others
added 22 commits
January 20, 2020 12:04
@dufourgilles
v2.4.2
662bf20
@dufourgilles
use latest asn1 lib
aac8f99
@dufourgilles
Fixed some client missing promise return. Add server preMatrixConnect…
8145c3b
… to provide above app a way to decide if connection allowed or not
@dufourgilles
Fix matrix handling on server side
e68ecaa
@dufourgilles
Fixed tests. Changed server listen function to return promise
ec83eb6
@dufourgilles
Added example for setValue
5b1377d
@dufourgilles
Fix duplicate dataIn
767779f
@dufourgilles
Fix FunctionContent result encoding
a339f14
@dufourgilles
fix expand and function content encoding/decoding
ed89db5
olzzonolzzon
feat: hack setValue to immediately resolve - added setValueWithHacksa…
3b382b7
…w() function from NRKNO fork
olzzonolzzon
feat: setValueNoAck - rename of function and cleanup
82618c3
olzzonolzzon
fix: promise didn´t resolve
9110000
doc: Added comments to explain reason for hack
@dufourgilles
Fix client parameter subscribe
fe9153e
@olzzon
Merge pull request#1from olzzon/feat/timeout-hack
a8c5495
Feat/timeout hack
@olzzon
Merge pull request#2from dufourgilles/master
6bdcf11
Fix client parameter subscribe
@dufourgilles
Add support for streamDescriptor parsing from json
48037ab
@dufourgilles
Merge pull request#11from olzzon/feat/timeout-hack
d09cee7
Feat/timeout hack - setValueNoAck()
@olzzon
Merge pull request#3from dufourgilles/master
26670d0
Update from main repo
@dufourgilles
Fixed tests
f4624ae
olzzonolzzon
feat: export BER in index.js for manual ASN.1 encoding
0891219
@dufourgilles
Merge pull request#15from olzzon/feat/export-ber
91cedbe
Export BER module for manual encoding
Thomas Silvestre
Fixed TreeNode and tests
3248a95
TreeNode.js:
fix toJSON() when there are no children
Ember.test.js:
fix tests, cleaned up imports
cbialobos
cbialobos
approved these changes
Sep 10, 2020
View reviewed changes
@cbialoboscbialobos
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ncolboc
ncolboc
reviewed
Sep 10, 2020
View reviewed changes
Comment threadEmberLib/TreeNode.js
Outdated

 return {
 elements: elements.map(e => e.toJSON())
 };
 return elements ? {elements: elements.map(e => e.toJSON())}: {elements: []};
@ncolbocncolbocSep 10, 2020•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {elements: elements ? elements.map(e => e.toJSON()) : []}
ncolboc
ncolboc
approved these changes
Sep 10, 2020
View reviewed changes
@ncolbocncolboc
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste une petite remarque, rien de grave j'approuve
@thosil
thosil
merged commit b759b69
into
masterSep 11, 2020
@thosil
thosil
deleted the

bugfix/fix_tests_and_treenode_to_json

branch
November 2, 2020 08:01
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cbialoboscbialoboscbialobos approved these changes

+1 more reviewer

@ncolbocncolbocncolboc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@thosil@ncolboc@cbialobos@dufourgilles@olzzon

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fixed TreeNode and tests - #41
Merged
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Sep 11, 2020
Merged
Fixed TreeNode and tests#41
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Conversation
@thosil
@thosilthosil
commented
Sep 10, 2020

Copy link


Copy Markdown

  • TreeNode.js:
    
fix toJSON() when there are no children
  • Ember.test.js:
    
fix tests, cleaned up imports
Gilles Dufourand others
added 30 commits
December 9, 2019 11:41
Gilles Dufour
Added supported for Function on server side. Fixed invokationresult d…
9f8e9c8
…ecoding
Gilles Dufour
new documentation
ed2ff32
Gilles Dufour
new documentation
2638055
Gilles Dufour
Added all matrixConnect and Disconnect functions. Fixed all tests. Mo…
46297db
…dified the Doc.
@dufourgilles
Add description to label when converting json to tree
3b08081
@dufourgilles
Adding validation of connection request on server
dfbd5d1
@dufourgilles
fix contributors
22fa47c
@dufourgilles
fix contributors
5a830de
Gilles Dufour
Fixing getDirectory when root has more than 1 elements
876ed09
@dufourgilles
Added support for subscribe and unsubscribe of streams
42d351c
@dufourgilles
fixing matrix absolute connect
58bc2d8
@dufourgilles
Better error when doing getNodeByPath
fd31d8d
@dufourgilles
handle connection for 1-to-1 matrix
8859478
@dufourgilles
add maximumTotalConnects
4df675c
@dufourgilles
fix 1 to N matrix connect
2011b64
@dufourgilles
Fix 1toN. Disconnect old source and connect to new one
6d03d10
@dufourgilles
Server should emit disconnect when connecting target with new source
0283ce3
@dufourgilles
Update doc
a402f26
@dufourgilles
Do a disconnect if attempting to connect same src and target
b46b917
@dufourgilles
fix disconnect
61d9e01
@dufourgilles
handle connect with empty sources
c712676
@dufourgilles
added lock/unlock of connection
84d325c
@dufourgilles
added lock/unlock of connection
b00b1b3
@dufourgilles
Fix disconnect for 1toN
8b2109f
@dufourgilles
Fix function result missing
734c0ea
@dufourgilles
Added -1 for defaultSources to disable disconnect
341e887
@dufourgilles
fix disconnect when mismatch client server
b11242e
@dufourgilles
Fix bug in command handling
3fdf5fe
@dufourgilles
fix continuation message
9efb3e3
@dufourgilles
Ignore empty request on server
60eab03
dufourgillesand others
added 22 commits
January 20, 2020 12:04
@dufourgilles
v2.4.2
662bf20
@dufourgilles
use latest asn1 lib
aac8f99
@dufourgilles
Fixed some client missing promise return. Add server preMatrixConnect…
8145c3b
… to provide above app a way to decide if connection allowed or not
@dufourgilles
Fix matrix handling on server side
e68ecaa
@dufourgilles
Fixed tests. Changed server listen function to return promise
ec83eb6
@dufourgilles
Added example for setValue
5b1377d
@dufourgilles
Fix duplicate dataIn
767779f
@dufourgilles
Fix FunctionContent result encoding
a339f14
@dufourgilles
fix expand and function content encoding/decoding
ed89db5
olzzonolzzon
feat: hack setValue to immediately resolve - added setValueWithHacksa…
3b382b7
…w() function from NRKNO fork
olzzonolzzon
feat: setValueNoAck - rename of function and cleanup
82618c3
olzzonolzzon
fix: promise didn´t resolve
9110000
doc: Added comments to explain reason for hack
@dufourgilles
Fix client parameter subscribe
fe9153e
@olzzon
Merge pull request#1from olzzon/feat/timeout-hack
a8c5495
Feat/timeout hack
@olzzon
Merge pull request#2from dufourgilles/master
6bdcf11
Fix client parameter subscribe
@dufourgilles
Add support for streamDescriptor parsing from json
48037ab
@dufourgilles
Merge pull request#11from olzzon/feat/timeout-hack
d09cee7
Feat/timeout hack - setValueNoAck()
@olzzon
Merge pull request#3from dufourgilles/master
26670d0
Update from main repo
@dufourgilles
Fixed tests
f4624ae
olzzonolzzon
feat: export BER in index.js for manual ASN.1 encoding
0891219
@dufourgilles
Merge pull request#15from olzzon/feat/export-ber
91cedbe
Export BER module for manual encoding
Thomas Silvestre
Fixed TreeNode and tests
3248a95
TreeNode.js:
fix toJSON() when there are no children
Ember.test.js:
fix tests, cleaned up imports
cbialobos
cbialobos
approved these changes
Sep 10, 2020
View reviewed changes
@cbialoboscbialobos
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ncolboc
ncolboc
reviewed
Sep 10, 2020
View reviewed changes
Comment threadEmberLib/TreeNode.js
Outdated

 return {
 elements: elements.map(e => e.toJSON())
 };
 return elements ? {elements: elements.map(e => e.toJSON())}: {elements: []};
@ncolbocncolbocSep 10, 2020•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {elements: elements ? elements.map(e => e.toJSON()) : []}
ncolboc
ncolboc
approved these changes
Sep 10, 2020
View reviewed changes
@ncolbocncolboc
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste une petite remarque, rien de grave j'approuve
@thosil
thosil
merged commit b759b69
into
masterSep 11, 2020
@thosil
thosil
deleted the

bugfix/fix_tests_and_treenode_to_json

branch
November 2, 2020 08:01
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cbialoboscbialoboscbialobos approved these changes

+1 more reviewer

@ncolbocncolbocncolboc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@thosil@ncolboc@cbialobos@dufourgilles@olzzon

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fixed TreeNode and tests - #41
Merged
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Sep 11, 2020
Merged
Fixed TreeNode and tests#41
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Conversation
@thosil
@thosilthosil
commented
Sep 10, 2020

Copy link


Copy Markdown

  • TreeNode.js:
    
fix toJSON() when there are no children
  • Ember.test.js:
    
fix tests, cleaned up imports
Gilles Dufourand others
added 30 commits
December 9, 2019 11:41
Gilles Dufour
Added supported for Function on server side. Fixed invokationresult d…
9f8e9c8
…ecoding
Gilles Dufour
new documentation
ed2ff32
Gilles Dufour
new documentation
2638055
Gilles Dufour
Added all matrixConnect and Disconnect functions. Fixed all tests. Mo…
46297db
…dified the Doc.
@dufourgilles
Add description to label when converting json to tree
3b08081
@dufourgilles
Adding validation of connection request on server
dfbd5d1
@dufourgilles
fix contributors
22fa47c
@dufourgilles
fix contributors
5a830de
Gilles Dufour
Fixing getDirectory when root has more than 1 elements
876ed09
@dufourgilles
Added support for subscribe and unsubscribe of streams
42d351c
@dufourgilles
fixing matrix absolute connect
58bc2d8
@dufourgilles
Better error when doing getNodeByPath
fd31d8d
@dufourgilles
handle connection for 1-to-1 matrix
8859478
@dufourgilles
add maximumTotalConnects
4df675c
@dufourgilles
fix 1 to N matrix connect
2011b64
@dufourgilles
Fix 1toN. Disconnect old source and connect to new one
6d03d10
@dufourgilles
Server should emit disconnect when connecting target with new source
0283ce3
@dufourgilles
Update doc
a402f26
@dufourgilles
Do a disconnect if attempting to connect same src and target
b46b917
@dufourgilles
fix disconnect
61d9e01
@dufourgilles
handle connect with empty sources
c712676
@dufourgilles
added lock/unlock of connection
84d325c
@dufourgilles
added lock/unlock of connection
b00b1b3
@dufourgilles
Fix disconnect for 1toN
8b2109f
@dufourgilles
Fix function result missing
734c0ea
@dufourgilles
Added -1 for defaultSources to disable disconnect
341e887
@dufourgilles
fix disconnect when mismatch client server
b11242e
@dufourgilles
Fix bug in command handling
3fdf5fe
@dufourgilles
fix continuation message
9efb3e3
@dufourgilles
Ignore empty request on server
60eab03
dufourgillesand others
added 22 commits
January 20, 2020 12:04
@dufourgilles
v2.4.2
662bf20
@dufourgilles
use latest asn1 lib
aac8f99
@dufourgilles
Fixed some client missing promise return. Add server preMatrixConnect…
8145c3b
… to provide above app a way to decide if connection allowed or not
@dufourgilles
Fix matrix handling on server side
e68ecaa
@dufourgilles
Fixed tests. Changed server listen function to return promise
ec83eb6
@dufourgilles
Added example for setValue
5b1377d
@dufourgilles
Fix duplicate dataIn
767779f
@dufourgilles
Fix FunctionContent result encoding
a339f14
@dufourgilles
fix expand and function content encoding/decoding
ed89db5
olzzonolzzon
feat: hack setValue to immediately resolve - added setValueWithHacksa…
3b382b7
…w() function from NRKNO fork
olzzonolzzon
feat: setValueNoAck - rename of function and cleanup
82618c3
olzzonolzzon
fix: promise didn´t resolve
9110000
doc: Added comments to explain reason for hack
@dufourgilles
Fix client parameter subscribe
fe9153e
@olzzon
Merge pull request#1from olzzon/feat/timeout-hack
a8c5495
Feat/timeout hack
@olzzon
Merge pull request#2from dufourgilles/master
6bdcf11
Fix client parameter subscribe
@dufourgilles
Add support for streamDescriptor parsing from json
48037ab
@dufourgilles
Merge pull request#11from olzzon/feat/timeout-hack
d09cee7
Feat/timeout hack - setValueNoAck()
@olzzon
Merge pull request#3from dufourgilles/master
26670d0
Update from main repo
@dufourgilles
Fixed tests
f4624ae
olzzonolzzon
feat: export BER in index.js for manual ASN.1 encoding
0891219
@dufourgilles
Merge pull request#15from olzzon/feat/export-ber
91cedbe
Export BER module for manual encoding
Thomas Silvestre
Fixed TreeNode and tests
3248a95
TreeNode.js:
fix toJSON() when there are no children
Ember.test.js:
fix tests, cleaned up imports
cbialobos
cbialobos
approved these changes
Sep 10, 2020
View reviewed changes
@cbialoboscbialobos
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ncolboc
ncolboc
reviewed
Sep 10, 2020
View reviewed changes
Comment threadEmberLib/TreeNode.js
Outdated

 return {
 elements: elements.map(e => e.toJSON())
 };
 return elements ? {elements: elements.map(e => e.toJSON())}: {elements: []};
@ncolbocncolbocSep 10, 2020•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {elements: elements ? elements.map(e => e.toJSON()) : []}
ncolboc
ncolboc
approved these changes
Sep 10, 2020
View reviewed changes
@ncolbocncolboc
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste une petite remarque, rien de grave j'approuve
@thosil
thosil
merged commit b759b69
into
masterSep 11, 2020
@thosil
thosil
deleted the

bugfix/fix_tests_and_treenode_to_json

branch
November 2, 2020 08:01
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cbialoboscbialoboscbialobos approved these changes

+1 more reviewer

@ncolbocncolbocncolboc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@thosil@ncolboc@cbialobos@dufourgilles@olzzon

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fixed TreeNode and tests - #41
Merged
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Sep 11, 2020
Merged
Fixed TreeNode and tests#41
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Conversation
@thosil
@thosilthosil
commented
Sep 10, 2020

Copy link


Copy Markdown

  • TreeNode.js:
    
fix toJSON() when there are no children
  • Ember.test.js:
    
fix tests, cleaned up imports
Gilles Dufourand others
added 30 commits
December 9, 2019 11:41
Gilles Dufour
Added supported for Function on server side. Fixed invokationresult d…
9f8e9c8
…ecoding
Gilles Dufour
new documentation
ed2ff32
Gilles Dufour
new documentation
2638055
Gilles Dufour
Added all matrixConnect and Disconnect functions. Fixed all tests. Mo…
46297db
…dified the Doc.
@dufourgilles
Add description to label when converting json to tree
3b08081
@dufourgilles
Adding validation of connection request on server
dfbd5d1
@dufourgilles
fix contributors
22fa47c
@dufourgilles
fix contributors
5a830de
Gilles Dufour
Fixing getDirectory when root has more than 1 elements
876ed09
@dufourgilles
Added support for subscribe and unsubscribe of streams
42d351c
@dufourgilles
fixing matrix absolute connect
58bc2d8
@dufourgilles
Better error when doing getNodeByPath
fd31d8d
@dufourgilles
handle connection for 1-to-1 matrix
8859478
@dufourgilles
add maximumTotalConnects
4df675c
@dufourgilles
fix 1 to N matrix connect
2011b64
@dufourgilles
Fix 1toN. Disconnect old source and connect to new one
6d03d10
@dufourgilles
Server should emit disconnect when connecting target with new source
0283ce3
@dufourgilles
Update doc
a402f26
@dufourgilles
Do a disconnect if attempting to connect same src and target
b46b917
@dufourgilles
fix disconnect
61d9e01
@dufourgilles
handle connect with empty sources
c712676
@dufourgilles
added lock/unlock of connection
84d325c
@dufourgilles
added lock/unlock of connection
b00b1b3
@dufourgilles
Fix disconnect for 1toN
8b2109f
@dufourgilles
Fix function result missing
734c0ea
@dufourgilles
Added -1 for defaultSources to disable disconnect
341e887
@dufourgilles
fix disconnect when mismatch client server
b11242e
@dufourgilles
Fix bug in command handling
3fdf5fe
@dufourgilles
fix continuation message
9efb3e3
@dufourgilles
Ignore empty request on server
60eab03
dufourgillesand others
added 22 commits
January 20, 2020 12:04
@dufourgilles
v2.4.2
662bf20
@dufourgilles
use latest asn1 lib
aac8f99
@dufourgilles
Fixed some client missing promise return. Add server preMatrixConnect…
8145c3b
… to provide above app a way to decide if connection allowed or not
@dufourgilles
Fix matrix handling on server side
e68ecaa
@dufourgilles
Fixed tests. Changed server listen function to return promise
ec83eb6
@dufourgilles
Added example for setValue
5b1377d
@dufourgilles
Fix duplicate dataIn
767779f
@dufourgilles
Fix FunctionContent result encoding
a339f14
@dufourgilles
fix expand and function content encoding/decoding
ed89db5
olzzonolzzon
feat: hack setValue to immediately resolve - added setValueWithHacksa…
3b382b7
…w() function from NRKNO fork
olzzonolzzon
feat: setValueNoAck - rename of function and cleanup
82618c3
olzzonolzzon
fix: promise didn´t resolve
9110000
doc: Added comments to explain reason for hack
@dufourgilles
Fix client parameter subscribe
fe9153e
@olzzon
Merge pull request#1from olzzon/feat/timeout-hack
a8c5495
Feat/timeout hack
@olzzon
Merge pull request#2from dufourgilles/master
6bdcf11
Fix client parameter subscribe
@dufourgilles
Add support for streamDescriptor parsing from json
48037ab
@dufourgilles
Merge pull request#11from olzzon/feat/timeout-hack
d09cee7
Feat/timeout hack - setValueNoAck()
@olzzon
Merge pull request#3from dufourgilles/master
26670d0
Update from main repo
@dufourgilles
Fixed tests
f4624ae
olzzonolzzon
feat: export BER in index.js for manual ASN.1 encoding
0891219
@dufourgilles
Merge pull request#15from olzzon/feat/export-ber
91cedbe
Export BER module for manual encoding
Thomas Silvestre
Fixed TreeNode and tests
3248a95
TreeNode.js:
fix toJSON() when there are no children
Ember.test.js:
fix tests, cleaned up imports
cbialobos
cbialobos
approved these changes
Sep 10, 2020
View reviewed changes
@cbialoboscbialobos
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ncolboc
ncolboc
reviewed
Sep 10, 2020
View reviewed changes
Comment threadEmberLib/TreeNode.js
Outdated

 return {
 elements: elements.map(e => e.toJSON())
 };
 return elements ? {elements: elements.map(e => e.toJSON())}: {elements: []};
@ncolbocncolbocSep 10, 2020•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {elements: elements ? elements.map(e => e.toJSON()) : []}
ncolboc
ncolboc
approved these changes
Sep 10, 2020
View reviewed changes
@ncolbocncolboc
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste une petite remarque, rien de grave j'approuve
@thosil
thosil
merged commit b759b69
into
masterSep 11, 2020
@thosil
thosil
deleted the

bugfix/fix_tests_and_treenode_to_json

branch
November 2, 2020 08:01
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cbialoboscbialoboscbialobos approved these changes

+1 more reviewer

@ncolbocncolbocncolboc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@thosil@ncolboc@cbialobos@dufourgilles@olzzon

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fixed TreeNode and tests - #41
Merged
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Sep 11, 2020
Merged
Fixed TreeNode and tests#41
thosil merged 72 commits into
masterfrom 
bugfix/fix_tests_and_treenode_to_json
Conversation
@thosil
@thosilthosil
commented
Sep 10, 2020

Copy link


Copy Markdown

  • TreeNode.js:
    
fix toJSON() when there are no children
  • Ember.test.js:
    
fix tests, cleaned up imports
Gilles Dufourand others
added 30 commits
December 9, 2019 11:41
Gilles Dufour
Added supported for Function on server side. Fixed invokationresult d…
9f8e9c8
…ecoding
Gilles Dufour
new documentation
ed2ff32
Gilles Dufour
new documentation
2638055
Gilles Dufour
Added all matrixConnect and Disconnect functions. Fixed all tests. Mo…
46297db
…dified the Doc.
@dufourgilles
Add description to label when converting json to tree
3b08081
@dufourgilles
Adding validation of connection request on server
dfbd5d1
@dufourgilles
fix contributors
22fa47c
@dufourgilles
fix contributors
5a830de
Gilles Dufour
Fixing getDirectory when root has more than 1 elements
876ed09
@dufourgilles
Added support for subscribe and unsubscribe of streams
42d351c
@dufourgilles
fixing matrix absolute connect
58bc2d8
@dufourgilles
Better error when doing getNodeByPath
fd31d8d
@dufourgilles
handle connection for 1-to-1 matrix
8859478
@dufourgilles
add maximumTotalConnects
4df675c
@dufourgilles
fix 1 to N matrix connect
2011b64
@dufourgilles
Fix 1toN. Disconnect old source and connect to new one
6d03d10
@dufourgilles
Server should emit disconnect when connecting target with new source
0283ce3
@dufourgilles
Update doc
a402f26
@dufourgilles
Do a disconnect if attempting to connect same src and target
b46b917
@dufourgilles
fix disconnect
61d9e01
@dufourgilles
handle connect with empty sources
c712676
@dufourgilles
added lock/unlock of connection
84d325c
@dufourgilles
added lock/unlock of connection
b00b1b3
@dufourgilles
Fix disconnect for 1toN
8b2109f
@dufourgilles
Fix function result missing
734c0ea
@dufourgilles
Added -1 for defaultSources to disable disconnect
341e887
@dufourgilles
fix disconnect when mismatch client server
b11242e
@dufourgilles
Fix bug in command handling
3fdf5fe
@dufourgilles
fix continuation message
9efb3e3
@dufourgilles
Ignore empty request on server
60eab03
dufourgillesand others
added 22 commits
January 20, 2020 12:04
@dufourgilles
v2.4.2
662bf20
@dufourgilles
use latest asn1 lib
aac8f99
@dufourgilles
Fixed some client missing promise return. Add server preMatrixConnect…
8145c3b
… to provide above app a way to decide if connection allowed or not
@dufourgilles
Fix matrix handling on server side
e68ecaa
@dufourgilles
Fixed tests. Changed server listen function to return promise
ec83eb6
@dufourgilles
Added example for setValue
5b1377d
@dufourgilles
Fix duplicate dataIn
767779f
@dufourgilles
Fix FunctionContent result encoding
a339f14
@dufourgilles
fix expand and function content encoding/decoding
ed89db5
olzzonolzzon
feat: hack setValue to immediately resolve - added setValueWithHacksa…
3b382b7
…w() function from NRKNO fork
olzzonolzzon
feat: setValueNoAck - rename of function and cleanup
82618c3
olzzonolzzon
fix: promise didn´t resolve
9110000
doc: Added comments to explain reason for hack
@dufourgilles
Fix client parameter subscribe
fe9153e
@olzzon
Merge pull request#1from olzzon/feat/timeout-hack
a8c5495
Feat/timeout hack
@olzzon
Merge pull request#2from dufourgilles/master
6bdcf11
Fix client parameter subscribe
@dufourgilles
Add support for streamDescriptor parsing from json
48037ab
@dufourgilles
Merge pull request#11from olzzon/feat/timeout-hack
d09cee7
Feat/timeout hack - setValueNoAck()
@olzzon
Merge pull request#3from dufourgilles/master
26670d0
Update from main repo
@dufourgilles
Fixed tests
f4624ae
olzzonolzzon
feat: export BER in index.js for manual ASN.1 encoding
0891219
@dufourgilles
Merge pull request#15from olzzon/feat/export-ber
91cedbe
Export BER module for manual encoding
Thomas Silvestre
Fixed TreeNode and tests
3248a95
TreeNode.js:
fix toJSON() when there are no children
Ember.test.js:
fix tests, cleaned up imports
cbialobos
cbialobos
approved these changes
Sep 10, 2020
View reviewed changes
@cbialoboscbialobos
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ncolboc
ncolboc
reviewed
Sep 10, 2020
View reviewed changes
Comment threadEmberLib/TreeNode.js
Outdated

 return {
 elements: elements.map(e => e.toJSON())
 };
 return elements ? {elements: elements.map(e => e.toJSON())}: {elements: []};
@ncolbocncolbocSep 10, 2020•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {elements: elements ? elements.map(e => e.toJSON()) : []}
ncolboc
ncolboc
approved these changes
Sep 10, 2020
View reviewed changes
@ncolbocncolboc
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste une petite remarque, rien de grave j'approuve
@thosil
thosil
merged commit b759b69
into
masterSep 11, 2020
@thosil
thosil
deleted the

bugfix/fix_tests_and_treenode_to_json

branch
November 2, 2020 08:01
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cbialoboscbialoboscbialobos approved these changes

+1 more reviewer

@ncolbocncolbocncolboc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@thosil@ncolboc@cbialobos@dufourgilles@olzzon