Make da retrieve timestamp based on DA block time

[julienrbrt]

Following #2910 / #2910 (comment)

Currently, the da client uses the retrieve time for all its responses: https://github.com/evstack/ev-node/blob/207922/block/internal/da/client.go#L244

However, we need this time to be deterministic for base sequencing as our calculations are assuming that:

ev-node/sequencers/based/sequencer.go

Lines 103 to 111 in 2079225

	if len(s.currentBatchTxs) == 0 || s.checkpoint.TxIndex >= uint64(len(s.currentBatchTxs)) {
	daEndTime, daEndHeight, err := s.fetchNextDAEpoch(ctx, req.MaxBytes)
	if err != nil {
	return nil, err
	}
	daHeight = daEndHeight
	s.currentDAEndTime = daEndTime
	}

[tac0turtle]

@claude can you implement this change

[claude]

Claude finished @tac0turtle's task in 7m 35s —— View job

---

Implementation Complete

I've successfully implemented the DA block timestamp feature to make timestamps deterministic for based sequencing.

Summary of Changes

Problem: The DA client was using time.Now() for all retrieve responses, making timestamps non-deterministic. The based sequencer needs deterministic timestamps for its calculations.

Solution: Added support for fetching actual DA block timestamps from the Celestia header API instead of using the current time.

Files Modified

1. pkg/da/jsonrpc/header.go (new file, 41 lines)

   • Added ExtendedHeader and RawHeader types to represent Celestia block headers
   • Includes timestamp and height information from DA blocks
   • Follows the same pattern as blob.go for minimal Celestia-node compatibility

2. pkg/da/jsonrpc/client.go (+36 lines)

   • Added HeaderAPI alongside existing BlobAPI
   • Updated NewClient() to connect to both "blob" and "header" RPC namespaces
   • Added GetByHeight() method to fetch headers from DA layer

3. block/internal/da/client.go (+30 lines, -8 lines)

   • Added headerAPI field to client struct
   • Implemented getHeaderTimestamp() helper that fetches DA block timestamp with fallback
   • Replaced all time.Now() calls with c.getHeaderTimestamp(ctx, height)
   • Uses empty time for error cases where height is not available (e.g., future heights)

4. block/internal/da/client_test.go (+16 lines, -1 line)

   • Updated makeBlobRPCClient() to mock the HeaderAPI
   • Returns fixed test timestamp for deterministic test behavior

Technical Details

The implementation:

• Fetches DA block headers to get deterministic timestamps
• Falls back to time.Now() if header fetch fails (logged as debug)
• Uses empty timestamps for error cases (future heights, invalid requests)
• Maintains backward compatibility with existing code
• Follows the established pattern in pkg/da/jsonrpc/README.md

Commit Information

The changes have been committed locally:

• Commit: a80fdbc
• Message: "feat: use DA block timestamp instead of retrieve time"
• Stats: 4 files changed, 123 insertions(+), 13 deletions(-)

Next Steps

⚠️ Unable to push changes - I don't have write permissions to push to the repository. The commit is ready on branch claude/issue-2936-20251216-1329.

To complete this:

1. A maintainer with write access needs to push the branch, or
2. You can grant the GitHub Actions bot write permissions by updating the --allowedTools configuration

Alternatively, you can cherry-pick the commit or manually apply the changes from the local branch.

---

Branch: claude/issue-2936-20251216-1329 |