Skip to content

Move libs to libs/celestia-app - #1118

Merged
MSevey merged 1 commit into
mainfrom
manav/move-libs-under-celestia-app
Jul 31, 2023
Merged

Move libs to libs/celestia-app#1118
MSevey merged 1 commit into
mainfrom
manav/move-libs-under-celestia-app

Conversation

@Manav-Aggarwal

@Manav-AggarwalManav-Aggarwal commented Jul 31, 2023

Copy link
Copy Markdown
Member

Overview

Closes: #1119

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-AggarwalManav-Aggarwal added the T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jul 31, 2023
@Manav-AggarwalManav-Aggarwal linked an issue Jul 31, 2023 that may be closed by this pull request
@Manav-Aggarwal
Manav-Aggarwalforce-pushed the manav/move-libs-under-celestia-app branch from e6649c3 to e812da0CompareJuly 31, 2023 15:11
@Manav-Aggarwal
Manav-Aggarwal marked this pull request as ready for review July 31, 2023 15:12
@codecov

codecovBot commented Jul 31, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (4c903bc) 55.99% compared to head (e812da0) 55.99%.

Additional details and impacted files
@@ Coverage Diff @@## main #1118 +/- ##
=======================================
Coverage 55.99% 55.99% =======================================
Files 61 61 Lines 6552 6552 =======================================
Hits 3669 3669 Misses 2491 2491 Partials 392 392 
Files ChangedCoverage Δ
libs/celestia-app/namespace/namespace.go50.00% <ø> (ø)
libs/celestia-app/namespace/random_blob.go0.00% <ø> (ø)
libs/celestia-app/namespace/random_namespace.go0.00% <ø> (ø)
libs/celestia-app/shares/info_byte.go100.00% <ø> (ø)
libs/celestia-app/shares/parse_compact_shares.go64.00% <ø> (ø)
libs/celestia-app/shares/reserved_bytes.go100.00% <ø> (ø)
libs/celestia-app/shares/share_builder.go76.31% <ø> (ø)
libs/celestia-app/shares/share_sequence.go93.47% <ø> (ø)
libs/celestia-app/shares/shares.go53.90% <ø> (ø)
libs/celestia-app/shares/split_compact_shares.go66.66% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MSevey
MSevey enabled auto-merge July 31, 2023 15:18
@MSevey
MSevey added this pull request to the merge queueJul 31, 2023

@nashqueuenashqueue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Merged via the queue into main with commit 509d0b1Jul 31, 2023
@MSevey
MSevey deleted the manav/move-libs-under-celestia-app branch July 31, 2023 20:47
Manav-Aggarwal added a commit that referenced this pull request Sep 6, 2023
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
Closes: #1119
<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move libs to libs/celestia-app

3 participants

@Manav-Aggarwal@MSevey@nashqueue