Skip to content

Recompute signature in signature header tests to make tests throw the right errors - #1162

Merged
Manav-Aggarwal merged 4 commits into
mainfrom
manav/validate_exact_error_in_signed_header_tests
Sep 1, 2023
Merged

Recompute signature in signature header tests to make tests throw the right errors#1162
Manav-Aggarwal merged 4 commits into
mainfrom
manav/validate_exact_error_in_signed_header_tests

Conversation

@Manav-Aggarwal

@Manav-AggarwalManav-Aggarwal commented Aug 30, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Overview

Closes: #1163

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-AggarwalManav-Aggarwal changed the title Make Signed Header Tests have more accurate testingRecompute signature in signature header tests to make errors hit the right code pathAug 30, 2023
@Manav-AggarwalManav-Aggarwal added T:testing Related to testing T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T:enhancement labels Aug 30, 2023
@Manav-Aggarwal
Manav-Aggarwal marked this pull request as ready for review August 30, 2023 20:35
@codecov

codecovBot commented Aug 30, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.25% 🎉

Comparison is base (63486ad) 55.45% compared to head (e1c9157) 55.70%.

Additional details and impacted files
@@ Coverage Diff @@## main #1162 +/- ##
==========================================
+ Coverage 55.45% 55.70% +0.25% 
==========================================
Files 63 63 Lines 6699 6699 ==========================================
+ Hits 3715 3732 +17 + Misses 2589 2576 -13 + Partials 395 391 -4
Files ChangedCoverage Δ
types/hashing.go93.10% <0.00%> (ø)
state/executor.go55.52% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manav-AggarwalManav-Aggarwal changed the title Recompute signature in signature header tests to make errors hit the right code pathRecompute signature in signature header tests to make tests throw the right errorsAug 30, 2023
@Manav-Aggarwal
Manav-Aggarwalforce-pushed the manav/validate_exact_error_in_signed_header_tests branch from cd8dba5 to e1c9157CompareAugust 31, 2023 13:34
@Manav-AggarwalManav-Aggarwal mentioned this pull request Aug 31, 2023
Merged
5 tasks
@Manav-Aggarwal
Manav-Aggarwal added this pull request to the merge queueSep 1, 2023
Merged via the queue into main with commit 8063321Sep 1, 2023
@Manav-Aggarwal
Manav-Aggarwal deleted the manav/validate_exact_error_in_signed_header_tests branch September 1, 2023 20:03
Manav-Aggarwal added a commit that referenced this pull request Sep 6, 2023
@Manav-Aggarwal
Recompute signature in signature header tests to make tests throw the…
168d382
… right errors (#1162)
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes: #1163 <!-- Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. -->
## Checklist
<!-- Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
github-merge-queueBot pushed a commit that referenced this pull request Sep 9, 2023
@Manav-Aggarwal@MSevey
Validate exact expected error in signed header verification tests (#1165
472f245
)
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes: #1049
Stacked on top of #1162
<!-- Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. -->
## Checklist
<!-- Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
---------
Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
gupadhyaya pushed a commit that referenced this pull request Sep 13, 2023
@Manav-Aggarwal@MSeveyGanesha Upadhyaya
Validate exact expected error in signed header verification tests (#1165
80e4f67
)
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes: #1049
Stacked on top of #1162
<!-- Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. -->
## Checklist
<!-- Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
---------
Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
chandiniv1 pushed a commit to chandiniv1/rollkit that referenced this pull request Sep 25, 2023
@Manav-Aggarwal@MSevey@chandiniv1
Validate exact expected error in signed header verification tests (ev…
5ea225d
…stack#1165)
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
Closes: evstack#1049
Stacked on top of evstack#1162
<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
---------
Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashqueuenashqueueAwaiting requested review from nashqueue
2 more reviewers
@gupadhyayagupadhyayagupadhyaya approved these changes
@MSeveyMSeveyMSevey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Manav-AggarwalManav-Aggarwal

Labels

T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.T:enhancementT:testingRelated to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recompute signature in signature header tests to make tests throw the right errors

3 participants

@Manav-Aggarwal@gupadhyaya@MSevey