Skip to content

Use uint64 height types instead of int64 - #1177

Merged
Manav-Aggarwal merged 4 commits into
mainfrom
manav/convert_uint64_everywhere
Sep 14, 2023
Merged

Use uint64 height types instead of int64#1177
Manav-Aggarwal merged 4 commits into
mainfrom
manav/convert_uint64_everywhere

Conversation

@Manav-Aggarwal

@Manav-AggarwalManav-Aggarwal commented Sep 12, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Overview

Closes: #1176

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-AggarwalManav-Aggarwal mentioned this pull request Sep 12, 2023
Merged
@Manav-Aggarwal
Manav-Aggarwalforce-pushed the manav/convert_uint64_everywhere branch from 29db641 to 48a6ba7CompareSeptember 13, 2023 15:19
@Manav-Aggarwal
Manav-Aggarwalforce-pushed the manav/convert_uint64_everywhere branch from 48a6ba7 to 2d41693CompareSeptember 13, 2023 15:21
@codecov

codecovBot commented Sep 13, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 61.11% and project coverage change: -0.05%⚠️

Comparison is base (96848dc) 56.14% compared to head (662b4d2) 56.10%.
Report is 1 commits behind head on main.

❗ Current head 662b4d2 differs from pull request most recent head 49b039a. Consider uploading reports for the commit 49b039a to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## main #1177 +/- ##
==========================================
- Coverage 56.14% 56.10% -0.05% 
==========================================
Files 63 63 Lines 6695 6695 ==========================================
- Hits 3759 3756 -3 - Misses 2551 2554 +3 
Partials 385 385
Files ChangedCoverage Δ
block/manager.go8.59% <0.00%> (ø)
mempool/mempool.go0.00% <ø> (ø)
mempool/v1/tx.go76.31% <ø> (ø)
types/state.go0.00% <0.00%> (ø)
state/executor.go55.52% <40.00%> (ø)
mempool/v1/mempool.go85.47% <100.00%> (ø)
node/full_client.go44.26% <100.00%> (ø)
types/block.go48.27% <100.00%> (ø)
types/test_utils.go84.21% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manav-Aggarwal
Manav-Aggarwal marked this pull request as ready for review September 13, 2023 15:25
@Manav-Aggarwal
Manav-Aggarwalforce-pushed the manav/convert_uint64_everywhere branch from e13a623 to 662b4d2CompareSeptember 13, 2023 15:54
@Manav-AggarwalManav-Aggarwal changed the title Convert to uint64 everywhereUse uint64 height types instead of int64Sep 13, 2023
MSevey
MSevey reviewed Sep 13, 2023
View reviewed changes
Comment threadtypes/test_utils.go
MSevey
MSevey approved these changes Sep 13, 2023
View reviewed changes

@MSeveyMSevey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor question.

tzdybal
tzdybal approved these changes Sep 13, 2023
View reviewed changes

@tzdybaltzdybal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@gupadhyaya
gupadhyaya added this pull request to the merge queueSep 13, 2023
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Sep 13, 2023
@Manav-Aggarwal
Manav-Aggarwal added this pull request to the merge queueSep 14, 2023
Merged via the queue into main with commit d3a5ed3Sep 14, 2023
@Manav-Aggarwal
Manav-Aggarwal deleted the manav/convert_uint64_everywhere branch September 14, 2023 15:08
gupadhyaya pushed a commit that referenced this pull request Sep 22, 2023
@Manav-AggarwalGanesha Upadhyaya
Use uint64 height types instead of int64 (#1177)
c122610
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
Closes: #1176
<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
chandiniv1 pushed a commit to chandiniv1/rollkit that referenced this pull request Sep 25, 2023
@Manav-Aggarwal@chandiniv1
Use uint64 height types instead of int64 (evstack#1177)
9119a0f
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes: evstack#1176 <!-- Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. -->
## Checklist
<!-- Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashqueuenashqueueAwaiting requested review from nashqueue
@WondertanWondertanAwaiting requested review from Wondertan
@gupadhyayagupadhyayaAwaiting requested review from gupadhyaya
2 more reviewers
@tzdybaltzdybaltzdybal approved these changes
@MSeveyMSeveyMSevey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Manav-AggarwalManav-Aggarwal

Labels

C:header

Projects

None yet

Milestone

No milestone

3 participants

@Manav-Aggarwal@tzdybal@MSevey