Skip to content

Remove unused fields in full node - #1218

Merged
gupadhyaya merged 1 commit into
mainfrom
manav/clean_up_full_node
Oct 4, 2023
Merged

Remove unused fields in full node#1218
gupadhyaya merged 1 commit into
mainfrom
manav/clean_up_full_node

Conversation

@Manav-Aggarwal

@Manav-AggarwalManav-Aggarwal commented Oct 2, 2023

Copy link
Copy Markdown
Member

Overview

Closes: #1219

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-AggarwalManav-Aggarwal added the T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Oct 2, 2023
@Manav-Aggarwal
Manav-Aggarwal marked this pull request as ready for review October 2, 2023 03:32
@codecov

codecovBot commented Oct 2, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e3f2b40) 53.81% compared to head (a5316a5) 53.90%.

Additional details and impacted files
@@ Coverage Diff @@## main #1218 +/- ##
==========================================
+ Coverage 53.81% 53.90% +0.08% 
==========================================
Files 64 64 Lines 6989 6987 -2 ==========================================
+ Hits 3761 3766 +5 + Misses 2873 2866 -7 
Partials 355 355 
FilesCoverage Δ
node/full.go64.57% <100.00%> (-0.32%)⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gupadhyaya
gupadhyaya previously approved these changes Oct 2, 2023
S1nus
S1nus previously approved these changes Oct 2, 2023
@gupadhyaya
gupadhyaya added this pull request to the merge queueOct 4, 2023
Merged via the queue into main with commit 6c4a346Oct 4, 2023
@gupadhyaya
gupadhyaya deleted the manav/clean_up_full_node branch October 4, 2023 01:01
chandiniv1 pushed a commit to chandiniv1/rollkit that referenced this pull request Oct 19, 2023
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes: evstack#1219 <!-- Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. -->
## Checklist
<!-- Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [ ] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
gupadhyaya pushed a commit that referenced this pull request Oct 20, 2023
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes: #1219 <!-- Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. -->
## Checklist
<!-- Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [ ] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
chandiniv1 pushed a commit to chandiniv1/rollkit that referenced this pull request Oct 31, 2023
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
Closes: evstack#1219
<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [ ] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused fields in Full Node

3 participants

@Manav-Aggarwal@S1nus@gupadhyaya