Skip to content

Refactor full node test - #1228

Merged
Manav-Aggarwal merged 3 commits into
mainfrom
manav/refactor_full_node_test
Oct 6, 2023
Merged

Refactor full node test#1228
Manav-Aggarwal merged 3 commits into
mainfrom
manav/refactor_full_node_test

Conversation

@Manav-Aggarwal

@Manav-AggarwalManav-Aggarwal commented Oct 4, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Overview

Closes: #1230

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-AggarwalManav-Aggarwal added T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T:testing Related to testing labels Oct 4, 2023
@Manav-Aggarwal
Manav-Aggarwal marked this pull request as ready for review October 4, 2023 16:31
@codecov

codecovBot commented Oct 4, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3e7ff30) 53.98% compared to head (2e3d6ba) 53.87%.

❗ Current head 2e3d6ba differs from pull request most recent head fc7fc63. Consider uploading reports for the commit fc7fc63 to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## main #1228 +/- ##
==========================================
- Coverage 53.98% 53.87% -0.12% 
==========================================
Files 64 64 Lines 7020 7020 ==========================================
- Hits 3790 3782 -8 - Misses 2872 2878 +6 - Partials 358 360 +2

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MSevey
MSevey reviewed Oct 4, 2023
View reviewed changes
Comment threadnode/full_node_test.go Outdated
MSevey
MSevey reviewed Oct 4, 2023
View reviewed changes
Comment threadnode/full_node_test.go Outdated
MSevey
MSevey reviewed Oct 4, 2023
View reviewed changes
Comment threadnode/full_node_test.go Outdated
MSevey
MSevey reviewed Oct 4, 2023
View reviewed changes
Comment threadnode/full_node_test.go Outdated
MSevey
MSevey suggested changes Oct 4, 2023
View reviewed changes

@MSeveyMSevey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can clean this up some more 👍

@MSeveyMSevey mentioned this pull request Oct 4, 2023
Merged
5 tasks
@Manav-Aggarwal
Manav-Aggarwalforce-pushed the manav/refactor_full_node_test branch from adbef40 to 2e3d6baCompareOctober 5, 2023 02:03
MSevey
MSevey reviewed Oct 5, 2023
View reviewed changes
Comment threadnode/full_node_test.go
MSevey
MSevey reviewed Oct 5, 2023
View reviewed changes

@MSeveyMSevey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final tweak, otherwise lgtm

gupadhyaya
gupadhyaya reviewed Oct 5, 2023
View reviewed changes
Comment threadnode/full_node_test.go
@Manav-Aggarwal
Manav-Aggarwal added this pull request to the merge queueOct 6, 2023
Merged via the queue into main with commit 8667026Oct 6, 2023
@Manav-Aggarwal
Manav-Aggarwal deleted the manav/refactor_full_node_test branch October 6, 2023 15:55
chandiniv1 pushed a commit to chandiniv1/rollkit that referenced this pull request Oct 19, 2023
@Manav-Aggarwal@chandiniv1
Refactor full node test (evstack#1228)
00ba390
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes: evstack#1230
<!-- Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. -->
## Checklist
<!-- Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
chandiniv1 pushed a commit to chandiniv1/rollkit that referenced this pull request Oct 31, 2023
@Manav-Aggarwal@chandiniv1
Refactor full node test (evstack#1228)
01efd67
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
Closes: evstack#1230
<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@S1nusS1nusAwaiting requested review from S1nus
@tuxcanflytuxcanflyAwaiting requested review from tuxcanfly
2 more reviewers
@gupadhyayagupadhyayagupadhyaya approved these changes
@MSeveyMSeveyMSevey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Manav-AggarwalManav-Aggarwal

Labels

T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.T:testingRelated to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor full node test

3 participants

@Manav-Aggarwal@gupadhyaya@MSevey