Skip to content

Block sync - #139

Merged
tzdybal merged 11 commits into
mainfrom
tzdybal/block_sync
Oct 13, 2021
Merged

Block sync#139
tzdybal merged 11 commits into
mainfrom
tzdybal/block_sync

Conversation

@tzdybal

@tzdybaltzdybal commented Oct 6, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor
  • blocks passed to blockManager after gossiping
  • aggregator renamed to blockManager
  • DALC(BlockRetriever) used to fetch block data
  • more refactoring (move blockManager out of node package)
  • more tests
    • block propagation specific tests
    • more assertions in integration test

@tzdybal
Block sync
ea0be5c
* aggregator renamed to blockManager
* blocks are passed to blockManager after gossiping
* DALC(BlockRetriever) used to fetch block data
* more refactoring needed
* more tests needed
@tzdybaltzdybal self-assigned this Oct 6, 2021
@codecov-commenter

codecov-commenter commented Oct 6, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #139 (4bf2ca5) into main (bed9ce7) will decrease coverage by 1.50%.
The diff coverage is 73.99%.

Impacted file tree graph

@@ Coverage Diff @@## main #139 +/- ##
==========================================
- Coverage 57.07% 55.57% -1.51% 
==========================================
Files 24 29 +5 Lines 2127 3741 +1614 ==========================================
+ Hits 1214 2079 +865 - Misses 786 1375 +589 - Partials 127 287 +160
Impacted FilesCoverage Δ
block/manager.go70.49% <70.49%> (ø)
node/node.go65.03% <87.50%> (+12.15%)⬆️
da/mock/mock.go92.68% <89.47%> (+23.71%)⬆️
state/executor.go69.44% <100.00%> (ø)
types/pb/optimint/optimint.pb.go43.87% <0.00%> (ø)
log/test/loggers.go80.95% <0.00%> (ø)
conv/abci/block.go100.00% <0.00%> (ø)
da/registry/registry.go75.00% <0.00%> (ø)
mocks/Application.go32.30% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed9ce7...4bf2ca5. Read the comment docs.

@tzdybal
tzdybal marked this pull request as ready for review October 8, 2021 16:05
@adlerjohn

adlerjohn commented Oct 10, 2021

Copy link
Copy Markdown
Contributor

Can you resolve merge conflicts before review? ty

adlerjohn
adlerjohn reviewed Oct 10, 2021
View reviewed changes
Comment threadblock/manager.go Outdated
Comment threadblock/manager.go
Comment threadblock/manager.go
liamsi
liamsi reviewed Oct 12, 2021
View reviewed changes

@liamsiliamsi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on first sight! More in-depth review following soon.

Comment thread.github/workflows/test.yml
Comment on lines +26 to +27
go install github.com/ory/go-acc@v0.2.6
go-acc -o coverage.txt ./... -- -v --race

@liamsiliamsiOct 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn't know about this tool.

@tzdybaltzdybalOct 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can read about it here: https://www.ory.sh/golang-go-code-coverage-accurate/

Comment threadblock/manager.go
adlerjohn
adlerjohn approved these changes Oct 13, 2021
View reviewed changes

@adlerjohnadlerjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but suggest waiting for a review from @liamsi as well.

liamsi
liamsi approved these changes Oct 13, 2021
View reviewed changes

@liamsiliamsi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the rationale behind the renaming to block manager but this looks good to me.

@tzdybal
tzdybal merged commit 0826c05 into mainOct 13, 2021
@tzdybal
tzdybal deleted the tzdybal/block_sync branch October 13, 2021 19:42
This was referenced Oct 13, 2021
Closed
Closed
@tzdybaltzdybal mentioned this pull request Oct 14, 2021
Merged
@claudeclaudeBot mentioned this pull request Oct 14, 2025
Merged
@claudeclaudeBot mentioned this pull request Nov 6, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liamsiliamsiliamsi approved these changes
@evan-forbesevan-forbesAwaiting requested review from evan-forbes
@mattdfmattdfAwaiting requested review from mattdf
+1 more reviewer
@adlerjohnadlerjohnadlerjohn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tzdybaltzdybal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tzdybal@codecov-commenter@adlerjohn@liamsi