Add new ErrKeyNotFound

[pmareke]

Fixes#147

Done:

• Create ErrKeyNotFound sentinel variable
• Properly handle badger.ErrKeyNotFound
• Properly handle "key not found situation" in da/mock package

Signed-off-by: pedro.lopez.mareque@gmail.com

[tzdybal]

Thanks for your submission!

I left some suggestions.

Please update tests to show that sentinel error value is properly returned.

[pmareke]

Thanks @tzdybal, fixed!

PD: Which tests do you mean? In the TestMockDALC as we're not returning the error when the key doesn't exist I don't know what you mean.

[codecov-commenter]

Codecov Report

Merging #148 (3a6ac53) into main (59ab23b) will increase coverage by 0.35%.
The diff coverage is 57.14%.

@@ Coverage Diff @@## main #148 +/- ##
==========================================
+ Coverage 57.07% 57.43% +0.35% 
==========================================
Files 24 24 Lines 2127 2133 +6 ==========================================
+ Hits 1214 1225 +11 + Misses 786 782 -4 + Partials 127 126 -1 

Impacted Files	Coverage Δ
da/mock/mock.go	65.57% <25.00%> (-3.40%)	⬇️
store/badger.go	100.00% <100.00%> (+45.83%)	⬆️
node/aggregator.go	65.68% <0.00%> (-2.95%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ab23b...3a6ac53. Read the comment docs.

[tzdybal]

da/mock tests already asserts this correctly (see: mock_test.go:66). Forcing actual error (da.StatusError) is not the scope of #147.

Actually, there are no unit tests of BadgerKV (it's covered by tests of Store). You can create store/badger_test.go and add add a test for Get. To trigger error other than ErrKeyNotFound you can use !badger! as a key (see: ErrInvalidKey).

[pmareke]

da/mock tests already asserts this correctly (see: mock_test.go:66). Forcing actual error (da.StatusError) is not the scope of #147.

Actually, there are no unit tests of BadgerKV (it's covered by tests of Store). You can create store/badger_test.go and add add a test for Get. To trigger error other than ErrKeyNotFound you can use !badger! as a key (see: ErrInvalidKey).

Great!

[pmareke]

I think ErrInvalidKey only works when you try to set a new block. Finally I'll use the ErrEmptyKey and ErrKeyNotFound

[pmareke]

Added tests for the Set and Delete also, now everything in badger is covered:

[tzdybal]

Looks great!

[pmareke]

Looks great!

I've just resolved conflicts as the main branch refactor the mock.go file

[tzdybal]

Looks great!

I've just resolved conflicts as the main branch refactor the mock.go file

Sorry I had to re-apply some changes on main. Let me re-resolve conflicts.

[pmareke]

Looks great!

I've just resolved conflicts as the main branch refactor the mock.go file

Sorry I had to re-apply some changes on main. Let me re-resolve conflicts.

I was taking a lot because the TestTxGossipingAndAggregation was failing and I didn't know why.