Skip to content

chore: fix some typos in comment#1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
InventiveCoder wants to merge 1 commit into from
Closed

chore: fix some typos in comment #1938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions node/full_client_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -857,15 +857,15 @@ func TestMempool2Nodes(t *testing.T) {
local := NewFullClient(node1)
require.NotNil(local)

// broadcast the bad Tx, this should not be propogated or added to the local mempool
// broadcast the bad Tx, this should not be propagated or added to the local mempool
resp, err := local.BroadcastTxSync(timeoutCtx, []byte("bad"))
assert.NoError(err)
assert.NotNil(resp)
// broadcast the good Tx, this should be propogated and added to the local mempool
// broadcast the good Tx, this should be propagated and added to the local mempool
resp, err = local.BroadcastTxSync(timeoutCtx, []byte("good"))
assert.NoError(err)
assert.NotNil(resp)
// broadcast the good Tx again in the same block, this should not be propogated and
// broadcast the good Tx again in the same block, this should not be propagated and
// added to the local mempool
resp, err = local.BroadcastTxSync(timeoutCtx, []byte("good"))
assert.Error(err)
Expand Down
2 changes: 1 addition & 1 deletion specs/lazy-adr/adr-001-node-interface.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ There are known issues related to Tendermint RPC communication.
## Replacing Tendermint `Node`

Tendermint `Node` is a struct. It's used directly in cosmos-sdk (not via interface).
We don't need to introduce common interface `Node`s, because the plan is to use scafolding tool in the feature, so we can make any required changes in cosmos-sdk.
We don't need to introduce common interface `Node`s, because the plan is to use scaffolding tool in the feature, so we can make any required changes in cosmos-sdk.

@coderabbitaicoderabbitaiBotDec 10, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix grammatical issues and typo.

The sentence has two issues:

  1. "feature" should be "future"
  2. Remove the unnecessary comma before "because"
-We don't need to introduce common interface `Node`s, because the plan is to use scaffolding tool in the feature, so we can make any required changes in cosmos-sdk.+We don't need to introduce common interface `Node`s because the plan is to use scaffolding tool in the future, so we can make any required changes in cosmos-sdk.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
We don't need to introduce common interface `Node`s, because the plan is to use scaffolding tool in the feature, so we can make any required changes in cosmos-sdk.
We don't need to introduce common interface `Node`s because the plan is to use scaffolding tool in the future, so we can make any required changes in cosmos-sdk.
🧰 Tools
🪛 LanguageTool

[formatting] ~17-~17: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...ed to introduce common interface Nodes, because the plan is to use scaffolding tool in ...

(COMMA_BEFORE_BECAUSE)

[uncategorized] ~17-~17: You might be missing the article “a” here.
Context: ...ace Nodes, because the plan is to use scaffolding tool in the feature, so we can make any...

(AI_EN_LECTOR_MISSING_DETERMINER_A)


### Interface required by cosmos-sdk

Expand Down
2 changes: 1 addition & 1 deletion types/hashing.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ func (h *Header) Hash() Hash {

// Hash returns hash of the Data
func (d *Data) Hash() Hash {
// Ignoring the marshal error for now to satify the go-header interface
// Ignoring the marshal error for now to satisfy the go-header interface
// Later on the usage of Hash should be replaced with DA commitment
dBytes, _ := d.MarshalBinary()
return merkle.HashFromByteSlices([][]byte{
Expand Down