Uh oh!
There was an error while loading. Please reload this page.
Add context to client - #20
Closed
tzdybal wants to merge 1 commit into
Closed
Conversation
liamsi
reviewed
Mar 18, 2021
| c.logger.Debug("seed", "addr", maddr.String()) | ||
| // TODO(tzdybal): configuration param for connection timeout | ||
| ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second) | ||
| ctx, cancel := context.WithTimeout(c.ctx, 3*time.Second) |
Contributor
There was a problem hiding this comment.
Should we extract 3*time.Second to some documented const or rather var?
ContributorAuthor
There was a problem hiding this comment.
I was thinking about configuration TBH, but for now I'll just use const.
liamsi
approved these changes
Mar 18, 2021
liamsi
left a comment
Contributor
There was a problem hiding this comment.
Left some nit, otherwise LGTM!
tzdybal
commented
Mar 18, 2021
ContributorAuthor
I'll fix the nit in #17. |
tzdybal
commented
Mar 18, 2021
ContributorAuthor
Actually, I'll skip this one, as the changes are already included in #17. |
This was referenced Dec 3, 2025
This was referenced Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enable control over client life-cycle, we need a context. It's also passed to libp2p layer.