chore: a few fixes by tac0turtle · Pull Request #2169 · evstack/ev-node

tac0turtle · 2025-04-12T12:43:03Z

Overview

fix batch query
add unsafe-clean cmd
fix run script
put many addresse in netinfo response

coderabbitai · 2025-04-12T12:43:10Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-04-12T12:46:36Z

Codecov Report

Attention: Patch coverage is 36.56716% with 85 lines in your changes missing coverage. Please review.

Project coverage is 27.95%. Comparing base (ef20348) to head (7a2bdb4).
Report is 16 commits behind head on feature/exec_api.

Files with missing lines	Patch %	Lines
node/full.go	41.81%	25 Missing and 7 partials ⚠️
pkg/cmd/store.go	40.00%	13 Missing and 5 partials ⚠️
pkg/cmd/p2p.go	0.00%	12 Missing ⚠️
pkg/sync/sync_service.go	0.00%	7 Missing ⚠️
pkg/p2p/client.go	0.00%	6 Missing ⚠️
types/pb/rollkit/v1/p2p_rpc.pb.go	0.00%	3 Missing ⚠️
block/manager.go	0.00%	2 Missing ⚠️
pkg/rpc/server/server.go	0.00%	2 Missing ⚠️
test/e2e/sut_helper.go	0.00%	2 Missing ⚠️
pkg/store/store.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## feature/exec_api #2169 +/- ##
====================================================
- Coverage 29.41% 27.95% -1.46% 
====================================================
Files 62 60 -2 Lines 6824 6735 -89 ====================================================
- Hits 2007 1883 -124 - Misses 4600 4620 +20 - Partials 217 232 +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

tzdybal

Looks good. I left small comment.

julienrbrt

mostly lgtm! i skipped that ListenAddress -> ListenAddresses changes as i couldn't find where all addresses were used.

julienrbrt · 2025-04-16T12:12:20Z

+	defer d.mu.Unlock()
+
+	if height > d.height {
+ return nil, da.ErrFutureHeight


maybe let's wrap this error to give more context?

github-project-automationBot added this to Evolve Apr 12, 2025

github-actionsBot assigned tac0turtle Apr 12, 2025

fix script
24ce077

tac0turtle force-pushed the marko/fix_script branch from 9d61c1c to 24ce077Compare April 12, 2025 12:43

tac0turtle added 5 commits April 12, 2025 15:56

various changes for better debugging
c0d8ef4

add unsafe-clean command
0359105

add sequencer and da to tests in ci
d243b2c

fix restart
9256426

remove extra prints
7655f59

tac0turtle force-pushed the marko/fix_script branch from 1751dd1 to 7655f59Compare April 13, 2025 18:57

tac0turtle added 3 commits April 13, 2025 20:58

fix ci
6fa3095

docs-gen
a24fb3b

store fixes
4b26990

tac0turtle force-pushed the marko/fix_script branch from f5c2573 to 4b26990Compare April 13, 2025 19:07

tac0turtle added 2 commits April 13, 2025 21:28

tt
c4f0ee0

remove unneeded test
501e368

tac0turtle changed the title ~~chore: fix run script~~chore: a few fixes Apr 14, 2025

tac0turtle marked this pull request as ready for review April 14, 2025 09:01

RollkitBot requested review from a team, MSevey, tuxcanfly and yarikbratashchuk and removed request for a teamApril 14, 2025 09:01

tac0turtle added 2 commits April 14, 2025 11:08

fix race
899bdf7

revert change
549cf3a

tac0turtle requested review from facundomedica and julienrbrt April 14, 2025 09:22

MSevey removed their request for review April 14, 2025 13:10

MSevey requested a review from tzdybal April 14, 2025 13:10

tac0turtle added 3 commits April 14, 2025 16:52

remove extra check
8dbaa17

minor change
19f760d

use previosu localda impl
bf13179

tac0turtle requested a review from Copilot April 15, 2025 09:18

CopilotAI reviewed Apr 15, 2025
View reviewed changes

Comment threadpkg/cmd/p2p.go Outdated

fix unit test
d1d103f

tac0turtle force-pushed the marko/fix_script branch from b8a2ccd to d1d103fCompare April 15, 2025 18:07

tac0turtleand others added 4 commits April 15, 2025 20:07

Merge branch 'feature/exec_api' into marko/fix_script
693427b

attempt
d9b1fe5

fix sequencer test case
fae5c44

increase timeout for da sync
d39d62c

tzdybal reviewed Apr 16, 2025
View reviewed changes

Comment threadpkg/cmd/p2p.go Outdated

tac0turtleand others added 4 commits April 16, 2025 12:44

remove check as it will never be of length 0
0ea174c

bump go header
3b1e34e

Merge branch 'feature/exec_api' into marko/fix_script
7d72902

fx after merge
bf20cea

julienrbrt approved these changes Apr 16, 2025
View reviewed changes

wrap errors
7662f1f

tac0turtle force-pushed the marko/fix_script branch from 14ca69d to 7662f1fCompare April 16, 2025 12:39

tac0turtle added 2 commits April 16, 2025 14:40

Merge branch 'feature/exec_api' into marko/fix_script
a06807e

bump badger
7a2bdb4

tac0turtle merged commit 5035cd2 into feature/exec_apiApr 16, 2025

tac0turtle deleted the marko/fix_script branch April 16, 2025 13:07

github-project-automationBot moved this to Done in Evolve Apr 16, 2025

tac0turtle removed this from Evolve Apr 24, 2025

Navigation Menu

Uh oh!

chore: a few fixes - #2169

chore: a few fixes #2169
tac0turtle merged 28 commits into
feature/exec_apifrom
marko/fix_script

tac0turtle commented Apr 12, 2025•
edited
Loading

Uh oh!

coderabbitaiBot commented Apr 12, 2025•
edited
Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecovBot commented Apr 12, 2025•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

tzdybal left a comment

Uh oh!

Uh oh!

julienrbrt left a comment

Uh oh!

julienrbrtApr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tac0turtle commented Apr 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

coderabbitaiBot commented Apr 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecovBot commented Apr 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tzdybal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

julienrbrt left a comment

Choose a reason for hiding this comment

Uh oh!

julienrbrtApr 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tac0turtle commented Apr 12, 2025•
edited
Loading

coderabbitaiBot commented Apr 12, 2025•
edited
Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecovBot commented Apr 12, 2025•
edited
Loading