Skip to content

Tendermint URI RPC - #224

Merged
tzdybal merged 11 commits into
mainfrom
tzdybal/rpc_uri
Jan 13, 2022
Merged

Tendermint URI RPC#224
tzdybal merged 11 commits into
mainfrom
tzdybal/rpc_uri

Conversation

@tzdybal

@tzdybaltzdybal commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

This PR extends RPC functionality to enable URI RPC, for compatibility with Tendermint.

Resolves#218.

@codecov-commenter

codecov-commenter commented Jan 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #224 (f56c92c) into main (a649b55) will increase coverage by 0.99%.
The diff coverage is 90.26%.

Impacted file tree graph

@@ Coverage Diff @@## main #224 +/- ##
==========================================
+ Coverage 55.60% 56.59% +0.99% 
==========================================
Files 42 42 Lines 6345 6442 +97 ==========================================
+ Hits 3528 3646 +118 + Misses 2296 2278 -18 + Partials 521 518 -3 
Impacted FilesCoverage Δ
rpc/json/types.go43.33% <ø> (+6.19%)⬆️
rpc/json/handler.go82.66% <90.00%> (+22.24%)⬆️
da/grpc/grpc.go67.85% <100.00%> (ø)
rpc/json/service.go52.33% <100.00%> (+7.47%)⬆️
rpc/client/client.go29.30% <0.00%> (+2.09%)⬆️
store/store.go73.83% <0.00%> (+5.60%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a649b55...f56c92c. Read the comment docs.

@tzdybaltzdybal changed the title Backward compatible Tendermint RPCTendermint URI RPCJan 11, 2022
@tzdybal
tzdybal marked this pull request as ready for review January 11, 2022 22:35
@tzdybal
tzdybal requested a review from mattdfJanuary 11, 2022 22:35

@adlerjohnadlerjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I test this PR?

Comment threadrpc/json/handler.go Outdated
@tzdybal

Copy link
Copy Markdown
ContributorAuthor

Manual testing requires cosmos-sdk app to be running. I can update demochain if you want to test this manually.
We need to create end-to-end testing suite.

@adlerjohnadlerjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have more instructions somewhere to know how to manually test these things. utACK

@tzdybal

Copy link
Copy Markdown
ContributorAuthor

I assume "utACK" means "unit tested, ACK" ;)

@adlerjohn

Copy link
Copy Markdown
Contributor

No, it means untested ACK, which is about the same as unit tested 😂

@tzdybal
tzdybal merged commit 7c42e2d into mainJan 13, 2022
@tzdybal
tzdybal deleted the tzdybal/rpc_uri branch January 13, 2022 14:59
@assafmoassafmo mentioned this pull request Jul 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Tendermint URI RPC

3 participants

@tzdybal@codecov-commenter@adlerjohn