Uh oh!
There was an error while loading. Please reload this page.
fix: evm single docker compose startup - #2455
Conversation
WalkthroughThis update introduces a 5-second startup delay at the beginning of the entrypoint script and explicitly sets the container command to Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DockerCompose
participant Container
participant EntrypointScript
User->>DockerCompose: Launch rollkit-evm-single service
DockerCompose->>Container: Start container with entrypoint.sh and command 'start'
Container->>EntrypointScript: Run entrypoint.sh
EntrypointScript->>EntrypointScript: Sleep 5 seconds
EntrypointScript->>EntrypointScript: Continue startup process
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).
|
There was a problem hiding this comment.
Summary of Changes
Hello @auricom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to resolve a critical startup issue within the evm single docker compose environment where the rollkit container was crashing due to improper startup orchestration. The changes ensure a more robust and reliable initialization sequence for the services, allowing them to come online in the correct order and preventing premature connection attempts.
Highlights
- Docker Compose Configuration: I've explicitly added the
command: startinstruction to theevm-singleservice indocker-compose.yml. This ensures the container executes the intended startup command defined in its entrypoint script. - Startup Orchestration Delay: I've introduced a 5-second
sleepat the beginning of theentrypoint.shscript for theevm-singlecontainer. This delay is crucial to allow dependent services, such asrollkit-reth, sufficient time to fully initialize beforeevm-singleattempts to connect to them, preventing startup crashes. - Script Formatting: I've addressed a minor formatting issue in
entrypoint.shby ensuring the file ends with a newline character.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a startup orchestration issue in the EVM single-node docker-compose setup by adding the start command. My review focuses on improving the robustness of service dependency handling. I've identified that using a fixed sleep to wait for other services is fragile and can lead to intermittent failures. I've suggested replacing it with an active polling mechanism using curl to ensure services are ready before proceeding. This will make the startup process more reliable.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/evm/single/entrypoint.sh (1)
4-5: Parameterize the startup delay instead of hard-coding 5 sA fixed sleep may still race with slow hosts or needlessly stall on fast ones. Prefer an env-driven or dependency-aware wait:
-# crude fixed delay-sleep 5+# configurable (defaults to 5 s) – override with STARTUP_DELAY or set to 0 to skip+sleep "${STARTUP_DELAY:-5}"Even better, replace the delay entirely with Docker-Compose health-checks (
depends_on: condition: service_healthy) or a small “wait-for” helper that polls the Reth / DA endpoints.apps/evm/single/docker-compose.yml (1)
64-64: Use list syntax for single-word command for YAML clarityWhile
command: startworks, the array form is less error-prone and avoids implicit string parsing by Compose:- command: start+ command: ["start"]Minor readability win; feel free to ignore if you prefer the scalar style.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/evm/single/docker-compose.yml(1 hunks)apps/evm/single/entrypoint.sh(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: tzdybal
PR: rollkit/rollkit#1641
File: node/full_node_test.go:266-321
Timestamp: 2024-06-10T19:23:16.839Z
Learning: Issue #1663 was created to address adding comprehensive tests for error scenarios in `TestVoteExtension` in the rollkit repository.
Learnt from: tzdybal
PR: rollkit/rollkit#1641
File: node/full_node_test.go:266-321
Timestamp: 2024-10-08T18:35:32.960Z
Learning: Issue #1663 was created to address adding comprehensive tests for error scenarios in `TestVoteExtension` in the rollkit repository.
Learnt from: chatton
PR: rollkit/rollkit#2378
File: test/docker-e2e/base_test.go:22-32
Timestamp: 2025-06-18T12:52:25.919Z
Learning: In the rollkit codebase test/docker-e2e, the StartBridgeNode and StartRollkitNode methods in DockerTestSuite do not return errors. They handle error checking internally using s.Require().NoError(err) for their operations, so no external error handling is needed when calling these methods.
Learnt from: chatton
PR: rollkit/rollkit#2378
File: test/docker-e2e/base_test.go:22-32
Timestamp: 2025-06-18T12:52:25.919Z
Learning: In the rollkit codebase test/docker-e2e, the StartBridgeNode and StartRollkitNode methods in DockerTestSuite do not return errors, so no error handling is needed when calling these methods.
apps/evm/single/docker-compose.yml (1)
Learnt from: chatton
PR: rollkit/rollkit#2378
File: test/docker-e2e/base_test.go:22-32
Timestamp: 2025-06-18T12:52:25.919Z
Learning: In the rollkit codebase test/docker-e2e, the StartBridgeNode and StartRollkitNode methods in DockerTestSuite do not return errors, so no error handling is needed when calling these methods.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: lint / markdown-lint
- GitHub Check: test / Build All Rollkit Binaries
- GitHub Check: test / Run Unit Tests
- GitHub Check: test / Run Integration Tests
- GitHub Check: test / Build Rollkit Docker Image
- GitHub Check: test / Build Rollkit EVM Single Docker Image
- GitHub Check: Summary
- GitHub Check: Analyze (rust)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
apps/evm/single/entrypoint.sh (1)
107-107: No issues – newline only
The trailing newline keeps POSIX shells happy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #2455 +/- ##
==========================================
- Coverage 73.20% 73.09% -0.11%
==========================================
Files 68 68 Lines 6542 6542 ==========================================
- Hits 4789 4782 -7 - Misses 1357 1362 +5 - Partials 396 398 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rollkit container was crashing because of wrong startup orchestration. This PR fixes it.
Summary by CodeRabbit