Skip to content

fix: Modify Max DA blob size slightly lower#2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manav-Aggarwal merged 2 commits into from
Aug 11, 2025
Merged

fix: Modify Max DA blob size slightly lower #2558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a49d656
Modify max blob size slightly
Manav-Aggarwal Aug 11, 2025
9ee6cde
change some logs from info to debug
Manav-Aggarwal Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions block/submitter.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,7 +381,7 @@ func handleTooBigError[T any](
attempt int,
namespace []byte,
) submissionOutcome[T] {
m.logger.Warn().Str("error", "blob too big").Int("attempt", attempt).Int("batchSize", len(remaining)).Msg("DA layer submission failed due to blob size limit")
m.logger.Debug().Str("error", "blob too big").Int("attempt", attempt).Int("batchSize", len(remaining)).Msg("DA layer submission failed due to blob size limit")

m.recordDAMetrics("submission", DAModeFail)

Expand DownExpand Up@@ -511,7 +511,7 @@ func submitWithRecursiveSplitting[T any](
}

// Split and submit recursively - we know the batch is too big
m.logger.Info().Int("batchSize", len(items)).Msg("splitting batch for recursive submission")
m.logger.Debug().Int("batchSize", len(items)).Msg("splitting batch for recursive submission")

splitPoint := len(items) / 2
// Ensure we actually split (avoid infinite recursion)
Expand All@@ -523,7 +523,7 @@ func submitWithRecursiveSplitting[T any](
firstHalfMarshaled := marshaled[:splitPoint]
secondHalfMarshaled := marshaled[splitPoint:]

m.logger.Info().Int("originalSize", len(items)).Int("firstHalf", len(firstHalf)).Int("secondHalf", len(secondHalf)).Msg("splitting batch for recursion")
m.logger.Debug().Int("originalSize", len(items)).Int("firstHalf", len(firstHalf)).Int("secondHalf", len(secondHalf)).Msg("splitting batch for recursion")

// Recursively submit both halves using processBatch directly
firstSubmitted, err := submitHalfBatch[T](m, ctx, firstHalf, firstHalfMarshaled, gasPrice, postSubmit, itemType, namespace)
Expand DownExpand Up@@ -645,7 +645,7 @@ func processBatch[T any](

if batchRes.Code == coreda.StatusTooBig && len(batch.Items) > 1 {
// Batch is too big - let the caller handle splitting
m.logger.Info().Int("batchSize", len(batch.Items)).Msg("batch too big, returning to caller for splitting")
m.logger.Debug().Int("batchSize", len(batch.Items)).Msg("batch too big, returning to caller for splitting")
return batchResult[T]{action: batchActionTooBig}
}

Expand Down
2 changes: 1 addition & 1 deletion da/cmd/local-da/local.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ import (
)

// DefaultMaxBlobSize is the default max blob size
const DefaultMaxBlobSize = 64 * 64 * 482
const DefaultMaxBlobSize uint64 = 64 * 64 * 481 // 1970176

@gemini-code-assistgemini-code-assistBotAug 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The calculation for DefaultMaxBlobSize duplicates the logic for DefaultMaxBytes found in da/jsonrpc/internal/consts.go. To improve maintainability and ensure a single source of truth for this critical value, consider reusing the appconsts.DefaultMaxBytes constant here. This would prevent potential inconsistencies if the value needs to be updated in the future.

Reusing the constant would require importing the appconsts package.


// LocalDA is a simple implementation of in-memory DA. Not production ready! Intended only for testing!
//
Expand Down
4 changes: 2 additions & 2 deletions da/jsonrpc/internal/consts.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,8 +14,8 @@ const (
DefaultGovMaxSquareSize = 64

// DefaultMaxBytes is the default value for the governance modifiable
// maximum number of bytes allowed in a valid block.
DefaultMaxBytes = DefaultGovMaxSquareSize * DefaultGovMaxSquareSize * share.ContinuationSparseShareContentSize
// maximum number of bytes allowed in a valid block. We subtract 1 to have some extra buffer.

@tac0turtletac0turtleAug 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay unchanged. It's a copy of app. The git action will fail unless upstream has this change

DefaultMaxBytes = DefaultGovMaxSquareSize * DefaultGovMaxSquareSize * (share.ContinuationSparseShareContentSize - 1)

// DefaultMinGasPrice is the default min gas price that gets set in the app.toml file.
// The min gas price acts as a filter. Transactions below that limit will not pass
Expand Down
8 changes: 7 additions & 1 deletion types/da.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,13 @@ func SubmitWithHelpers(
case errors.Is(err, coreda.ErrContextDeadline):
status = coreda.StatusContextDeadline
}
logger.Error().Err(err).Uint64("status", uint64(status)).Msg("DA submission failed via helper")

// Use debug level for StatusTooBig as it gets handled later in submitToDA through recursive splitting
if status == coreda.StatusTooBig {
logger.Debug().Err(err).Uint64("status", uint64(status)).Msg("DA submission failed via helper")
} else {
logger.Error().Err(err).Uint64("status", uint64(status)).Msg("DA submission failed via helper")
}
return coreda.ResultSubmit{
BaseResult: coreda.BaseResult{
Code: status,
Expand Down
Loading