Skip to content

chore: prep evm rc.5#3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 1 commit into from
Mar 9, 2026
Merged

chore: prep evm rc.5 #3145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## v1.0.0-rc.5 / v1.0.0
## v1.0.0

Identical to v1.0.0-rc.5.

## v1.0.0-rc.5

### Added

Expand Down
8 changes: 5 additions & 3 deletions apps/evm/go.mod
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,16 @@ module github.com/evstack/ev-node/apps/evm

go 1.25.6

//github.com/evstack/ev-node => ../../
replace github.com/evstack/ev-node/execution/evm => ../../execution/evm
//replace (
// github.com/evstack/ev-node => ../../
// github.com/evstack/ev-node/execution/evm => ../../execution/evm
//)

require (
github.com/ethereum/go-ethereum v1.17.0
github.com/evstack/ev-node v1.0.0-rc.5
github.com/evstack/ev-node/core v1.0.0
github.com/evstack/ev-node/execution/evm v1.0.0-rc.3
github.com/evstack/ev-node/execution/evm v1.0.0-rc.4
Comment on lines +5 to +14

@coderabbitaicoderabbitaiBotMar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bashset -euo pipefail
echo"== apps/evm/go.mod =="
sed -n '1,25p' apps/evm/go.mod
echoecho"== execution/evm/go.mod =="
sed -n '1,20p' execution/evm/go.mod
echoecho"== workspace files =="
fd '^go\.work(\.example)?$' -a
echoecho"== version pins for ev-node/execution/evm across go.mod files =="
rg -n --glob 'go.mod''github\.com/evstack/ev-node/execution/evm v'

Repository: evstack/ev-node

Length of output: 1873

Align apps/evm with the rc.5 execution module before cutting this release.

Line 14 pins github.com/evstack/ev-node/execution/evm to v1.0.0-rc.4 while this module already depends on github.com/evstack/ev-node v1.0.0-rc.5. With the local replace block disabled (lines 5-8), apps/evm will resolve the published rc.4 execution module instead of the in-repo sibling, causing this PR to be built and validated against older execution code than the release describes.

Suggested fix
-//replace (-//	github.com/evstack/ev-node => ../../-//	github.com/evstack/ev-node/execution/evm => ../../execution/evm-//)+replace (+	github.com/evstack/ev-node => ../../+	github.com/evstack/ev-node/execution/evm => ../../execution/evm+)
@@
-	github.com/evstack/ev-node/execution/evm v1.0.0-rc.4+	github.com/evstack/ev-node/execution/evm v1.0.0-rc.5

If v1.0.0-rc.5 is not published yet, keep the local replace active until it is.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/evm/go.mod` around lines 5 - 14, The go.mod currently requires
github.com/evstack/ev-node v1.0.0-rc.5 but pins
github.com/evstack/ev-node/execution/evm at v1.0.0-rc.4; re-align them by either
updating the execution/evm require to v1.0.0-rc.5 or, if v1.0.0-rc.5 isn’t
published yet, re-enable the local replace block that points
github.com/evstack/ev-node and github.com/evstack/ev-node/execution/evm to the
sibling workspace so the module builds against the in-repo rc.5 execution code.

github.com/ipfs/go-datastore v0.9.1
github.com/rs/zerolog v1.34.0
github.com/spf13/cobra v1.10.2
Expand Down
2 changes: 2 additions & 0 deletions apps/evm/go.sum
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -411,6 +411,8 @@ github.com/evstack/ev-node v1.0.0-rc.5 h1:3qd3KWuwiLr5RKt1j8v2h5X3XZvwyYGbMUDskM
github.com/evstack/ev-node v1.0.0-rc.5/go.mod h1:VAaN0tbN1+SSm7sLzMhHZNUn9sgpf1eok5gu3YVbT38=
github.com/evstack/ev-node/core v1.0.0 h1:s0Tx0uWHme7SJn/ZNEtee4qNM8UO6PIxXnHhPbbKTz8=
github.com/evstack/ev-node/core v1.0.0/go.mod h1:n2w/LhYQTPsi48m6lMj16YiIqsaQw6gxwjyJvR+B3sY=
github.com/evstack/ev-node/execution/evm v1.0.0-rc.4 h1:9IKEVD8QRe6drXJFxnydM5ao6Gw5BPgXXIVCY3516WM=
github.com/evstack/ev-node/execution/evm v1.0.0-rc.4/go.mod h1:aDwQRKH79c49eBgGAkkTPJKSicRxGtxteSqmj0oqAQ4=
github.com/fatih/color v1.10.0/go.mod h1:ELkj/draVOlAH/xkhN6mQ50Qd0MPOk5AAr3maGEBuJM=
github.com/fatih/color v1.13.0/go.mod h1:kLAiJbzzSOZDVNGyDpeOxJ47H46qBXwg5ILebYFFOfk=
github.com/fatih/color v1.15.0/go.mod h1:0h5ZqXfHYED7Bhv2ZJamyIOUej9KtShiJESRwBDUSsw=
Expand Down
Loading