Skip to content

build(deps): Bump docker/build-push-action from 6 to 7 - #3151

Merged
julienrbrt merged 2 commits into
mainfrom
dependabot/github_actions/main/docker/build-push-action-7
Mar 10, 2026
Merged

build(deps): Bump docker/build-push-action from 6 to 7#3151
julienrbrt merged 2 commits into
mainfrom
dependabot/github_actions/main/docker/build-push-action-7

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMar 9, 2026

Copy link
Copy Markdown
Contributor

Bumps docker/build-push-action from 6 to 7.

Release notes

Sourced from docker/build-push-action's releases.

v7.0.0

Full Changelog: docker/build-push-action@v6.19.2...v7.0.0

v6.19.2

Full Changelog: docker/build-push-action@v6.19.1...v6.19.2

v6.19.1

Full Changelog: docker/build-push-action@v6.19.0...v6.19.1

v6.19.0

Full Changelog: docker/build-push-action@v6.18.0...v6.19.0

v6.18.0

[!NOTE] Build summary is now supported with Docker Build Cloud.

Full Changelog: docker/build-push-action@v6.17.0...v6.18.0

v6.17.0

[!NOTE] Build record is now exported using the buildx history export command instead of the legacy export-build tool.

Full Changelog: docker/build-push-action@v6.16.0...v6.17.0

v6.16.0

... (truncated)

Commits
  • d08e5c3 Merge pull request #1479 from docker/dependabot/npm_and_yarn/docker/actions-t...
  • cbd2dff chore: update generated content
  • f76f51f chore(deps): Bump @​docker/actions-toolkit from 0.78.0 to 0.79.0
  • 7d03e66 Merge pull request #1473 from crazy-max/rm-deprecated-envs
  • 98f853d chore: update generated content
  • cadccf6 remove deprecated envs
  • 03fe877 Merge pull request #1478 from docker/dependabot/github_actions/docker/setup-b...
  • 827e366 chore(deps): Bump docker/setup-buildx-action from 3 to 4
  • e25db87 Merge pull request #1474 from crazy-max/rm-export-build-tool
  • 1ac2573 Merge pull request #1470 from crazy-max/node24
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6 to 7.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v6...v7)
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-version: '7'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@claude

claudeBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Claude finished @julienrbrt's task in 1m 24s —— View job


PR Review

  • Gather context
  • Review changed files
  • Check CI status
  • Post review feedback

Summary

This PR contains two distinct changes:

  1. Dependabot bump: docker/build-push-action v6 → v7 across 3 workflow files
  2. Flaky test fix (types/state_test.go): Refactors the "last header hash mismatch" test cases to handle stateful grace period logic

Workflow Changes (.github/workflows/*.yml)

The v6→v7 bump is straightforward. Notable v7 changes to be aware of:

  • Node 24 runtime — requires Actions Runner v2.327.1+. Worth confirming self-hosted runners (if any) are on a compatible version.
  • Removal of deprecated DOCKER_BUILD_NO_SUMMARY and DOCKER_BUILD_EXPORT_RETENTION_DAYS env vars — no action needed unless those are set somewhere in your workflows (they are not in this repo).

No issues found here.


Test Refactor (types/state_test.go)

The fix is correct and well-motivated. The comment explains the reasoning clearly:

// The last-header-hash grace period is stateful: the first mismatch is// tolerated (based-sequencer transition), the second is an error.// These two calls must run in order on the same global state, so they// cannot be independent map entries.

Moving the two cases out of the unordered map into a sequential t.Run sub-test properly expresses the ordering dependency. Good fix.


Underlying Concern in types/state.go (not introduced by this PR, but worth noting)

The grace-period logic relies on package-level globals:

// types/state.go:70-73var (
basedSequencerTracking sync.OncelastHeaderHashErrCount=0
)

This has several design issues worth tracking:

  1. Shared across all State instances: All nodes in the same process share a single sync.Once + counter. In multi-node test scenarios (e.g., just run-n 3) or tests that create multiple State objects, the first based-sequencer transition anywhere in the process permanently exhausts the grace period for all other instances.

  2. sync.Once is not resettable: Once fired, the grace is consumed for the process lifetime. There's no way to reset it, making this logic brittle in long-running nodes that go through multiple sequencer transitions.

  3. Race condition potential: lastHeaderHashErrCount is read at line 97 without holding a lock, while sync.Once protects the write at line 101-103. The read at if lastHeaderHashErrCount == 1 is technically a data race if called concurrently, since sync.Once only prevents the write from running twice — it doesn't synchronize the read.

The test fix is the right short-term move. A follow-up refactor to move this state onto the State struct itself (or use an atomic) would make the code more robust.


Verdict

Approve: The action version bump is clean, the test fix correctly resolves the flakiness. The underlying state.go globals are pre-existing and out of scope for this PR.

@julienrbrt
julienrbrt merged commit 5fd8236 into mainMar 10, 2026
18 of 21 checks passed
@julienrbrt
julienrbrt deleted the dependabot/github_actions/main/docker/build-push-action-7 branch March 10, 2026 08:01
Comment thread.github/workflows/docker-build-push.yml Dismissed
Comment thread.github/workflows/release-apps.yml Dismissed
Comment thread.github/workflows/test.yml Dismissed
@github-actions

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedMar 10, 2026, 8:02 AM

@codecov

codecovBot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.23%. Comparing base (87d8ba9) to head (28cf22b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3151 +/- ##
=======================================
Coverage 60.23% 60.23% =======================================
Files 115 115 Lines 11899 11899 =======================================
Hits 7167 7167 Misses 3922 3922 Partials 810 810 
FlagCoverage Δ
combined60.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alpe added a commit that referenced this pull request Mar 11, 2026
* main:
fix: persist snapshot once for avoiding badger vlog (#3153)
build(deps): Bump docker/setup-buildx-action from 3 to 4 (#3148)
build(deps): Bump the all-go group across 5 directories with 8 updates (#3147)
build(deps): Bump docker/login-action from 3 to 4 (#3149)
build(deps): Bump docker/build-push-action from 6 to 7 (#3151)
build(deps): Bump actions/setup-go from 6.2.0 to 6.3.0 (#3150)
alpe added a commit that referenced this pull request Mar 16, 2026
* main:
fix(syncer): include in-flight and pending-cache work in PendingCount (#3162)
chore: re-add replaces for development (#3161)
build(deps): Bump quinn-proto from 0.11.13 to 0.11.14 in the cargo group across 1 directory (#3155)
build(deps): bump execution/evm (#3160)
build(deps): bump ev-node (#3159)
chore: remove replaces from ev-node (#3158)
chore: fix some function names in comment (#3156)
fix: persist snapshot once for avoiding badger vlog (#3153)
build(deps): Bump docker/setup-buildx-action from 3 to 4 (#3148)
build(deps): Bump the all-go group across 5 directories with 8 updates (#3147)
build(deps): Bump docker/login-action from 3 to 4 (#3149)
build(deps): Bump docker/build-push-action from 6 to 7 (#3151)
build(deps): Bump actions/setup-go from 6.2.0 to 6.3.0 (#3150)
chore: prep evm rc.5 (#3145)
build(deps): bump ev-node (#3144)
feat(block): Event-Driven DA Follower with WebSocket Subscriptions (#3131)
build(deps): Bump dompurify from 3.2.6 to 3.3.2 in /docs in the npm_and_yarn group across 1 directory (#3140)
feat(benchmarking): adding gas burner test (#3115)
chore: minor deduplication (#3139)
refactor(store,cache)!: optimize cache restore as O(1) (#3134)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@julienrbrt@github-advanced-security