Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Guard against uint64→Duration overflow edge case.
time.Duration(readinessWindowSeconds) * time.Secondcan wrap to a negativemaxAllowedDelayifReadinessWindowSecondsexceedsint64nanosecond capacity (~292 years), causing permanentUNREADY. Add an upper-bound check or saturate before conversion.readinessWindowSeconds := cfg.Node.ReadinessWindowSeconds if readinessWindowSeconds == 0 { readinessWindowSeconds = 15 // fallback to default 15s window } + const maxReadinessWindowSeconds = uint64(292 * 365 * 24 * 60 * 60) // ~292 years+ if readinessWindowSeconds > maxReadinessWindowSeconds {+ readinessWindowSeconds = maxReadinessWindowSeconds+ } maxAllowedDelay := time.Duration(readinessWindowSeconds) * time.Second📝 Committable suggestion
🤖 Prompt for AI Agents