Skip to content

Bring back address conversion method - #40

Merged
tzdybal merged 4 commits into
mainfrom
tzdybal/addr_conversion
Apr 21, 2021
Merged

Bring back address conversion method#40
tzdybal merged 4 commits into
mainfrom
tzdybal/addr_conversion

Conversation

@tzdybal

Copy link
Copy Markdown
Contributor

This is the easiest, non-obstructive method to enable running cosmos-sdk tests with optimint.

@tzdybaltzdybal added the T:testing Related to testing label Apr 19, 2021
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #40 (34e2794) into main (a1820ca) will increase coverage by 1.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## main #40 +/- ##
==========================================
+ Coverage 59.54% 61.05% +1.50% 
==========================================
Files 10 11 +1 Lines 749 778 +29 ==========================================
+ Hits 446 475 +29 
Misses 251 251 Partials 52 52 
Impacted FilesCoverage Δ
conv/addr.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1820ca...34e2794. Read the comment docs.

@tzdybaltzdybal mentioned this pull request Apr 21, 2021
@tzdybal
tzdybal marked this pull request as ready for review April 21, 2021 09:01

@liamsiliamsi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Look good (and familiar)

This is the easiest, non-obstructive method to enable running cosmos-sdk
tests with optimint.
@tzdybal
tzdybalforce-pushed the tzdybal/addr_conversion branch from 611ba4d to 40d3c2fCompareApril 21, 2021 10:36
@tzdybal
tzdybal merged commit 3f22ee1 into mainApr 21, 2021
@tzdybal
tzdybal deleted the tzdybal/addr_conversion branch May 2, 2023 19:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:testingRelated to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tzdybal@codecov-commenter@liamsi