Uh oh!
There was an error while loading. Please reload this page.
replaced [8]byte with types.NamespaceID - #554
Merged
Merged
Conversation
tzdybal
suggested changes
Oct 10, 2022
tzdybal
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your submission! It looks really good.
Please fix the failing unit tests.
tzdybal
self-requested a review
October 10, 2022 21:13
randomshinichiforce-pushed
the
typenamespaceid
branch
from
October 11, 2022 12:23
7b8ead6 to
a593048CompareContributorAuthor
Thanks! Just fixed the unittest, should work now (tested locally) |
tzdybal
approved these changes
Oct 13, 2022
nashqueue
suggested changes
Oct 13, 2022
nashqueue
left a comment
Contributor
There was a problem hiding this comment.
Looks good :) Why are 4 Tests skipped in github?
nashqueue
approved these changes
Oct 13, 2022
tzdybal
commented
Oct 13, 2022
Contributor
Those tests are skipped for PRs from forks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think naming the new type NamespaceID is straightforward and requires no further explanation.
Let me know if I missed something - the go compiler likes it just fine