Skip to content

added contexts to Celestia DataAvailabilityLayerClient - #623

Merged
tzdybal merged 27 commits into
mainfrom
connor/contexts
Dec 19, 2022
Merged

added contexts to Celestia DataAvailabilityLayerClient#623
tzdybal merged 27 commits into
mainfrom
connor/contexts

Conversation

@S1nus

@S1nusS1nus commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Overview

Adding Context parameters to the CheckBlockAvailability, SubmitBlock, and RetrieveBlocks functions of the DataAvailabilityLayerClient object. Work-in-progress.

Goal is to enable requests to be cancelled easily, or allow them to have deadlines.

Resolves#354.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Comment threadda/celestia/celestia.go Outdated
Comment threadda/celestia/celestia.go Outdated
Comment threadda/celestia/celestia.go Outdated
Comment threadda/da.go Outdated
Comment threadda/da.go Outdated
Comment threadda/da.go Outdated
Connor O'Haraand others added 10 commits November 22, 2022 15:00
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
@codecov-commenter

codecov-commenter commented Nov 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #623 (aa4d548) into main (d5e63f9) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #623 +/- ##
==========================================
- Coverage 55.59% 55.46% -0.14% 
==========================================
Files 50 50 Lines 10301 10301 ==========================================
- Hits 5727 5713 -14 - Misses 3714 3723 +9 - Partials 860 865 +5 
Impacted FilesCoverage Δ
block/manager.go65.34% <100.00%> (-3.47%)⬇️
da/celestia/celestia.go50.00% <100.00%> (ø)
da/celestia/mock/server.go50.32% <100.00%> (ø)
da/grpc/grpc.go73.13% <100.00%> (ø)
da/grpc/mockserv/mockserv.go81.63% <100.00%> (ø)
da/mock/mock.go79.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tzdybal
tzdybal removed the request for review from WondertanNovember 30, 2022 20:38
@S1nus
S1nus requested a review from a teamNovember 30, 2022 20:46
@S1nus
S1nus marked this pull request as ready for review November 30, 2022 20:47

@tzdybaltzdybal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but applies in multiple places - please rename variable from context to ctx.

Comment threadda/grpc/grpc.go Outdated
Comment threadda/grpc/grpc.go Outdated
Comment threadda/grpc/grpc.go Outdated
Comment threadda/mock/mock.go Outdated
Comment threadda/grpc/mockserv/cmd/.gitignore Outdated

@tzdybaltzdybal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left small comment regarding tests. Please rebase.

Comment threadda/test/da_test.go Outdated
Comment threadda/test/da_test.go Outdated

@tzdybaltzdybal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzdybal
tzdybal enabled auto-merge (squash) December 19, 2022 14:05
@tzdybal
tzdybal merged commit d705b0d into mainDec 19, 2022
@tzdybal
tzdybal deleted the connor/contexts branch December 19, 2022 14:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add context to DA interfaces

4 participants

@S1nus@codecov-commenter@tzdybal@nashqueue