Uh oh!
There was an error while loading. Please reload this page.
added contexts to Celestia DataAvailabilityLayerClient - #623
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Codecov Report
@@ Coverage Diff @@## main #623 +/- ##
==========================================
- Coverage 55.59% 55.46% -0.14%
==========================================
Files 50 50 Lines 10301 10301 ==========================================
- Hits 5727 5713 -14 - Misses 3714 3723 +9 - Partials 860 865 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tzdybal
left a comment
There was a problem hiding this comment.
One comment, but applies in multiple places - please rename variable from context to ctx.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tzdybal
left a comment
There was a problem hiding this comment.
Looks good. I left small comment regarding tests. Please rebase.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Overview
Adding
Contextparameters to theCheckBlockAvailability,SubmitBlock, andRetrieveBlocksfunctions of theDataAvailabilityLayerClientobject. Work-in-progress.Goal is to enable requests to be cancelled easily, or allow them to have deadlines.
Resolves#354.
Checklist