Skip to content

Integration with go-header - #685

Merged
tzdybal merged 4 commits into
mainfrom
tzdybal/go-header
Jan 17, 2023
Merged

Integration with go-header#685
tzdybal merged 4 commits into
mainfrom
tzdybal/go-header

Conversation

@tzdybal

@tzdybaltzdybal commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Overview

Resolves#641.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tzdybaltzdybal self-assigned this Jan 12, 2023
@tzdybal
tzdybal marked this pull request as ready for review January 16, 2023 14:47
@tzdybal
tzdybal requested review from a team, S1nus and tuxcanfly and removed request for a teamJanuary 16, 2023 14:47
S1nus
S1nus previously approved these changes Jan 16, 2023
Comment threadtypes/header.go
Comment threadtypes/header.go
Comment threadtypes/header.go
Comment threadtypes/header.go
Comment threadstore/store.go
Comment threadtypes/header.go

@nashqueuenashqueue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzdybal
tzdybal enabled auto-merge (squash) January 17, 2023 15:10
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #685 (13d0ad6) into main (e5ec6a8) will decrease coverage by 0.52%.
The diff coverage is 45.12%.

@@ Coverage Diff @@## main #685 +/- ##
==========================================
- Coverage 55.02% 54.51% -0.52% 
==========================================
Files 48 49 +1 Lines 10224 10305 +81 ==========================================
- Hits 5626 5618 -8 - Misses 3732 3818 +86 - Partials 866 869 +3 
Impacted FilesCoverage Δ
types/validation.go37.20% <0.00%> (-12.80%)⬇️
types/header.go6.89% <6.89%> (ø)
store/store.go60.89% <80.00%> (-0.50%)⬇️
state/executor.go69.17% <85.00%> (-0.59%)⬇️
block/manager.go65.34% <100.00%> (-0.75%)⬇️
conv/abci/block.go94.33% <100.00%> (ø)
da/mock/mock.go73.75% <100.00%> (ø)
rpc/client/client.go50.07% <100.00%> (-0.22%)⬇️
types/hashing.go100.00% <100.00%> (ø)
types/serialization.go69.93% <100.00%> (+0.75%)⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gupadhyayagupadhyaya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tzdybal
tzdybal merged commit d8679cc into mainJan 17, 2023
@tzdybal
tzdybal deleted the tzdybal/go-header branch January 17, 2023 17:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Header interface

5 participants

@tzdybal@codecov-commenter@S1nus@gupadhyaya@nashqueue