Skip to content

Remove namespace ID from header - #718

Merged
Manav-Aggarwal merged 3 commits into
mainfrom
manav/remove_namespace_id_from_header
Jan 26, 2023
Merged

Remove namespace ID from header#718
Manav-Aggarwal merged 3 commits into
mainfrom
manav/remove_namespace_id_from_header

Conversation

@Manav-Aggarwal

@Manav-AggarwalManav-Aggarwal commented Jan 26, 2023

Copy link
Copy Markdown
Member

Closes: #690.

@Manav-AggarwalManav-Aggarwal linked an issue Jan 26, 2023 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Jan 26, 2023

Copy link
Copy Markdown

Codecov Report

Base: 55.07% // Head: 55.07% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e1a4a81) compared to base (a1643e1).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## main #718 +/- ##
=======================================
Coverage 55.07% 55.07% =======================================
Files 52 52 Lines 9851 9792 -59 =======================================
- Hits 5425 5393 -32 + Misses 3618 3599 -19 + Partials 808 800 -8 
Impacted FilesCoverage Δ
state/executor.go64.73% <ø> (-0.09%)⬇️
types/header.go7.59% <ø> (ø)
types/serialization.go75.41% <ø> (+1.41%)⬆️
types/pb/rollkit/rollkit.pb.go40.39% <100.00%> (-0.15%)⬇️
rpc/json/ws.go58.73% <0.00%> (-3.18%)⬇️
block/manager.go63.12% <0.00%> (-0.68%)⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Manav-Aggarwal
Manav-Aggarwal marked this pull request as ready for review January 26, 2023 07:06
@Manav-AggarwalManav-Aggarwal self-assigned this Jan 26, 2023
@Manav-Aggarwal
Manav-Aggarwal requested review from a team, S1nus, gupadhyaya, nashqueue and tuxcanfly and removed request for a teamJanuary 26, 2023 07:19
@nashqueue

Copy link
Copy Markdown
Contributor

Does this close the whole epic #579 ?

@tzdybal

tzdybal commented Jan 26, 2023

Copy link
Copy Markdown
Contributor

Does this close the whole epic #579 ?

No. It's 3rd out of 9 tasks, and we probably will create even more. Fixed in the first comment.

@Manav-Aggarwal
Manav-Aggarwal merged commit b82de97 into mainJan 26, 2023
@Manav-Aggarwal
Manav-Aggarwal deleted the manav/remove_namespace_id_from_header branch January 26, 2023 16:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider removing NamespaceID from header

4 participants

@Manav-Aggarwal@codecov-commenter@nashqueue@tzdybal