Uh oh!
There was an error while loading. Please reload this page.
fork-choice interface - #767
Conversation
gupadhyaya
commented
Mar 10, 2023
@S1nus i think you will have to use default FCR in all the tests that create newFullNode. otherwise, there won't be any FCR, hence leading to nil pointer error. |
S1nus
commented
Mar 16, 2023
Newest commit changes FCRs from a function signature to an interface type. Certain schemes will want to have state, hence why it makes sense to represent the FCR as a struct. There might also be other functions besides |
S1nus
commented
Mar 16, 2023
another idea: the fork-choice rule configuration option may be better suited as a parameter in the genesis block, rather than Rollkit's config |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@## main #767 +/- ##
==========================================
+ Coverage 54.99% 55.08% +0.08%
==========================================
Files 54 56 +2 Lines 9904 9927 +23 ==========================================
+ Hits 5447 5468 +21 - Misses 3662 3663 +1 - Partials 795 796 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| fcr, ok := fork_choice.GetRule(conf.ForkChoiceRule) | ||
| if !ok { | ||
| fcr, ok = fork_choice.GetRule(config.DefaultNodeConfig.BlockManagerConfig.ForkChoiceRule) |
There was a problem hiding this comment.
multiple calls to GetRule is not needed. when !ok simply assign firstOrderedPure to fcr?
| "hash", block.Hash(), | ||
| ) | ||
| m.syncCache[block.SignedHeader.Header.BaseHeader.Height] = block | ||
| if m.syncCache[block.SignedHeader.Header.BaseHeader.Height] == nil { |
There was a problem hiding this comment.
height := block.SignedHeader.Header.BaseHeader.Height and use height in multiple places
Uh oh!
There was an error while loading. Please reload this page.
…nnor/fork-choice-interface
95b08e7 to
8f01985CompareS1nus
commented
Jun 7, 2023
Closing the PR, we will re-visit as part of the P2P Blocksync project #983 |
Fork-choice package added to the repo. It supports defining any fork-choice rule as a
func ([]*types.Block) (*types.Block, bool), it works similarly to the DA interface.The PR also integrates the fork-choice interface into
BlockManager.This PR also includes an implementation of the
FirstOrderedPurefork-choice rule, and a placeholder for theFirstOrderedCentralized, whose implementation is currently blocked by #735.