Uh oh!
There was an error while loading. Please reload this page.
Extend DA layer client interface - #83
Conversation
Codecov Report
@@ Coverage Diff @@## main #83 +/- ##
==========================================
+ Coverage 57.15% 57.82% +0.67%
==========================================
Files 19 21 +2 Lines 1230 1252 +22 ==========================================
+ Hits 703 724 +21 - Misses 428 432 +4 + Partials 99 96 -3
Continue to review full report at Codecov.
|
| func (h *Header) Hash() [32]byte { | ||
| return hash(h) | ||
| } | ||
| func (b *Block) Hash() [32]byte { |
There was a problem hiding this comment.
Question: What's the rationale to use an array and not slice?
There was a problem hiding this comment.
crypto/sha3returns array- we used arrays in structs, because hash is fixed size (logically)
There was a problem hiding this comment.
we used arrays in structs, because hash is fixed size (logically)
Totally, but in practice, we don't use fixed-size arrays and kinda forcing users to always slice it themselves, but that is ok as long you ok with that.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CheckBlockAvailabilitymethod (resolvesDefine Universal Data Availability Check API #61)BlockRetrieverinterface (resolvesDefine universal Data Availability Retrieval API #62)